<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Yes, I think the use of DBIx::Class::ResultClass::HashRefInflator is
a good way for a smooth transition to DBIx::Class.<br>
<br>
However, my current working concerns only the replacement of the
module SQLHelper by DBIx::Class, so I don't know if I could help the
community to update all the koha code with DBIx::Class ...<br>
But, If I have some question about DBIx::Class, I wouldn't hesitate
to ask you some help.<br>
<br>
Yohann<br>
<br>
<br>
<div class="moz-cite-prefix">Le 02/07/2014 20:39, Kyle Hall a
écrit :<br>
</div>
<blockquote
cite="mid:CACpVHfxzKq8SQ9BCjwr3GxmRmfUP3tBb5yqe5=Yf5oq75+EmDQ@mail.gmail.com"
type="cite">
<div dir="ltr">So far I think the patches are excellent. The use
of DBIx::Class::ResultClass::HashRefInflator is a great way to
move to using DBIx::Class in our modules without the need to
rework all the calling code to make use of dbic objects.<br>
<div><br>
</div>
<div>For long term goals I see the following steps leading us to
the most efficient use of dbic:</div>
<div>1) Replace all DBI deletes with DBIC</div>
<div>2) Replace all DBI updates with DBIC</div>
<div>3) Replace all DBI selects with DBIC using HashRefInflator</div>
<div>4) Eliminate simple module subs that do CRUD, switch to
using DBIC from scripts</div>
<div>5) Move logic out of our perl modules and into our Result
classes, and create custom ResultSet classes for operations
affecting multiple rows</div>
<div><br>
</div>
<div>This course of action will lead to much more DRY code, and
mean fewer bugs in the long run. Mandatory unit tests are also
a given.</div>
<div><br>
</div>
<div>In summary, keep up the good work Yohann! Feel free to
contact me personally for any assistance I may provide you!</div>
<div><br>
</div>
<div>Kyle</div>
</div>
<div class="gmail_extra"><br clear="all">
<div><a moz-do-not-send="true" href="http://www.kylehall.info"
target="_blank">http://www.kylehall.info</a><br>
ByWater Solutions ( <a moz-do-not-send="true"
href="http://bywatersolutions.com" target="_blank">http://bywatersolutions.com</a>
)<br>
Meadville Public Library ( <a moz-do-not-send="true"
href="http://www.meadvillelibrary.org" target="_blank">http://www.meadvillelibrary.org</a>
)<br>
Crawford County Federated Library System ( <a
moz-do-not-send="true" href="http://www.ccfls.org"
target="_blank">http://www.ccfls.org</a> )<br>
Mill Run Technology Solutions ( <a moz-do-not-send="true"
href="http://millruntech.com" target="_blank">http://millruntech.com</a>
)<br>
</div>
<br>
<br>
<div class="gmail_quote">On Mon, Jun 30, 2014 at 9:20 AM, Yohann
Dufour <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:yohann.dufour@biblibre.com" target="_blank">yohann.dufour@biblibre.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hi,<br>
<br>
I'm currently replacing C4::SQLHelper by DBIx::Class in
order to remove the module C4::SQLHelper from Koha (see <a
moz-do-not-send="true"
href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385"
target="_blank">bug 11385</a>).<br>
I've already posted two patchs with this in mind : <a
moz-do-not-send="true"
href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482"
target="_blank">bug 12482</a> and <a
moz-do-not-send="true"
href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487"
target="_blank">bug 12487</a>.<br>
Before continuing, I would like to have a feedback from
the community on the method I used to do that.<br>
<br>
Thank's for your responses,<br>
<br>
Yohann<br>
</div>
<br>
_______________________________________________<br>
Koha-devel mailing list<br>
<a moz-do-not-send="true"
href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a><br>
<a moz-do-not-send="true"
href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel"
target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a moz-do-not-send="true"
href="http://www.koha-community.org/" target="_blank">http://www.koha-community.org/</a><br>
git : <a moz-do-not-send="true"
href="http://git.koha-community.org/" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a moz-do-not-send="true"
href="http://bugs.koha-community.org/" target="_blank">http://bugs.koha-community.org/</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>