<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
The first question is a trap? Feels like a troll to start a very
long "discussion" :)<br>
<br>
Having played in that area, I can say that I had NO idea what each
of the variable names meant. I had to go to their source to guess
it.<br>
That said, maybe I could have gotten used to "rrp", if it's used
commonly. But the "it" at the end is horrible.<br>
<br>
The only downside I can see (and it's not negligible) is that DB
displays will go very large on my screen due to such long name used
on small values.<br>
<br>
So, splitting hair, I'd say rrp_incl_tax, if rrp is commonly used.
But that's just me. :)<br>
<br>
On 3), I like that very much, thank you!<br>
<br>
<br>
<div class="moz-cite-prefix">On 08/28/2014 05:58 AM, Jonathan Druart
wrote:<br>
</div>
<blockquote
cite="mid:CAJzKNY6XWLgGmTdoGKCXBXH7C3_=eQnFdaOkVE-_XK3SpY4BOQ@mail.gmail.com"
type="cite">
<pre wrap="">Thanks to Katrin and Colin for their questions/notes on the wiki page
(<a class="moz-txt-link-freetext" href="http://wiki.koha-community.org/wiki/GST_Rewrite_RFC#Questions_.2F_notes">http://wiki.koha-community.org/wiki/GST_Rewrite_RFC#Questions_.2F_notes</a>)
We need some pov on the following points:
1/ The DB field/variables names
Colin suggested not to truncate the names. But, for instance, rrp_it
would become recommended_retail_price_including_tax, not convenient.
Any thought?
2/ Rounding
I suggest to add a new pref to define the decimal to get for price
calculation. So we need to change all the price DB fields to something
like decimal(13,4).
Does it make sense for everyone?
3/ Unified the "vat", "gst" and "tax" terms into "tax". Which is more generic.
Please express yourself if you disagree.
Regards,
Jonathan
2014-07-21 17:32 GMT+02:00 Jonathan Druart <a class="moz-txt-link-rfc2396E" href="mailto:jonathan.druart@biblibre.com"><jonathan.druart@biblibre.com></a>:
</pre>
<blockquote type="cite">
<pre wrap="">Hello,
As promised, I have just finished to translate the spec for the VAT/GST rewrite.
You can found them on the wiki:
<a class="moz-txt-link-freetext" href="http://wiki.koha-community.org/wiki/GST_Rewrite_RFC">http://wiki.koha-community.org/wiki/GST_Rewrite_RFC</a>
Note that I am waiting for some feedbacks before starting the development.
I really would like to know if the logic is good for all of you/your
customers/use cases and if you agree on the values calculation.
Regards,
Jonathan
</pre>
</blockquote>
<pre wrap="">_______________________________________________
Koha-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a>
<a class="moz-txt-link-freetext" href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a>
website : <a class="moz-txt-link-freetext" href="http://www.koha-community.org/">http://www.koha-community.org/</a>
git : <a class="moz-txt-link-freetext" href="http://git.koha-community.org/">http://git.koha-community.org/</a>
bugs : <a class="moz-txt-link-freetext" href="http://bugs.koha-community.org/">http://bugs.koha-community.org/</a>
</pre>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<style type="text/css">
.moz-signature {
color: #FFFFFF;
}
.sig_inlibro {
padding-top : 2px;
color: #888888;
font-family : "Trebuchet MS", verdana;
font-size: 90%;
}
.sig_content {
border-top: 2px solid #DDDDDD;
border-bottom: 2px solid #BFD13D;
background-color : #F6F6F6;
padding-left:10px;
}
.sig_inlibro a:visited, .sig_inlibro a:hover, .sig_inlibro a:link {
text-decoration: none;
color: #005B85;
}
.nom {
color: #005B85;
font-weight : bold;
}
.inlibro, .in {
color: #BFD13D;
}
.libro {
color: #005B85;
}
.in, .libro {
font-size : 120%;
}
.desc {
margin-bottom: 0;
padding-bottom: 5px;
}
.small {
font-size: 80%;
}
.tagline {
color : #00BCE4;
}
.sig_footer {
padding-left : 10px;
background-color : #EEEFEA;
}
</style>
<div class="sig_inlibro">
<div class="sig_content"> <span class="nom">Philippe Blouin,</span><br>
<span class="tagline small">Responsable du développement
informatique</span><br>
<p class="desc small"> Tél. : (888) 604-2627<br>
<a href="mailto:philippe.blouin@inLibro.com">philippe.blouin@inLibro.com</a>
</p>
</div>
<div class="sig_footer"> <span class="in">in</span><span
class="libro">Libro</span> <span class="tagline small">|
pour esprit libre |</span> <a class="small"
href="http://www.inLibro.com">www.inLibro.com</a> </div>
</div>
</div>
</body>
</html>