<div dir="ltr"><div><div><div>HI Marcel - <br><br></div>I think most everyone that was in attendance thought differently then those guidelines. Some said 3 months others said not at all, etc etc. So I'm just bring this up so that everyone is on the same page and changing the guideline so that there isn't a 1 month "wait" period. (Yes it is evident that communication in the community is lacking)<br><br></div>Thanks,<br></div>Brendan<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 13, 2014 at 12:45 AM, Marcel de Rooy <span dir="ltr"><<a href="mailto:M.de.Rooy@rijksmuseum.nl" target="_blank">M.de.Rooy@rijksmuseum.nl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt"><span class="">
<p>> I’d like to put forward a motion for removal of the guideline that one company shouldn’t sign-off on the same</p>
<p>> company's patches within the community. I am suggesting additional checks be included in the sign-off process
</p>
<p>> to prevent abuse of the proposed guideline, such as the committer and the person signing off must not have
</p>
<p>> collaborated on the development of the patch. <br>
</p>
</span><p>See: <a href="http://wiki.koha-community.org/wiki/Development_workflow" target="_blank">http://wiki.koha-community.org/wiki/Development_workflow</a></p>
<p>These workflow rules on the wiki already say: </p>
<p><strong>Preferably</strong>, patch writer and patch signer should not be from the same company or institution.
</p>
<p>Yes, it is preferred but is not strictly required.</p>
<p>And also: </p>
<p>If a patch is not passed QA for one month, then it can be QA'd by someone from the same company or institution.</p>
<p> </p>
<p>I would suggest to make the following change:</p>
<p>If a patch has not been signed for one month, it can be signed off by someone from the same company or institution. (Easy to check by QAer.)
</p>
<p>And to prevent "abuse" of the combination (signoff and QA in the same company):</p>
<p>If a patch has not passed QA for one month, then it can be QA'd by someone from the same company or institution UNLESS it is already signed by someone from the same company. (Does this rule need a sort of escape to prevent very specific patches waiting for
several months in the SO queue?)</p><span class="HOEnZb"><font color="#888888">
<p> </p>
<p>Marcel</p>
<p> </p>
</font></span></div>
</div>
<br>_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="http://www.koha-community.org/" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" target="_blank">http://bugs.koha-community.org/</a><br></blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">---------------------------------------------------------------------------------------------------------------<br>Brendan A. Gallagher<br>ByWater Solutions<br>CEO<br><br>Support and Consulting for Open Source Software<br>Installation, Data Migration, Training, Customization, Hosting<br>and Complete Support Packages<br>Headquarters: Santa Barbara, CA - Office: Redding, CT<br>Phone # (888) 900-8944<br><a href="http://bywatersolutions.com" target="_blank">http://bywatersolutions.com</a><br><a href="mailto:info@bywatersolutions.com" target="_blank">info@bywatersolutions.com</a><br></div>
</div>