<div dir="ltr"><div><div><div><div><div>Hello Mark,<br></div><br>A lot of tests assume that some data exist in DB.<br></div></div>IMO we need to keep this assumption, it permits not to create all data when you want to write tests (member categories, branches, AV, etc.). That simplifies the read of tests.<br>Since TestBuilder (bug 12603) is not pushed yet, I don't think we should require to create these data.<br></div>To get a DB with all tests (should) pass, you can have a look at bug 10337.<br></div><br>Regards,<br>Jonathan<br><div class="gmail_extra"><br><div class="gmail_quote">2014-12-13 5:16 GMT+01:00 Mark Tompsett <span dir="ltr"><<a href="mailto:mtompset@hotmail.com" target="_blank">mtompset@hotmail.com</a>></span>:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div dir="ltr">
<div style="FONT-SIZE:12pt;FONT-FAMILY:'Calibri';COLOR:#000000">
<div>Greetings,</div>
<div> </div>
<div>Anyone looking for some simple sign offs, I think you might like these.
</div>
<div> </div>
<table style="COLOR:#000000" cellpadding="4" cellspacing="0" width="100%">
<tbody>
<tr>
<td><a><font face="Times New Roman">13451</font></a><font face="Times New Roman">
</font></td>
<td style="WHITE-SPACE:nowrap"><span title="Koha"><font face="Times New Roman">Koha </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="Test Suite"><font face="Times New Roman">Test Sui </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="mtompset@hotmail.com"><font face="Times New Roman"><a href="mailto:mtompset@hotmail.com" target="_blank">mtompset@hotmail.com</a> </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="Needs Signoff"><font face="Times New Roman">Need </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="---"><font face="Times New Roman">--- </font></span></td>
<td><a><font face="Times New Roman">Holidays.t assumes default data </font></a></td>
<td style="WHITE-SPACE:nowrap"><font face="Times New Roman">16:56:22</font></td></tr>
<tr>
<td><a><font face="Times New Roman">13453</font></a><font face="Times New Roman">
</font></td>
<td style="WHITE-SPACE:nowrap"><span title="Koha"><font face="Times New Roman">Koha </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="Test Suite"><font face="Times New Roman">Test Sui </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="mtompset@hotmail.com"><font face="Times New Roman"><a href="mailto:mtompset@hotmail.com" target="_blank">mtompset@hotmail.com</a> </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="Needs Signoff"><font face="Times New Roman">Need </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="---"><font face="Times New Roman">--- </font></span></td>
<td><a><font face="Times New Roman">Koha.t daily quote tests assume sample data
</font></a></td>
<td style="WHITE-SPACE:nowrap"><font face="Times New Roman">17:31:12 </font></td></tr>
<tr>
<td><a><font face="Times New Roman">13455</font></a><font face="Times New Roman">
</font></td>
<td style="WHITE-SPACE:nowrap"><span title="Koha"><font face="Times New Roman">Koha </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="Test Suite"><font face="Times New Roman">Test Sui </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="mtompset@hotmail.com"><font face="Times New Roman"><a href="mailto:mtompset@hotmail.com" target="_blank">mtompset@hotmail.com</a> </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="Needs Signoff"><font face="Times New Roman">Need </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="---"><font face="Times New Roman">--- </font></span></td>
<td><a><font face="Times New Roman">Members/AddEnrolmentFeeIfNeeded.t requires sample
data </font></a></td>
<td style="WHITE-SPACE:nowrap"><font face="Times New Roman">20:49:57 </font></td></tr>
<tr>
<td><a><font face="Times New Roman">13456</font></a><font face="Times New Roman">
</font></td>
<td style="WHITE-SPACE:nowrap"><span title="Koha"><font face="Times New Roman">Koha </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="Test Suite"><font face="Times New Roman">Test Sui </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="mtompset@hotmail.com"><font face="Times New Roman"><a href="mailto:mtompset@hotmail.com" target="_blank">mtompset@hotmail.com</a> </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="Needs Signoff"><font face="Times New Roman">Need </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="---"><font face="Times New Roman">--- </font></span></td>
<td><a><font face="Times New Roman">Serials/Claims.t expects no subscriptions
</font></a></td>
<td style="WHITE-SPACE:nowrap"><font face="Times New Roman">21:35:54 </font></td></tr>
<tr>
<td><a><font face="Times New Roman">13457</font></a><font face="Times New Roman">
</font></td>
<td style="WHITE-SPACE:nowrap"><span title="Koha"><font face="Times New Roman">Koha </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="Test Suite"><font face="Times New Roman">Test Sui </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="mtompset@hotmail.com"><font face="Times New Roman"><a href="mailto:mtompset@hotmail.com" target="_blank">mtompset@hotmail.com</a> </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="Needs Signoff"><font face="Times New Roman">Need </font></span></td>
<td style="WHITE-SPACE:nowrap"><span title="---"><font face="Times New Roman">--- </font></span></td>
<td><a><font face="Times New Roman">Suggestions.t expects sample itemtypes
</font></a></td>
<td style="WHITE-SPACE:nowrap"><font face="Times New Roman">22:06:04 </font></td></tr></tbody></table>
<div> </div>
<div>I found them when I attempted:</div>
<div>$ prove -r t</div>
<div> </div>
<div>I’m still thinking about how to fix:</div>
<div>t/db_dependent/Reserves.t</div>
<div>t/db_dependent/SIP_ILS.t</div>
<div>t/db_dependent/www/batch.t</div>
<div> </div>
<div>In making our tables more javascripty-ajaxy, we broke www/batch.t as far as
I can tell. Though, I could be wrong.</div>
<div> </div>
<div>GPML,</div>
<div>Mark Tompsett</div></div></div></div>
<br>_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="http://www.koha-community.org/" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" target="_blank">http://bugs.koha-community.org/</a><br></blockquote></div></div></div>