<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
Hi,<br>
<br>
Bernardo Gonzales Kriegel made a lot of work with bug 12017 around
this, and clean up getFrameworkLanguages and other useless things.<br>
<br>
It also move the language_description table out of database, and put
it in templates.<br>
This is really interesting concerning traduction and performances !<br>
<br>
Regards,<br>
Julian FIOL<br>
<br>
<br>
<div class="moz-cite-prefix">On 28/05/2015 16:31, Mark Tompsett
wrote:<br>
</div>
<blockquote cite="mid:BLU172-DS1582A8F34BB753A4D41A10C6CA0@phx.gbl"
type="cite">Greetings,
<br>
<br>
Indranil Das Gupta found this painful to see typo in
getFrameworkLanguages:
'native_descrition'=>$language_set->{language_native_description}.
<br>
I told him, tweaking C4/Languages requires writing a test (good
rule of thumb). So, I wake up, and discover no tests were yet
written, and I was itching for a sign off. So, I attempt and
discover the hole is deeper than initially thought. In fact,
Indranil Das Gupta pointed out to me that it doesn't seem to be
used anywhere.
<br>
<br>
mtompset@debian:~/kohaclone$ git grep getFrameworkLanguages
<br>
C4/Languages.pm: memoize_memcached('getFrameworkLanguages'
, memcached => C4::Context->memcached);
<br>
<br>
Part of an export --
<br>
C4/Languages.pm: &getFrameworkLanguages
<br>
<br>
More exporting --
<br>
C4/Languages.pm: @EXPORT_OK = qw(getFrameworkLanguages
getTranslatedLanguages getAllLanguages getLanguages get_bidi
regex_lang_subtags language_get_description accept_language
getlanguage);
<br>
<br>
POD stuff --
<br>
C4/Languages.pm:=head2 getFrameworkLanguages
<br>
<br>
POD stuff example --
<br>
C4/Languages.pm: my $languages = getFrameworkLanguages();
<br>
<br>
Actual function head --
<br>
C4/Languages.pm:sub getFrameworkLanguages {
<br>
<br>
<br>
As you can tell I didn't comment on one piece: that
memoize_memcached line. Is there another thing to trace to figure
out if it is used in the memoize logic somewhere, or is it safe to
remove this function? Feedback appreciated.
<br>
<br>
What bug 14284 becomes is dependent on feedback.
<br>
<a class="moz-txt-link-freetext" href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284">http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284</a>
<br>
<br>
GPML,
<br>
Mark Tompsett <br>
_______________________________________________
<br>
Koha-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a>
<br>
website : <a class="moz-txt-link-freetext" href="http://www.koha-community.org/">http://www.koha-community.org/</a>
<br>
git : <a class="moz-txt-link-freetext" href="http://git.koha-community.org/">http://git.koha-community.org/</a>
<br>
bugs : <a class="moz-txt-link-freetext" href="http://bugs.koha-community.org/">http://bugs.koha-community.org/</a>
<br>
</blockquote>
<br>
</body>
</html>