<HTML><HEAD></HEAD>
<BODY dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-SIZE: 12pt; FONT-FAMILY: 'Calibri'; COLOR: #000000">
<DIV>Greetings,</DIV>
<DIV> </DIV>
<DIV>Shortly after I posted my note, I noticed bug 12017. <IMG
class="wlEmoticon wlEmoticon-smile"
style="BORDER-TOP-STYLE: none; BORDER-BOTTOM-STYLE: none; BORDER-RIGHT-STYLE: none; BORDER-LEFT-STYLE: none"
alt=Smile src="cid:64521A20BA05475C849C81B2245235A6@archangel"></DIV>
<DIV>It removes it. I think we may have a duplicate. Sorry, Indranil Das
Gupta.</DIV>
<DIV> </DIV>
<DIV>GPML,</DIV>
<DIV>Mark Tompsett</DIV>
<DIV
style='FONT-SIZE: small; TEXT-DECORATION: none; FONT-FAMILY: "Calibri"; FONT-WEIGHT: normal; COLOR: #000000; FONT-STYLE: normal; DISPLAY: inline'>
<DIV style="FONT: 10pt tahoma">
<DIV> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A title=tomascohen@gmail.com
href="mailto:tomascohen@gmail.com">Tomas Cohen Arazi</A> </DIV>
<DIV><B>Sent:</B> Thursday, May 28, 2015 10:35 AM</DIV>
<DIV><B>To:</B> <A title=mtompset@hotmail.com
href="mailto:mtompset@hotmail.com">Mark Tompsett</A> </DIV>
<DIV><B>Cc:</B> <A title=koha-devel@lists.koha-community.org
href="mailto:koha-devel@lists.koha-community.org">koha-devel</A> </DIV>
<DIV><B>Subject:</B> Re: [Koha-devel] getFrameworkLanguages</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style='FONT-SIZE: small; TEXT-DECORATION: none; FONT-FAMILY: "Calibri"; FONT-WEIGHT: normal; COLOR: #000000; FONT-STYLE: normal; DISPLAY: inline'>
<DIV dir=ltr>We have dead code in lots of places. A cleanup is not a bad idea,
but we should be careful with API changes because someone could be using it. I
didn't spend time on looking at the code. We can add it to the agentda for the
meeting.</DIV>
<DIV class=gmail_extra>
<DIV> </DIV>
<DIV class=gmail_quote>2015-05-28 11:31 GMT-03:00 Mark Tompsett <SPAN
dir=ltr><<A href="mailto:mtompset@hotmail.com"
target=_blank>mtompset@hotmail.com</A>></SPAN>:<BR>
<BLOCKQUOTE class=gmail_quote
style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">Greetings,<BR><BR>Indranil
Das Gupta found this painful to see typo in getFrameworkLanguages:
'native_descrition'=>$language_set->{language_native_description}.<BR>I
told him, tweaking C4/Languages requires writing a test (good rule of thumb).
So, I wake up, and discover no tests were yet written, and I was itching for a
sign off. So, I attempt and discover the hole is deeper than initially
thought. In fact, Indranil Das Gupta pointed out to me that it doesn't seem to
be used anywhere.<BR><BR>mtompset@debian:~/kohaclone$ git grep
getFrameworkLanguages<BR>C4/Languages.pm:
memoize_memcached('getFrameworkLanguages' , memcached =>
C4::Context->memcached);<BR><BR>Part of an export
--<BR>C4/Languages.pm:
&getFrameworkLanguages<BR><BR>More exporting
--<BR>C4/Languages.pm: @EXPORT_OK = qw(getFrameworkLanguages
getTranslatedLanguages getAllLanguages getLanguages get_bidi
regex_lang_subtags language_get_description accept_language
getlanguage);<BR><BR>POD stuff --<BR>C4/Languages.pm:=head2
getFrameworkLanguages<BR><BR>POD stuff example --<BR>C4/Languages.pm: my
$languages = getFrameworkLanguages();<BR><BR>Actual function head
--<BR>C4/Languages.pm:sub getFrameworkLanguages {<BR><BR><BR>As you can tell I
didn't comment on one piece: that memoize_memcached line. Is there another
thing to trace to figure out if it is used in the memoize logic somewhere, or
is it safe to remove this function? Feedback appreciated.<BR><BR>What bug
14284 becomes is dependent on feedback.<BR><A
href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284"
target=_blank>http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284</A><BR><BR>GPML,<BR>Mark
Tompsett <BR>_______________________________________________<BR>Koha-devel
mailing list<BR><A href="mailto:Koha-devel@lists.koha-community.org"
target=_blank>Koha-devel@lists.koha-community.org</A><BR><A
href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel"
target=_blank>http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</A><BR>website
: <A href="http://www.koha-community.org/"
target=_blank>http://www.koha-community.org/</A><BR>git : <A
href="http://git.koha-community.org/"
target=_blank>http://git.koha-community.org/</A><BR>bugs : <A
href="http://bugs.koha-community.org/"
target=_blank>http://bugs.koha-community.org/</A><BR></BLOCKQUOTE></DIV><BR><BR
clear=all>
<DIV> </DIV>-- <BR>
<DIV class=gmail_signature>
<DIV dir=ltr>
<DIV>Tomás Cohen Arazi</DIV>
<DIV>Prosecretaría de Informática</DIV>
<DIV>Universidad Nacional de Córdoba</DIV>
<DIV>✆ +54 351 5353750 ext 13168</DIV>
<DIV>GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3
C15F</DIV></DIV></DIV></DIV></DIV></DIV></DIV></BODY></HTML>