<HTML><HEAD></HEAD>
<BODY dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-SIZE: 12pt; FONT-FAMILY: 'Calibri'; COLOR: #000000">
<DIV>Greetings,</DIV>
<DIV> </DIV>
<DIV>Your steps to reproduce are insufficient.</DIV>
<DIV> </DIV>
<DIV>I have a fresh install with demo data.</DIV>
<DIV>I turned on ExtendedPatronAttributes.</DIV>
<DIV>I went at looked at the modification log for a patron.</DIV>
<DIV>Nothing blew up.</DIV>
<DIV> </DIV>
<DIV>Please give more detailed step by step instructions on how to
reproduce.</DIV>
<DIV>- What did you do to generate modification log entries?</DIV>
<DIV>- Do they even have modification log entries?</DIV>
<DIV>- “So please explain in detail things like if the patron has or hasn't
extended attributes, etc.”</DIV>
<DIV>- So do they have extended attributes?</DIV>
<DIV>- What attributes? How many? What are their values?</DIV>
<DIV> </DIV>
<DIV>GPML,</DIV>
<DIV>Mark Tompsett</DIV>
<DIV> </DIV>
<DIV
style='FONT-SIZE: small; TEXT-DECORATION: none; FONT-FAMILY: "Calibri"; FONT-WEIGHT: normal; COLOR: #000000; FONT-STYLE: normal; DISPLAY: inline'>
<DIV style="FONT: 10pt tahoma">
<DIV><FONT size=3 face=Calibri></FONT> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A title=long_sam.tw@yahoo.com.tw
href="mailto:long_sam.tw@yahoo.com.tw">long_sam.tw</A> </DIV>
<DIV><B>Sent:</B> Thursday, June 11, 2015 10:52 AM</DIV>
<DIV><B>To:</B> <A title=tomascohen@gmail.com
href="mailto:tomascohen@gmail.com">Tomas Cohen Arazi</A> ; <A
title=koha-devel@lists.koha-community.org
href="mailto:koha-devel@lists.koha-community.org">koha-devel</A> </DIV>
<DIV><B>Subject:</B> Re: [Koha-devel] viewlog bug</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style='FONT-SIZE: small; TEXT-DECORATION: none; FONT-FAMILY: "Calibri"; FONT-WEIGHT: normal; COLOR: #000000; FONT-STYLE: normal; DISPLAY: inline'>
<DIV
style="FONT-SIZE: 16px; FONT-FAMILY: helveticaneue, helvetica neue, helvetica, arial, lucida grande, sans-serif; COLOR: #000; BACKGROUND-COLOR: #fff">
<DIV id=yui_3_16_0_1_1434030798203_7873><SPAN></SPAN></DIV>
<DIV id=yui_3_16_0_1_1434030798203_8057>Dear tomas, </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8110> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8031 dir=ltr><A
id=yui_3_16_0_1_1434030798203_8030
href="http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD">http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD</A><BR></DIV>
<DIV id=yui_3_16_0_1_1434030798203_8031 dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8109
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre"><A id=l80
style="TEXT-DECORATION: none; COLOR: rgb(153,153,153)"
href="http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD#l80">80</A>
if ( C4::Context->preference('ExtendedPatronAttributes') ) {</DIV>
<DIV id=yui_3_16_0_1_1434030798203_8147
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre"><A id=l81
style="TEXT-DECORATION: none; COLOR: rgb(153,153,153)"
href="http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD#l81">81</A>
my $attributes = GetBorrowerAttributes( $data->{'borrowernumber'} );</DIV>
<DIV id=yui_3_16_0_1_1434030798203_8148
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre"><A id=l82
style="TEXT-DECORATION: none; COLOR: rgb(153,153,153)"
href="http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD#l82">82</A>
$template->param(</DIV>
<DIV id=yui_3_16_0_1_1434030798203_8108
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre"><A id=l83
style="TEXT-DECORATION: none; COLOR: rgb(153,153,153)"
href="http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD#l83">83</A>
ExtendedPatronAttributes => 1,</DIV>
<DIV id=yui_3_16_0_1_1434030798203_8102
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre"><A id=l84
style="TEXT-DECORATION: none; COLOR: rgb(153,153,153)"
href="http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD#l84">84</A>
extendedattributes => $attributes</DIV>
<DIV id=yui_3_16_0_1_1434030798203_8103
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre"><A id=l85
style="TEXT-DECORATION: none; COLOR: rgb(153,153,153)"
href="http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD#l85">85</A>
);</DIV>
<DIV id=yui_3_16_0_1_1434030798203_8104
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre" dir=ltr><A
id=l86 style="TEXT-DECORATION: none; COLOR: rgb(153,153,153)"
href="http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD#l86">86</A>
}</DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr><BR>If you
turn on [ExtendedPatronAttributes] options, </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr>then it call
GetBorrowerAttributes function. </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr>You use
C4::Members::Attributes module, but there isn't the module in front ofin front
of viewlog.pl . </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr><A
id=yui_3_16_0_1_1434030798203_8379
href="http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Members/Attributes.pm;h=a56a6273a5716390726eb81480a5864b3acf43dd;hb=HEAD">http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Members/Attributes.pm;h=a56a6273a5716390726eb81480a5864b3acf43dd;hb=HEAD</A><BR></DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr>Reproduce
the error , you can turn on [ExtendedPatronAttributes] options </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr>in the
system preference</DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr>http://your
koha ip :8080/cgi-bin/koha/admin/preferences.pl<BR></DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr>, and view
<BR></DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr><A
id=yui_3_16_0_1_1434030798203_9759
href="http://140.136.152.183:8080/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&object=1&src=circ">http://your
koha
ip:8080/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&object=1&src=circ</A><BR></DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr>Version
affected 3.16.x,<BR></DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr>Version
3.18, 3.20 are ok</DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr>line 74 they
have add "use C4::Members::Attributes qw(GetBorrowerAttributes)" </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR dir=ltr>
<DIV id=yui_3_16_0_1_1434030798203_10613
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre"><A id=l74
style="TEXT-DECORATION: none; COLOR: rgb(153,153,153)"
href="http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD#l74">74</A>
use C4::Members::Attributes qw(GetBorrowerAttributes);</DIV>
<DIV id=yui_3_16_0_1_1434030798203_10606
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre" dir=ltr><A
id=l75 style="TEXT-DECORATION: none; COLOR: rgb(153,153,153)"
href="http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=tools/viewlog.pl;h=a13ec5faf27e8692f11684e8c7b0075590d7595d;hb=HEAD#l75">75</A>
my $borrowernumber = $object;</DIV>
<DIV id=yui_3_16_0_1_1434030798203_10606
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre"
dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_10606
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre" dir=ltr>,so
there no error. </DIV>
<DIV id=yui_3_16_0_1_1434030798203_10606
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre"
dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_10606
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre"
dir=ltr>Thanks a lot,</DIV>
<DIV id=yui_3_16_0_1_1434030798203_10606
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre"
dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_10606
style="FONT-SIZE: small; FONT-FAMILY: monospace; WHITE-SPACE: pre" dir=ltr>龍山
</DIV></DIV>
<DIV id=yui_3_16_0_1_1434030798203_7895 class=qtdSeparateBR> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_7892 class=yahoo_quoted
style="DISPLAY: block">
<DIV id=yui_3_16_0_1_1434030798203_7891
style="FONT-SIZE: 16px; FONT-FAMILY: helveticaneue, helvetica neue, helvetica, arial, lucida grande, sans-serif">
<DIV id=yui_3_16_0_1_1434030798203_7890
style="FONT-SIZE: 16px; FONT-FAMILY: helveticaneue, helvetica neue, helvetica, arial, lucida grande, sans-serif">
<DIV id=yui_3_16_0_1_1434030798203_7894 dir=ltr><FONT
id=yui_3_16_0_1_1434030798203_7893 size=2 face=Arial>Tomas Cohen Arazi
<tomascohen@gmail.com> 於 2015/6/11 (週四) 10:14 PM
寫道﹕<BR></FONT></DIV><BR><BR>
<DIV id=yui_3_16_0_1_1434030798203_8020 class=y_msg_container>
<DIV id=yiv4836934253>
<DIV id=yui_3_16_0_1_1434030798203_8019>
<DIV id=yui_3_16_0_1_1434030798203_8018 dir=ltr>You should definitely fill a bug
on <A id=yui_3_16_0_1_1434030798203_8283 href="http://bugs.koha-community.org/"
shape=rect rel=nofollow target=_blank>http://bugs.koha-community.org</A> about
it.
<DIV id=yui_3_16_0_1_1434030798203_8017> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8195>A side note: I couldn't reproduce the
error on my test site. So please explain in detail things like if the patron has
or hasn't extended attributes, etc.</DIV></DIV>
<DIV id=yui_3_16_0_1_1434030798203_8022 class=yiv4836934253gmail_extra>
<DIV> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8021
class=yiv4836934253gmail_quote>2015-06-11 0:53 GMT-03:00 <A
id=yui_3_16_0_1_1434030798203_8419 href="http://long_sam.tw/" shape=rect
rel=nofollow target=_blank>long_sam.tw</A> <SPAN
id=yui_3_16_0_1_1434030798203_8960 dir=ltr><<A
id=yui_3_16_0_1_1434030798203_8959 href="mailto:long_sam.tw@yahoo.com.tw"
shape=rect rel=nofollow target=_blank
ymailto="mailto:long_sam.tw@yahoo.com.tw">long_sam.tw@yahoo.com.tw</A>></SPAN>:<BR
clear=none>
<DIV id=yiv4836934253yqt48166 class=yiv4836934253yqt4908341124>
<DIV id=yui_3_16_0_1_1434030798203_8025>
<DIV id=yui_3_16_0_1_1434030798203_8024
style="FONT-SIZE: 16px; FONT-FAMILY: helveticaneue, helvetica neue, helvetica, arial, lucida grande, sans-serif; COLOR: #000; BACKGROUND-COLOR: #fff">
<DIV id=yui_3_16_0_1_1434030798203_9082>Dear koha floks, </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8285> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8023 dir=ltr>I found viewlog bugs. If you
turn on [ExtendedPatronAttributes], </DIV>
<DIV dir=ltr>then view Home › Patrons › Modification log</DIV>
<DIV id=yui_3_16_0_1_1434030798203_9083 dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8286 dir=ltr>Software error:</DIV>
<DIV id=yui_3_16_0_1_1434030798203_8266 dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8267 dir=ltr>Undefined subroutine
&main::GetBorrowerAttributes called at
/usr/share/koha/intranet/cgi-bin/tools/<A href="http://viewlog.pl/" shape=rect
rel=nofollow target=_blank>viewlog.pl</A> line 82.</DIV>
<DIV id=yui_3_16_0_1_1434030798203_8269 dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8287 dir=ltr>Bug fix </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8288 dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8293 dir=ltr>modify <A
href="http://viewlog.pl/" shape=rect rel=nofollow
target=_blank>viewlog.pl</A> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8292 dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8291 dir=ltr>line 82</DIV>
<DIV id=yui_3_16_0_1_1434030798203_8289 dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8418 dir=ltr>change</DIV>
<DIV id=yui_3_16_0_1_1434030798203_8417 dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8416 dir=ltr>my $attributes =
GetBorrowerAttributes( $data->{'borrowernumber'} ); <BR clear=none></DIV>
<DIV id=yui_3_16_0_1_1434030798203_8298 dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8411 dir=ltr>to </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8412 dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_8413 dir=ltr>my $attributes =
C4::Members::Attributes::GetBorrowerAttributes( $data->{'borrowernumber'}
);<BR clear=none></DIV>
<DIV dir=ltr> </DIV>
<DIV dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_9099 dir=ltr>Koha version : 3.16.11, 3.18.7,
3.20</DIV>
<DIV dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_9087 dir=ltr>Help me patch viewlogs next
release version.<BR clear=none></DIV>
<DIV dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_9093 dir=ltr>Thanks a lot</DIV>
<DIV id=yui_3_16_0_1_1434030798203_9095 dir=ltr> </DIV>
<DIV id=yui_3_16_0_1_1434030798203_9085 dir=ltr>龍山</DIV></DIV></DIV></DIV><BR
clear=none>_______________________________________________<BR
clear=none>Koha-devel mailing list<BR clear=none><A
href="mailto:Koha-devel@lists.koha-community.org" shape=rect rel=nofollow
target=_blank
ymailto="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</A><BR
clear=none><A
href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel"
shape=rect rel=nofollow
target=_blank>http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</A><BR
clear=none>website : <A href="http://www.koha-community.org/" shape=rect
rel=nofollow target=_blank>http://www.koha-community.org/</A><BR clear=none>git
: <A href="http://git.koha-community.org/" shape=rect rel=nofollow
target=_blank>http://git.koha-community.org/</A><BR clear=none>bugs : <A
href="http://bugs.koha-community.org/" shape=rect rel=nofollow
target=_blank>http://bugs.koha-community.org/</A><BR clear=none></DIV><BR
clear=none><BR clear=all>
<DIV> </DIV>-- <BR clear=none>
<DIV id=yui_3_16_0_1_1434030798203_9090 class=yiv4836934253gmail_signature>
<DIV id=yui_3_16_0_1_1434030798203_9089 dir=ltr>
<DIV id=yui_3_16_0_1_1434030798203_9088>Tomás Cohen Arazi</DIV>
<DIV>Prosecretaría de Informática</DIV>
<DIV>Universidad Nacional de Córdoba</DIV>
<DIV id=yui_3_16_0_1_1434030798203_9092>✆ +54 351 5353750 ext 13168</DIV>
<DIV>GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3
C15F</DIV></DIV></DIV></DIV></DIV></DIV>
<DIV> </DIV>
<DIV id=yqt34321
class=yqt4908341124>_______________________________________________<BR
clear=none>Koha-devel mailing list<BR clear=none><A
href="mailto:Koha-devel@lists.koha-community.org" shape=rect
ymailto="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</A><BR
clear=none><A
href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel"
shape=rect
target=_blank>http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</A><BR
clear=none>website : <A href="http://www.koha-community.org/" shape=rect
target=_blank>http://www.koha-community.org/</A><BR clear=none>git : <A
href="http://git.koha-community.org/" shape=rect
target=_blank>http://git.koha-community.org/</A><BR clear=none>bugs : <A
href="http://bugs.koha-community.org/" shape=rect
target=_blank>http://bugs.koha-community.org/</A></DIV><BR><BR></DIV></DIV></DIV></DIV></DIV>
<P>
<HR>
_______________________________________________<BR>Koha-devel mailing
list<BR>Koha-devel@lists.koha-community.org<BR>http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<BR>website
: http://www.koha-community.org/<BR>git : http://git.koha-community.org/<BR>bugs
: http://bugs.koha-community.org/</DIV></DIV></DIV></BODY></HTML>