<div dir="ltr">+1. Would definitely recommend to a friend.<div><br></div><div>--Barton </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 19, 2015 at 11:17 AM, Jesse <span dir="ltr"><<a href="mailto:pianohacker@gmail.com" target="_blank">pianohacker@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Definite +1 to this.<br><br></div><div>Should we also discuss adding this to the coding standards at the next development meeting?<br></div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">2015-06-19 8:43 GMT-06:00 Jonathan Druart <span dir="ltr"><<a href="mailto:jonathan.druart@biblibre.com" target="_blank">jonathan.druart@biblibre.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The discussion started from bug 12598 comment 44.<br>
For instance, do we want Koha::Patron::Import or Koha::Import::Patron?<br>
<span><br>
2015-06-19 15:35 GMT+01:00 Kyle Hall <<a href="mailto:kyle.m.hall@gmail.com" target="_blank">kyle.m.hall@gmail.com</a>>:<br>
</span><div><div>> It's been discussed a few times, but I think we need to formalize naming<br>
> conventions when writing patches for Koha.<br>
><br>
> The worse offenders are those things that we use many different names for<br>
> both internally and externally. I think patrons/borrowers/members is the<br>
> worst offender. List come to mind as well ( previously being virtual shelves<br>
> ).<br>
><br>
> I believe that our internal nomenclature should reflect our outward<br>
> nomenclature. So if the staff and/or OPAC use the term "patron" we should be<br>
> using the term "patron" in our code as well, especially for namespaces.<br>
><br>
> What does everyone think?<br>
><br>
> The more we hammer out now the easier it will be to vote on naming rules at<br>
> the dev meeting.<br>
><br>
> Kyle<br>
><br>
> <a href="http://www.kylehall.info" rel="noreferrer" target="_blank">http://www.kylehall.info</a><br>
> ByWater Solutions ( <a href="http://bywatersolutions.com" rel="noreferrer" target="_blank">http://bywatersolutions.com</a> )<br>
> Meadville Public Library ( <a href="http://www.meadvillelibrary.org" rel="noreferrer" target="_blank">http://www.meadvillelibrary.org</a> )<br>
> Crawford County Federated Library System ( <a href="http://www.ccfls.org" rel="noreferrer" target="_blank">http://www.ccfls.org</a> )<br>
> Mill Run Technology Solutions ( <a href="http://millruntech.com" rel="noreferrer" target="_blank">http://millruntech.com</a> )<br>
><br>
</div></div><div><div>> _______________________________________________<br>
> Koha-devel mailing list<br>
> <a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-community.org</a><br>
> <a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
> website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
> git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
> bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.org/</a><br>
_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.org/</a><br>
</div></div></blockquote></div><br><br clear="all"><br></div></div><span class="HOEnZb"><font color="#888888">-- <br><div>Jesse Weaver</div>
</font></span></div>
<br>_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.org/</a><br></blockquote></div><br></div>