<div dir="ltr">I don't prepend a status to patches for the reasons Barton outlined. The only time I do is when a patch set is partially signed off. You milage may vary ; )<div><br></div><div>Kyle</div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><a href="http://www.kylehall.info" target="_blank">http://www.kylehall.info</a><br>ByWater Solutions ( <a href="http://bywatersolutions.com" target="_blank">http://bywatersolutions.com</a> )<br>Meadville Public Library ( <a href="http://www.meadvillelibrary.org" target="_blank">http://www.meadvillelibrary.org</a> )<br>Crawford County Federated Library System ( <a href="http://www.ccfls.org" target="_blank">http://www.ccfls.org</a> )<br>Mill Run Technology Solutions ( <a href="http://millruntech.com" target="_blank">http://millruntech.com</a> )<br></div></div>
<br><div class="gmail_quote">On Mon, Feb 1, 2016 at 5:55 PM, Katrin Fischer <span dir="ltr"><<a href="mailto:Katrin.Fischer.83@web.de" target="_blank">Katrin.Fischer.83@web.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I am using a very similar command for adding [PASSED QA] and my sign-off<br>
line to multiple patches. Found on the wiki some time ago:<br>
<a href="https://wiki.koha-community.org/wiki/Tips_and_tricks" rel="noreferrer" target="_blank">https://wiki.koha-community.org/wiki/Tips_and_tricks</a><br>
<br>
qa2 = "!f() { c=`expr $1 - 1`; git filter-branch -f --msg-filter \"echo<br>
-n \\\"[PASSED QA] \\\" && cat && echo \\\"\nSigned-off-by: author<br>
<<a href="mailto:author@mail.com">author@mail.com</a>>\\\"\" HEAD~$c^..; }; f"<br>
<br>
Run as:<br>
git qa2 <number of commits><br>
git qa2 5<br>
<br>
Then next something like:<br>
git bz attach <bug number> HEAD~5..<br>
git bz edit <bug number><br>
<br>
So far I haven't seen any problems with it. Not sure about the effects<br>
on obsoleting patches.<br>
<br>
Katrin<br>
<span class=""><br>
<br>
<br>
Am 01.02.2016 um 17:58 schrieb Barton Chittenden:<br>
> Yes, it's possible<br>
><br>
> Here's what I use:<br>
><br>
> so = "!f() { c=`expr $1 - 1`; git filter-branch -f --msg-filter \"echo<br>
> -n \\\"[SIGNED-OFF] \\\" && cat && echo \\\"\nSigned-off-by: Barton<br>
> Chittenden <<a href="mailto:barton@bywatersolutions.com">barton@bywatersolutions.com</a><br>
</span>> <mailto:<a href="mailto:barton@bywatersolutions.com">barton@bywatersolutions.com</a>>>\\\"\" HEAD~$c^..; }; f"<br>
<span class="">><br>
> ... I'm not sure where that came from. It *may* have even come from an<br>
> earlier version on the wiki... I think that the issue is that git bz<br>
> attach will automatically obsolete patches that have the same subject<br>
> line, whereas appending "[SIGNED-OFF]" may break that. Take that with a<br>
> large grain of salt, test it yourself and maybe run it by the good QA folx.<br>
><br>
> --Barton<br>
><br>
><br>
><br>
> On Mon, Feb 1, 2016 at 11:37 AM, Owen Leonard <<a href="mailto:oleonard@myacpl.org">oleonard@myacpl.org</a><br>
</span><span class="">> <mailto:<a href="mailto:oleonard@myacpl.org">oleonard@myacpl.org</a>>> wrote:<br>
><br>
> The wiki has a good command for signing off multiple patches at once:<br>
><br>
> <a href="https://wiki.koha-community.org/wiki/Git_bz_configuration#Signing_off_2" rel="noreferrer" target="_blank">https://wiki.koha-community.org/wiki/Git_bz_configuration#Signing_off_2</a><br>
><br>
> I have a suggestion for an improvement: Prepend "[SIGNED-OFF]" to the<br>
> first line of each.<br>
><br>
> Is that possible?<br>
><br>
> -- Owen<br>
><br>
> --<br>
> Web Developer<br>
> Athens County Public Libraries<br>
> <a href="http://www.myacpl.org" rel="noreferrer" target="_blank">http://www.myacpl.org</a><br>
> _______________________________________________<br>
> Koha-devel mailing list<br>
> <a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a><br>
</span>> <mailto:<a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a>><br>
<div class="HOEnZb"><div class="h5">> <a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
> website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
> git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
> bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.org/</a><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> Koha-devel mailing list<br>
> <a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a><br>
> <a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
> website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
> git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
> bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.org/</a><br>
><br>
<br>
_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.org/</a><br>
</div></div></blockquote></div><br></div>