<div dir="ltr">Katrin I'm not quite sure what you mean. When I wrote we translate these files the same way we do other js files, I meant that we define the strings to be translated either in the script template file or in an include file and then only use the var storing the string in the js file. React is just Javascript and what we've been doing should work absolutely fine. I'll update my POC to be translatable when I get some time!<div><br></div><div>If this is not what you meant Katrin, please let me know!</div><div><br></div><div>Kyle</div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><a href="https://secure2.convio.net/cffh/site/Donation2?df_id=1395&FR_ID=4715&PROXY_ID=2706639&PROXY_TYPE=20&1395.donation=form1&s_src=CHORUS&s_subsrc=CHAADOEB" target="_blank"><img src="http://widgets.ch-or.us/badge/convio/cff/4715/2706639"></a><br></div><div><br></div><div><a href="http://www.kylehall.info" target="_blank">http://www.kylehall.info</a><br>ByWater Solutions ( <a href="http://bywatersolutions.com" target="_blank">http://bywatersolutions.com</a> )<br>Meadville Public Library ( <a href="http://www.meadvillelibrary.org" target="_blank">http://www.meadvillelibrary.org</a> )<br>Crawford County Federated Library System ( <a href="http://www.ccfls.org" target="_blank">http://www.ccfls.org</a> )<br></div></div></div></div></div></div>
<br><div class="gmail_quote">On Mon, Sep 19, 2016 at 11:51 PM, Katrin <span dir="ltr"><<a href="mailto:katrin.fischer.83@web.de" target="_blank">katrin.fischer.83@web.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class="">
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Also, how would this React POC go in terms of
translations?<br>
</blockquote>
<div><br>
</div>
<div>React is just Javascript, and is translated the same
way translate all our other js files.</div>
</div>
</div>
</div>
</blockquote></span>
We don't translate js files at the moment - which may be debatable.
One benefit at the moment of keeping the strings only in the
templates is that we don't copy the js files as we do with the
template files. I think this should be solvable, but it's something
to keep in mind.<div><div class="h5"><br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
David Cook<br>
Systems Librarian<br>
Prosentient Systems<br>
72/330 Wattle St<br>
Ultimo, NSW 2007<br>
Australia<br>
<br>
Office: 02 9212 0899<br>
Direct: 02 8005 0595<br>
<div>
<div><br>
<br>
> -----Original Message-----<br>
> From: <a href="mailto:koha-devel-bounces@lists.koha-community.org" target="_blank">koha-devel-bounces@lists.koha-<wbr>community.org</a>
[mailto:<a href="mailto:koha-devel-" target="_blank">koha-devel-</a><br>
> <a href="mailto:bounces@lists.koha-community.org" target="_blank">bounces@lists.koha-community.o<wbr>rg</a>]
On Behalf Of Owen Leonard<br>
> Sent: Monday, 19 September 2016 11:33 PM<br>
> To: Koha Devel <<a href="mailto:koha-devel@lists.koha-community.org" target="_blank">koha-devel@lists.koha-communi<wbr>ty.org</a>><br>
> Subject: Re: [Koha-devel] To React or not to
React<br>
><br>
> > Another thing is that you need nodejs to
compile it so is another<br>
> > thing to throw on the stack.<br>
><br>
> Isn't this the kind of dependency requirement
that killed my request to<br>
> introduce a front-end build tool like Grunt or
Gulp?<br>
><br>
> -- Owen<br>
><br>
> --<br>
> Web Developer<br>
> Athens County Public Libraries<br>
> <a href="http://www.myacpl.org" rel="noreferrer" target="_blank">http://www.myacpl.org</a><br>
> ______________________________<wbr>_________________<br>
> Koha-devel mailing list<br>
> <a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-communit<wbr>y.org</a><br>
> <a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.or<wbr>g/cgi-bin/mailman/listinfo/koh<wbr>a-devel</a><br>
> website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a>
git : <a href="http://git.koha-" rel="noreferrer" target="_blank">http://git.koha-</a><br>
> <a href="http://community.org/" rel="noreferrer" target="_blank">community.org/</a> bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.org<wbr>/</a><br>
<br>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>______________________________<wbr>_________________
Koha-devel mailing list
<a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-<wbr>community.org</a>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" target="_blank">http://lists.koha-community.<wbr>org/cgi-bin/mailman/listinfo/<wbr>koha-devel</a>
website : <a href="http://www.koha-community.org/" target="_blank">http://www.koha-community.org/</a>
git : <a href="http://git.koha-community.org/" target="_blank">http://git.koha-community.org/</a>
bugs : <a href="http://bugs.koha-community.org/" target="_blank">http://bugs.koha-community.<wbr>org/</a></pre>
</blockquote>
<br>
</div></div></div>
<br>______________________________<wbr>_________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-<wbr>community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.<wbr>org/cgi-bin/mailman/listinfo/<wbr>koha-devel</a><br>
website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.<wbr>org/</a><br></blockquote></div><br></div>