<div dir="ltr">Yes, I'll definitely need to make it translatable! I'll do that along with building out the backend to make it a complete fully functioning feature.<div><br></div><div>Kyle</div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><a href="https://secure2.convio.net/cffh/site/Donation2?df_id=1395&FR_ID=4715&PROXY_ID=2706639&PROXY_TYPE=20&1395.donation=form1&s_src=CHORUS&s_subsrc=CHAADOEB" target="_blank"><img src="http://widgets.ch-or.us/badge/convio/cff/4715/2706639"></a><br></div><div><br></div><div><a href="http://www.kylehall.info" target="_blank">http://www.kylehall.info</a><br>ByWater Solutions ( <a href="http://bywatersolutions.com" target="_blank">http://bywatersolutions.com</a> )<br>Meadville Public Library ( <a href="http://www.meadvillelibrary.org" target="_blank">http://www.meadvillelibrary.org</a> )<br>Crawford County Federated Library System ( <a href="http://www.ccfls.org" target="_blank">http://www.ccfls.org</a> )<br></div></div></div></div></div></div>
<br><div class="gmail_quote">On Tue, Sep 20, 2016 at 6:17 PM, David Cook <span dir="ltr"><<a href="mailto:dcook@prosentient.com.au" target="_blank">dcook@prosentient.com.au</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-AU" link="blue" vlink="purple"><div><p class="MsoNormal"><a name="m_-6607849161766306902__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">I think Katrin and I both are probably referring to this file: </span></a><a href="https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17297&attachment=55545" target="_blank"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">https://bugs.koha-community.<wbr>org/bugzilla3/page.cgi?id=<wbr>splinter.html&bug=17297&<wbr>attachment=55545</span></a><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">It embeds HTML and hardcoded strings in the .js file. It would be great to see a translateable version.<u></u><u></u></span></p><span class=""><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">David Cook<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Systems Librarian<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Prosentient Systems<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">72/330 Wattle St<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Ultimo, NSW 2007<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Australia<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Office: 02 9212 0899<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Direct: 02 8005 0595<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><u></u> <u></u></span></p></span><div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"><div><div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm"><p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <a href="mailto:koha-devel-bounces@lists.koha-community.org" target="_blank">koha-devel-bounces@lists.koha-<wbr>community.org</a> [mailto:<a href="mailto:koha-devel-bounces@lists.koha-community.org" target="_blank">koha-devel-bounces@<wbr>lists.koha-community.org</a>] <b>On Behalf Of </b>Kyle Hall<br><b>Sent:</b> Tuesday, 20 September 2016 11:22 PM<br><b>To:</b> Katrin <<a href="mailto:katrin.fischer.83@web.de" target="_blank">katrin.fischer.83@web.de</a>><br><b>Cc:</b> Koha Devel <<a href="mailto:koha-devel@lists.koha-community.org" target="_blank">koha-devel@lists.koha-<wbr>community.org</a>></span></p><div><div class="h5"><br><b>Subject:</b> Re: [Koha-devel] To React or not to React<u></u><u></u></div></div><p></p></div></div><div><div class="h5"><p class="MsoNormal"><u></u> <u></u></p><div><p class="MsoNormal">Katrin I'm not quite sure what you mean. When I wrote we translate these files the same way we do other js files, I meant that we define the strings to be translated either in the script template file or in an include file and then only use the var storing the string in the js file. React is just Javascript and what we've been doing should work absolutely fine. I'll update my POC to be translatable when I get some time!<u></u><u></u></p><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">If this is not what you meant Katrin, please let me know!<u></u><u></u></p></div><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">Kyle<u></u><u></u></p></div></div><div><p class="MsoNormal"><br clear="all"><u></u><u></u></p><div><div><div><div><div><div><p class="MsoNormal"><a href="https://secure2.convio.net/cffh/site/Donation2?df_id=1395&FR_ID=4715&PROXY_ID=2706639&PROXY_TYPE=20&1395.donation=form1&s_src=CHORUS&s_subsrc=CHAADOEB" target="_blank"><span style="text-decoration:none"><img border="0" src="http://widgets.ch-or.us/badge/convio/cff/4715/2706639"></span></a><u></u><u></u></p></div><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal"><a href="http://www.kylehall.info" target="_blank">http://www.kylehall.info</a><br>ByWater Solutions ( <a href="http://bywatersolutions.com" target="_blank">http://bywatersolutions.com</a> )<br>Meadville Public Library ( <a href="http://www.meadvillelibrary.org" target="_blank">http://www.meadvillelibrary.<wbr>org</a> )<br>Crawford County Federated Library System ( <a href="http://www.ccfls.org" target="_blank">http://www.ccfls.org</a> )<u></u><u></u></p></div></div></div></div></div></div><p class="MsoNormal"><u></u> <u></u></p><div><p class="MsoNormal">On Mon, Sep 19, 2016 at 11:51 PM, Katrin <<a href="mailto:katrin.fischer.83@web.de" target="_blank">katrin.fischer.83@web.de</a>> wrote:<u></u><u></u></p><blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"><div><blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"><div><div><div><blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"><p class="MsoNormal"><br>Also, how would this React POC go in terms of translations?<u></u><u></u></p></blockquote><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">React is just Javascript, and is translated the same way translate all our other js files.<u></u><u></u></p></div></div></div></div></blockquote><p class="MsoNormal">We don't translate js files at the moment - which may be debatable. One benefit at the moment of keeping the strings only in the templates is that we don't copy the js files as we do with the template files. I think this should be solvable, but it's something to keep in mind.<u></u><u></u></p><div><div><p class="MsoNormal"><br><br><u></u><u></u></p><blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"><div><div><div><blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"><p class="MsoNormal"><br>David Cook<br>Systems Librarian<br>Prosentient Systems<br>72/330 Wattle St<br>Ultimo, NSW 2007<br>Australia<br><br>Office: 02 9212 0899<br>Direct: 02 8005 0595<u></u><u></u></p><div><div><p class="MsoNormal" style="margin-bottom:12.0pt"><br><br>> -----Original Message-----<br>> From: <a href="mailto:koha-devel-bounces@lists.koha-community.org" target="_blank">koha-devel-bounces@lists.koha-<wbr>community.org</a> [mailto:<a href="mailto:koha-devel-" target="_blank">koha-devel-</a><br>> <a href="mailto:bounces@lists.koha-community.org" target="_blank">bounces@lists.koha-community.<wbr>org</a>] On Behalf Of Owen Leonard<br>> Sent: Monday, 19 September 2016 11:33 PM<br>> To: Koha Devel <<a href="mailto:koha-devel@lists.koha-community.org" target="_blank">koha-devel@lists.koha-<wbr>community.org</a>><br>> Subject: Re: [Koha-devel] To React or not to React<br>><br>> > Another thing is that you need nodejs to compile it so is another<br>> > thing to throw on the stack.<br>><br>> Isn't this the kind of dependency requirement that killed my request to<br>> introduce a front-end build tool like Grunt or Gulp?<br>><br>>   -- Owen<br>><br>> --<br>> Web Developer<br>> Athens County Public Libraries<br>> <a href="http://www.myacpl.org" target="_blank">http://www.myacpl.org</a><br>> ______________________________<wbr>_________________<br>> Koha-devel mailing list<br>> <a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-<wbr>community.org</a><br>> <a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" target="_blank">http://lists.koha-community.<wbr>org/cgi-bin/mailman/listinfo/<wbr>koha-devel</a><br>> website : <a href="http://www.koha-community.org/" target="_blank">http://www.koha-community.org/</a> git : <a href="http://git.koha-" target="_blank">http://git.koha-</a><br>> <a href="http://community.org/" target="_blank">community.org/</a> bugs : <a href="http://bugs.koha-community.org/" target="_blank">http://bugs.koha-community.<wbr>org/</a><br><br><u></u><u></u></p></div></div></blockquote></div><p class="MsoNormal"><u></u> <u></u></p></div></div><p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p><pre>______________________________<wbr>_________________<u></u><u></u></pre><pre>Koha-devel mailing list<u></u><u></u></pre><pre><a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-<wbr>community.org</a><u></u><u></u></pre><pre><a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" target="_blank">http://lists.koha-community.<wbr>org/cgi-bin/mailman/listinfo/<wbr>koha-devel</a><u></u><u></u></pre><pre>website : <a href="http://www.koha-community.org/" target="_blank">http://www.koha-community.org/</a><u></u><u></u></pre><pre>git : <a href="http://git.koha-community.org/" target="_blank">http://git.koha-community.org/</a><u></u><u></u></pre><pre>bugs : <a href="http://bugs.koha-community.org/" target="_blank">http://bugs.koha-community.<wbr>org/</a><u></u><u></u></pre></blockquote><p class="MsoNormal"><u></u> <u></u></p></div></div></div><p class="MsoNormal"><br>______________________________<wbr>_________________<br>Koha-devel mailing list<br><a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-<wbr>community.org</a><br><a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" target="_blank">http://lists.koha-community.<wbr>org/cgi-bin/mailman/listinfo/<wbr>koha-devel</a><br>website : <a href="http://www.koha-community.org/" target="_blank">http://www.koha-community.org/</a><br>git : <a href="http://git.koha-community.org/" target="_blank">http://git.koha-community.org/</a><br>bugs : <a href="http://bugs.koha-community.org/" target="_blank">http://bugs.koha-community.<wbr>org/</a><u></u><u></u></p></blockquote></div><p class="MsoNormal"><u></u> <u></u></p></div></div></div></div></div></div></blockquote></div><br></div>