<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Hi Jonathan,</p>
<p>I think placing a hold in the first place should depend on the
RoutingListAddReserves system preference that has been broken for
quite a while.</p>
<p>I think someone told me that it was possible in the past to have
a hold without an item? Not sure if that is true. But I would
suggest this behaviour:</p>
<p>- Use the system preference to determine, if a hold should be set<br>
- Only set item level holds. In order to pick the right item, this
would then depend on "creating items on receive" with your
subscription<code>.</code></p>
<p><code><font size="+1">There are some bugs files related to this:</font></code><br>
<br>
<a
href="https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894"><b>Bug 2894</b></a>
<span id="summary_container"> - <span
id="short_desc_nonedit_display">Routing list holds are broken</span></span></p>
<p><span id="summary_container"><span
id="short_desc_nonedit_display">And the following one, that
appeared to fix the problem in my testing, but is currently
sitting in Failed QA:</span></span><br>
<br>
<a
href="https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957"><b>Bug 7957</b></a>
<span id="summary_container"> - <span
id="short_desc_nonedit_display">Routing lists: manage several
routing list for each subscription, and export them as CSV</span></span></p>
<p><span id="summary_container"><span
id="short_desc_nonedit_display">Hope this helps,</span></span></p>
<p><span id="summary_container"><span
id="short_desc_nonedit_display">Katrin<br>
</span></span></p>
<p><span id="summary_container"><span
id="short_desc_nonedit_display"><br>
</span></span></p>
<div class="moz-cite-prefix">On 13.03.2017 17:25, Jonathan Druart
wrote:<br>
</div>
<blockquote
cite="mid:CAJzKNY7D=JzytR7194KZdRCq=BY4zt-L3VjceijJtp=S6G1mZA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>Hi devs,<br>
<br>
</div>
I found an obvious bug in serials/<a
moz-do-not-send="true"
href="http://routing-preview.pl">routing-preview.pl</a>.<br>
</div>
If the script is called with ok=1 (hum...
yes...), the script will add or modify a hold
placed on the bibliographic records existing
in the routing list.<br>
</div>
So from /serials/<a moz-do-not-send="true"
href="http://serials-collection.pl?subscriptionid=1">serials-collection.pl?subscriptionid=1</a>,
click on "Print list" you get a pop-up with a
print and close button.<br>
</div>
When the pop-up is generated, we already have the
ok=1 and the go through:<br>
66: my ($count2,@bibitems) =
GetBiblioItemByBiblioNumber($biblio);<br>
</div>
Then later:<br>
96
AddReserve($branch,$routing->{borrowernumber},$biblio,\@bibitems,$routing->{ranking},
undef, undef, $notes,$title);<br>
<br>
</div>
The problem is that GetBiblioItemByBiblioNumber will
always return only 1 value (for obvious reasons) and
@bibitems will always be empty => reserve is placed
at bib level<br>
<br>
</div>
The thing is that this bug exists for ages (at least
2006, maybe always).<br>
</div>
What is the expected behaviour?<br>
<br>
</div>
No need to tell you that I was going to kick
GetBiblioItemByBiblioNumber when I found that bug.<br>
<br>
</div>
Cheers,<br>
</div>
Jonathan<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Koha-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a>
<a class="moz-txt-link-freetext" href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a>
website : <a class="moz-txt-link-freetext" href="http://www.koha-community.org/">http://www.koha-community.org/</a>
git : <a class="moz-txt-link-freetext" href="http://git.koha-community.org/">http://git.koha-community.org/</a>
bugs : <a class="moz-txt-link-freetext" href="http://bugs.koha-community.org/">http://bugs.koha-community.org/</a></pre>
</blockquote>
<br>
</body>
</html>