<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p>Added bug 18970 for the test each new issue id - approach.<br>
</p>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr tabindex="-1" style="width: 98%; display: inline-block;">
<div id="divRplyFwdMsg" dir="ltr"><font color="#000000" face="Calibri, sans-serif" style="font-size: 11pt;"><b>Van:</b> Marcel de Rooy<br>
<b>Verzonden:</b> vrijdag 21 juli 2017 07:58<br>
<b>Aan:</b> koha-devel@lists.koha-community.org<br>
<b>Onderwerp:</b> Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost</font>
<div> </div>
</div>
<div>
<div id="divtagdefaultwrapper" style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif; font-size: 12pt;" dir="ltr">
<p style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size: 12pt;" dir="ltr">
Not sure if 18966 is the way to go, "halting the system" until we fixed the autoincrement.<br>
</p>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size: 12pt;" dir="ltr">
The solution of merging the tables, as David refers to, is the ideal one, but it seems too big to implement right now, as we need to fix stable branches right now.</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size: 12pt;" dir="ltr">
The renumbering fix depended on locking. The locks were removed quickly, but did we search further on that road? Why wouldn't it be possible to lock a table somehow?</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size: 12pt;" dir="ltr">
If we completely revert the renumbering fix, I think we should test at each insert if the new issue id is greater than the max in old_issues. If not, fix it in that process. This would prevent new clashes. And when we move to old_issues, take some temporary
data loss for granted (if the id's clash, choose for the newest one or the one with a fine or so).<br>
</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size: 12pt;" dir="ltr">
<br>
</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size: 12pt;" dir="ltr">
Marcel</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size: 12pt;" dir="ltr">
<br>
</div>
<div style="color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size: 12pt;" dir="ltr">
<hr tabindex="-1" style="width: 98%; display: inline-block;">
<div id="divRplyFwdMsg" dir="ltr"><font color="#000000" face="Calibri, sans-serif" style="font-size: 11pt;"><b>Van:</b> koha-devel-bounces@lists.koha-community.org <koha-devel-bounces@lists.koha-community.org> namens David Cook <dcook@prosentient.com.au><br>
<b>Verzonden:</b> vrijdag 21 juli 2017 05:57<br>
<b>Aan:</b> 'Jonathan Druart'; koha-devel@lists.koha-community.org<br>
<b>Onderwerp:</b> Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost</font>
<div> </div>
</div>
<div>
<div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<a name="_MailEndCompose"><span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;">Jonathan, have you thought anymore about merging the deleted* tables back in with the active tables? This would have the benefit of fixing problems
with things like “Checkout history” where issues containing deleted borrowers or deleted items have these details nullified and thus disappear from the system.
</span></a></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;"> </span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;">I suppose we’d have to make sure the deleted flag is indexed, and it would mean changing many SQL reports not to include deleted records… so that might be easier said
than done.</span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;"> </span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;">Alternatively, maybe we need more robust logical (ie code) ways of managing the relationships between active and inactive (ie deleted) data? I mean… what’s the point
of keeping a history of data if we can’t use it?</span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;"> </span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;">David Cook</span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;">Systems Librarian</span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;">Prosentient Systems</span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;">72/330 Wattle St</span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;">Ultimo, NSW 2007</span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;">Australia</span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;"> </span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;">Office: 02 9212 0899</span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;">Direct: 02 8005 0595</span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<span style="color: rgb(31, 73, 125); font-family: "Calibri",sans-serif; font-size: 11pt;"> </span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
<b><span lang="EN-US" style="font-family: "Calibri",sans-serif; font-size: 11pt;">From:</span></b><span lang="EN-US" style="font-family: "Calibri",sans-serif; font-size: 11pt;"> koha-devel-bounces@lists.koha-community.org [mailto:koha-devel-bounces@lists.koha-community.org]
<b>On Behalf Of </b>Jonathan Druart<br>
<b>Sent:</b> Friday, 21 July 2017 3:23 AM<br>
<b>To:</b> koha-devel@lists.koha-community.org<br>
<b>Subject:</b> Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost</span></p>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
</p>
<div>
<div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
And see bug 18966 for a third (last!?) round. I tried to resume in the description of the bug what has been done and what I propose to move forward.<br>
BE INVOLVED!</p>
</div>
<div>
<div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
</p>
<div>
<div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
On Wed, 12 Jul 2017 at 15:11 Jonathan Druart <<a style="color: blue; text-decoration: underline;" href="mailto:jonathan.druart@bugs.koha-community.org">jonathan.druart@bugs.koha-community.org</a>> wrote:</p>
</div>
<blockquote style="border-width: medium medium medium 1pt; border-style: none none none solid; border-color: currentColor currentColor currentColor rgb(204, 204, 204); padding: 0cm 0cm 0cm 6pt; margin-right: 0cm; margin-left: 4.8pt;">
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
Hi devs,</p>
</div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
</p>
</div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
Please review and test <a style="color: blue; text-decoration: underline;" href="https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix" target="_blank">
https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix</a></p>
</div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
I have added a ref from the Koha on Debian wiki page <a style="color: blue; text-decoration: underline;" href="https://wiki.koha-community.org/wiki/Koha_on_Debian#Further_Configuration" target="_blank">
https://wiki.koha-community.org/wiki/Koha_on_Debian#Further_Configuration</a></p>
</div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
It sounds like I should add it somewhere more visible, but do not find where, any ideas?</p>
</div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
See also bug 18931 where I would like to add a warning on the about page if data are corrupted.</p>
</div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
Please review quickly, that way we can share the tips on the general mailing list.</p>
</div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
Cheers,</p>
</div>
<p style="margin: 0cm 0cm 0pt; font-family: "Times New Roman",serif; font-size: 12pt;">
Jonathan</p>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>