<div dir="ltr">From the "Summary" section of the bug reporting guidelines:<div><br></div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><div><div>Also keep in mind that the summary is what people will see when bugs are listed in the search -- it's a good place to put keywords like which page the error occurs on, or specifics about where a problem occurs. The summary<br></div><div><br></div><div>Times are formatted incorrectly in slips ( AM PM ) due to double processing</div></div><div><div><br></div></div><div><div>accurately describes the problem, but someone looking for the bug later will be likely to search for</div></div><div><div><br></div></div><div><div>date_due ISSUESLIP,</div></div><div><div><br></div></div><div><div>Time on <<issues.date_due>> incorrectly shows as 'AM' on ISSUESLIP, ISSUEQSLIP</div></div><div><div><br></div></div><div><div>Is easier to search for.</div></div></blockquote><div><br></div>^^ This, this, a thousand times this. As a bug reporter, I'm a bit ashamed at the times that I haven't done this, as someone who has spent a significant chunk of the last four years of his life searching bugzilla, please for the love of $DIETY, do this... Also, keep in mind that the page where the bug is triggered (e.g. circ/<a href="http://returns.pl">returns.pl</a> or catalogue/<a href="http://search.pl">search.pl</a>) is a likely keyword.<div><br></div><div>Thank you!<br><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 14, 2017 at 4:07 PM, Tomas Cohen Arazi <span dir="ltr"><<a href="mailto:tomascohen@gmail.com" target="_blank">tomascohen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+1<br></div><div><div class="h5"><br><div class="gmail_quote"><div dir="ltr">El jue., 14 sept. 2017 a las 17:01, Jesse (<<a href="mailto:pianohacker@gmail.com" target="_blank">pianohacker@gmail.com</a>>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Strong +1.<br></div><div class="gmail_extra"></div><div class="gmail_extra"><br><div class="gmail_quote">2017-08-31 8:10 GMT-06:00 Jonathan Druart <span dir="ltr"><<a href="mailto:jonathan.druart@bugs.koha-community.org" target="_blank">jonathan.druart@bugs.koha-<wbr>community.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid2" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">Hi devs,</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid3" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><br></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid4" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">I would like to do a little reminder about the bug report titles and commit messages.</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid5" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><br></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid6" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">For bugs:</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid7" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">The bug report title must shortly tell what the *bug* is, whereas the commit messages must tell what the *fix* does. Sometimes they are not related at all.</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid8" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">For instance:</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid9" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">- bug report titles: "Feature X is not working correctly when Y is enabled", "Click on button 'Save' does not save the record", "Saving stuff on screen X does not work", "This script generates error logs", "Mystake is misspelled in this script", "Behaviour X no longer work as expected" etc.</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid10" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">- commit messages: "Fix Feature X when Y is enabled", "Make sure behaviour is correct when button is clicked", "Remove warnings from this script", "Correct spelling of mistake in this script", "Fix regression on behaviour X" etc.</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid11" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><br></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid12" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">For enhancements / new feature:</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid13" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">We could have the same title and commit messages in some cases.</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid14" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">- bug report titles: "Add new awesome feature", "Add the ability to do that", "Code is duplicated in method Koha::Stuff->method"</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid15" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">- commit messages: "Add new awesome feature", "Add the ability to do that", "Remove code duplication in method Koha::Stuff->method"</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid16" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><br></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid83" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-ace-line"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-author-a-fz75z5sz89z9dz68zp3z72zz65z9z84zz88zz83z">Note that "Address comment #42" is a terrible commit message.</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid84" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-ace-line"><br></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid18" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">Then, I would like to standardize the commit messages a bit.</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid19" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">We have "Bug 12345 - ", "Bug 12345: ", "Bug 12345"</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid43" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-ace-line"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">and "[follow-up]", "(follow-up)", "[QA Followup]", etc.</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid22" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><br></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid23" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">I would suggest:</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid24" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">  "Bug 12345: you commit message"</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid25" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">And reject any commit messages with only "follow-up" (or whatever how it is written), but accept</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid26" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">  "Bug 12345: (follow-up) same commit message as before"</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid27" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">If you forgot something, even if</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid28" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">  "Bug 12345: (follow-up) This was missing"</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid29" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><br></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid30" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">And QA follow-ups (added by QA team member):</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid31" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">  "Bug 12345: "(QA follow-up) Add/remove this stuff"</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid32" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><br></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid33" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">I am going to suggest these change during the next dev meetings.</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid34" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">If accepted I will change the bug report titles and commit messages before the push during few weeks, then ask authors to do it themselves (patches from new contributors will not be rejected for that reason).</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid35" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><br></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid36" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">You should also read or re-read:</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid37" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-url"><a href="https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines" target="_blank">https://wiki.koha-community.<wbr>org/wiki/Bug_Reporting_<wbr>Guidelines</a></span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid38" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-url"><a href="https://wiki.koha-community.org/wiki/Commit_messages" target="_blank">https://wiki.koha-community.<wbr>org/wiki/Commit_messages</a></span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid39" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><br></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid40" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">Cheers,</span></div><div id="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-magicdomid41" class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-"><span class="m_5084774129689291193m_-1404561553541518308m_8220790222355133920inbox-inbox-">Jonathan</span></div></div>
<br>______________________________<wbr>_________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-<wbr>community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.<wbr>org/cgi-bin/mailman/listinfo/<wbr>koha-devel</a><br>
website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.<wbr>org/</a><br></blockquote></div><br><br clear="all"><br></div><div class="gmail_extra">-- <br><div class="m_5084774129689291193m_-1404561553541518308gmail_signature" data-smartmail="gmail_signature">Jesse Weaver</div>
</div>
______________________________<wbr>_________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-<wbr>community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.<wbr>org/cgi-bin/mailman/listinfo/<wbr>koha-devel</a><br>
website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.<wbr>org/</a></blockquote></div><div dir="ltr">-- <br></div></div></div><div class="m_5084774129689291193gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div style="color:rgb(117,117,117);font-family:"helvetica neue",helvetica,arial,sans-serif;font-size:12.8px">Tomás Cohen Arazi</div><div style="color:rgb(117,117,117);font-family:"helvetica neue",helvetica,arial,sans-serif;font-size:12.8px">Theke Solutions (<a href="http://theke.io/" target="_blank">https://theke.io</a>)<br>✆ <a href="tel:+54%209%20351%20351-3384" value="+5493513513384" target="_blank">+54 9351 3513384</a><br>GPG: B2F3C15F</div></div></div>
<br>______________________________<wbr>_________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-<wbr>community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.<wbr>org/cgi-bin/mailman/listinfo/<wbr>koha-devel</a><br>
website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.<wbr>org/</a><br></blockquote></div><br></div>