<div dir="ltr">Tomas,<div><br></div><div>Thank you for putting the REST api RFCs page together; having a series of pages that document the routes was sorely needed.</div><div><br></div><div>One question -- the RFCs lists the route for borrowers as '/patrons'. However <a href="https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.2:_Resource_names" target="_blank">https://wiki.koha-<wbr>community.org/wiki/Coding_<wbr>Guidelines_-_API#SWAGGER1.2:_<wbr>Resource_names</a> suggests that we should use /users instead of /borrowers, /patrons, or /members.</div><div><br></div><div>Should we change the RFC to follow the Coding Guidelines, or change the guidelines?</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 15, 2017 at 5:15 AM, Tomas Cohen Arazi <span dir="ltr"><<a href="mailto:tomascohen@gmail.com" target="_blank">tomascohen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Andreas, it will be included! That list is only what I managed to write after the dev meeting, and is certainly incomplete.</p><div class="HOEnZb"><div class="h5">
<br><div class="gmail_quote"><div dir="ltr">El vie., 15 de dic. de 2017 5:44 a. m., Andreas Hedström Mace <<a href="mailto:andreas.hedstrom.mace@su.se" target="_blank">andreas.hedstrom.mace@su.se</a>> escribió:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="white" lang="SV" link="blue" vlink="purple">
<div class="m_7252067046372192640m_-237705568716992395WordSection1">
<p class="MsoNormal"><span>Hi!<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">This sounds like a really good initiative Tomás, getting the major endpoints listed and structured so that the REST API work can proceed!<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">However, I’m surprised that the endpoint for accountlines is not listed in the RFC. Some reasons why I think that this should be included:<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">We at Stockholm University Library is already using (a previous) version of this endpoint in production<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">You mentioned that you included other endpoints BibLibre is working on: we sponsored BibLibre to build this endpoint a while back<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">But above all I believe other libraries will also be interested in using this endpoint! (At the hackfest in Lund recently, there was interest in using this endpoint from Oslo Public
Library etc.)<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Andreas Hedström Mace<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">Från: </span></b><span style="font-size:12.0pt;color:black"><<a href="mailto:koha-devel-bounces@lists.koha-community.org" target="_blank">koha-devel-bounces@lists.<wbr>koha-community.org</a>> på uppdrag av Tomas Cohen Arazi <<a href="mailto:tomascohen@gmail.com" target="_blank">tomascohen@gmail.com</a>><br>
<b>Datum: </b>torsdag 14 december 2017 16:28<br>
<b>Till: </b>koha-devel <<a href="mailto:koha-devel@lists.koha-community.org" target="_blank">koha-devel@lists.koha-<wbr>community.org</a>><br>
<b>Ämne: </b>[Koha-devel] REST api RFCs<u></u><u></u></span></p>
</div></div></div><div bgcolor="white" lang="SV" link="blue" vlink="purple"><div class="m_7252067046372192640m_-237705568716992395WordSection1">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Hi everyone. Following yesterday's dev meeting (I'm sorry I couldn't attend) it was clear there should be some votes on the changes that we belive need to be made.
<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">In order to organize the documentation on this decision making process, and have something more precise to vote on, I've put together a front wiki page:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><a href="https://wiki.koha-community.org/wiki/REST_api_RFCs" target="_blank">https://wiki.koha-community.<wbr>org/wiki/REST_api_RFCs</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">in which all endpoint-specific RFCs can be found. I have added the endpoints I've been, am and will be working on. Also endpoints I know Biblibre is working on.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">As the discussion was about the patrons endpoint specifically, I started by creating an RFC for it:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><a href="https://wiki.koha-community.org/wiki/Patrons_endpoint_RFC" target="_blank">https://wiki.koha-community.<wbr>org/wiki/Patrons_endpoint_RFC</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">It is organized in two sections: actions and paths, and the object definition. The idea is that you can add your own column (put your name on it) with your personal proposal. Discussions can happen in other places like IRC or koha-devel.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Please add your comments on each issue you think it is worth, and please contact me if you have any doubts or want to discuss specific stuffs.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I will be spending the next days polishing this RFC and moving into the rest of them in the same way.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Before adding new endpoints to that list, I would suggest we have a small conversation here in koha-devel to avoid polluting the front page with several variations of the same endpoints. This is just a suggestion, though.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks for your interest and feedback!<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Cheers<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
<div>
<p class="MsoNormal">-- <u></u><u></u></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:"Helvetica Neue",sans-serif;color:#757575">Tomás Cohen Arazi<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt;font-family:"Helvetica Neue",sans-serif;color:#757575">Theke Solutions (<a href="http://theke.io/" target="_blank">https://theke.io</a>)<br>
</span><span style="font-size:9.5pt;font-family:"MS Mincho",serif;color:#757575">✆</span><span style="font-size:9.5pt;font-family:"Helvetica Neue",sans-serif;color:#757575"> <a href="tel:+54%209%20351%20351-3384" value="+5493513513384" target="_blank">+54 9351 3513384</a><br>
GPG: B2F3C15F<u></u><u></u></span></p>
</div>
</div>
</div>
</div></div></blockquote></div><div dir="ltr">-- <br></div><div class="m_7252067046372192640gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div style="color:rgb(117,117,117);font-family:"helvetica neue",helvetica,arial,sans-serif;font-size:12.8px">Tomás Cohen Arazi</div><div style="color:rgb(117,117,117);font-family:"helvetica neue",helvetica,arial,sans-serif;font-size:12.8px">Theke Solutions (<a href="http://theke.io/" target="_blank">https://theke.io</a>)<br>✆ <a href="tel:+54%209%20351%20351-3384" value="+5493513513384" target="_blank">+54 9351 3513384</a><br>GPG: B2F3C15F</div></div></div>
</div></div><br>______________________________<wbr>_________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-<wbr>community.org</a><br>
<a href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">http://lists.koha-community.<wbr>org/cgi-bin/mailman/listinfo/<wbr>koha-devel</a><br>
website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.<wbr>org/</a><br></blockquote></div><br></div>