<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>Great many thanks for the patch, Jonathan!<br>
    </p>
    <div class="moz-signature">
      <style type="text/css">
.moz-signature {
 color: #FFFFFF;
}
.sig_inlibro {
 padding-top : 2px;
 color: #888888;
 font-family : "Trebuchet MS", verdana;
 font-size: 90%;
}
.sig_content {
 border-top: 2px solid #DDDDDD;
 border-bottom: 2px solid #BFD13D;
 background-color : #F6F6F6;
 padding-left:10px;
}
.sig_inlibro a:visited, .sig_inlibro a:hover, .sig_inlibro a:link {
 text-decoration: none;
 color: #005B85;
}
.nom {
 color: #005B85;
 font-weight : bold;
}
.inlibro, .in {
 color: #BFD13D;
}
.libro {
 color: #005B85;
}
.in, .libro {
 font-size : 120%;
}
.desc {
    margin-bottom: 0;
    padding-bottom: 5px;
}
.small {
 font-size: 80%;
}
.tagline {
 color : #00BCE4;
}
.sig_footer {
 padding-left : 10px;
 background-color : #EEEFEA;
}
</style>
      <div class="sig_inlibro">
        <div class="sig_content"> <span class="nom">Philippe Blouin,</span><br>
          <span class="tagline small">Responsable du développement
            informatique</span><br>
          <p class="desc small">
            <!--
   Tél.  : (833) 465-4276, poste 230<br/>
--> Tél.  : (888) 604-2627<br>
            <a href="mailto:philippe.blouin@inLibro.com">philippe.blouin@inLibro.com</a>
          </p>
        </div>
        <div class="sig_footer"> <span class="in">in</span><span
            class="libro">Libro</span> <span class="tagline small">|
            pour esprit libre |</span> <a class="small"
            href="http://www.inLibro.com">www.inLibro.com</a> </div>
      </div>
    </div>
    <div class="moz-cite-prefix">On 06/12/2018 12:11 PM, Jonathan Druart
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAJzKNY5198_fxDad23iBvxEcw3pbFovA5gLWZL8Zaou_Nv0fqg@mail.gmail.com">
      <div dir="ltr">
        <div> I opened it, see bug 20922.</div>
        <div>I am going to provide a patch very soon.<br>
        </div>
        <br>
        <div class="gmail_quote">
          <div dir="ltr">On Tue, 12 Jun 2018 at 12:55 Jonathan Druart
            <<a href="mailto:jonathan.druart@bugs.koha-community.org"
              target="_blank" moz-do-not-send="true">jonathan.druart@bugs.koha-community.org</a>>
            wrote:<br>
          </div>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div dir="ltr">
              <div>It's a bug, please open a new bug report.</div>
              <div>Indeed we should not use Koha::Object packages during
                the update database process, they are using the
                DBIx::Class schema. It's in the coding guidelines
                already ;)<br>
              </div>
              <div><br>
              </div>
            </div>
            <br>
            <div class="gmail_quote">
              <div dir="ltr">On Tue, 12 Jun 2018 at 12:41 Philippe
                Blouin <<a href="mailto:philippe.blouin@inlibro.com"
                  target="_blank" moz-do-not-send="true">philippe.blouin@inlibro.com</a>>
                wrote:<br>
              </div>
              <blockquote class="gmail_quote" style="margin:0 0 0
                .8ex;border-left:1px #ccc solid;padding-left:1ex">
                <div text="#000000" bgcolor="#FFFFFF">
                  <p>Holà!</p>
                  <p>Currently migrating some 3.0 DB to 18.05.  A single
                    hiccup with message_transport, no biggie.  Until...<br>
                  </p>
                  <p>16.06.00.042</p>
                  <p><tt>Upgrade to 16.06.00.041 done (Bug 14629 - Add
                      aggressive ISSN matching feature equivalent to the
                      aggressive ISBN matcher)</tt><tt><br>
                    </tt><tt>DBD::mysql::st execute failed: Unknown
                      column 'me.p_sep_by_space' in 'field list' [for
                      Statement "SELECT `me`.`currency`, `me`.`symbol`,
                      `me`.`isocode`, `me`.`timestamp`, `me`.`rate`,
                      `me`.`active`, `me`.`archived`,
                      `me`.`p_sep_by_space` FROM `currency` `me` WHERE (
                      `active` = ? )" with ParamValues: 0=1] at
                      /usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm
                      line 1836.</tt><tt><br>
                    </tt><tt>DBIx::Class::Storage::DBI::_dbh_execute():
                      Unknown column 'me.p_sep_by_space' in 'field list'
                      at
                      /inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm
                      line 209</tt><tt><br>
                    </tt></p>
                  <p>Basically, the update code uses
                    Koha::Number::Price, which in full modern object
                    mode goes for its newly added <b>p_sep_by_space</b>
                    <u>in the 18.05 code</u>.  But the DB doesn't have
                    it yet (it comes with 17.12.00.022).</p>
                  <p>Big crash big time.  The process stops.<br>
                  </p>
                  <p>Any workaround? (didn't see anything in the list,
                    nor bugzilla, did I miss it?).</p>
                  <p>Thanks,</p>
                  <p>PS this is bound to happen whenever Koha objects
                    are used in <a href="http://updatedatabase.pl"
                      target="_blank" moz-do-not-send="true">updatedatabase.pl</a>.<br>
                  </p>
                  <div
class="m_2864350242480776027m_2179064934935041194m_-67306688317570472moz-signature">--
                    <br>
                    <div
class="m_2864350242480776027m_2179064934935041194m_-67306688317570472sig_inlibro">
                      <div
class="m_2864350242480776027m_2179064934935041194m_-67306688317570472sig_content">
                        <span
class="m_2864350242480776027m_2179064934935041194m_-67306688317570472nom">Philippe
                          Blouin,</span><br>
                        <span
class="m_2864350242480776027m_2179064934935041194m_-67306688317570472tagline
m_2864350242480776027m_2179064934935041194m_-67306688317570472small">Responsable
                          du développement informatique</span><br>
                        <p
class="m_2864350242480776027m_2179064934935041194m_-67306688317570472desc
m_2864350242480776027m_2179064934935041194m_-67306688317570472small">
                          Tél.  : (888) 604-2627<br>
                          <a href="mailto:philippe.blouin@inLibro.com"
                            target="_blank" moz-do-not-send="true">philippe.blouin@inLibro.com</a>
                        </p>
                      </div>
                      <div
class="m_2864350242480776027m_2179064934935041194m_-67306688317570472sig_footer">
                        <span
                          class="m_2864350242480776027m_2179064934935041194m_-67306688317570472in">in</span><span
class="m_2864350242480776027m_2179064934935041194m_-67306688317570472libro">Libro</span>
                        <span
class="m_2864350242480776027m_2179064934935041194m_-67306688317570472tagline
m_2864350242480776027m_2179064934935041194m_-67306688317570472small">|
                          pour esprit libre |</span> <a
class="m_2864350242480776027m_2179064934935041194m_-67306688317570472small"
                          href="http://www.inLibro.com" target="_blank"
                          moz-do-not-send="true">www.inLibro.com</a> </div>
                    </div>
                  </div>
                </div>
                _______________________________________________<br>
                Koha-devel mailing list<br>
                <a href="mailto:Koha-devel@lists.koha-community.org"
                  target="_blank" moz-do-not-send="true">Koha-devel@lists.koha-community.org</a><br>
                <a
href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel"
                  rel="noreferrer" target="_blank"
                  moz-do-not-send="true">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
                website : <a href="http://www.koha-community.org/"
                  rel="noreferrer" target="_blank"
                  moz-do-not-send="true">http://www.koha-community.org/</a><br>
                git : <a href="http://git.koha-community.org/"
                  rel="noreferrer" target="_blank"
                  moz-do-not-send="true">http://git.koha-community.org/</a><br>
                bugs : <a href="http://bugs.koha-community.org/"
                  rel="noreferrer" target="_blank"
                  moz-do-not-send="true">http://bugs.koha-community.org/</a></blockquote>
            </div>
          </blockquote>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>