<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>Hi Andreas,</p>
    <p>makes sense for me. Why not mark them as visible in the OPAC?</p>
    <p>Katrin<br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 20.06.2018 09:51, Andreas Roussos
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAK0RUrtp6SYswHZG38X5PvGgHst91JqedpthjJcXX_46_oDOSg@mail.gmail.com">
      <div dir="ltr">
        <div>Hi Katrin,</div>
        <div><br>
        </div>
        <div>Thank you for your reply.</div>
        <div><br>
        </div>
        <div>The issue we are facing is this: unless a subfield (e.g.
          UNIMARC 453$0, Bibliographic Record Identifier) is marked as
          visible in the OPAC, the links (URLs) using that subfield will
          be broken in the ISBD view.</div>
        <div>And this happens (according to the code snippets in my
          original message) only when GetISBDView is called with
          'template' = 'opac', not 'intranet' (i.e. only in OPAC ISBD
          view, not in Staff ISBD view).</div>
        <div><br>
        </div>
        <div>I hope this makes more sense.</div>
        <div><br>
        </div>
        <div>Regards,</div>
        <div>Andreas<br>
        </div>
      </div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On 18 June 2018 at 23:22, Katrin
          Fischer <span dir="ltr"><<a
              href="mailto:katrin.fischer.83@web.de" target="_blank"
              moz-do-not-send="true">katrin.fischer.83@web.de</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div text="#000000" bgcolor="#FFFFFF"> Hi Andreas,<br>
              <br>
              I might be misunderstanding your question, but the OPAC
              visibility setting should take effect on all pages and
              views in the OPAC now. It didn't use to, which was
              considered a long standing bug and finally fixed. Now it's
              possible to hide fields from OPAC that can still appear in
              staff in a reliable way. The preconfigured visibility
              settings in the frameworks might not always be ideal - if
              that's what you mean, we could work on improving them.<br>
              <br>
              Hope that helps,<br>
              <br>
              Katrin
              <div>
                <div class="h5"><br>
                  <br>
                  <div class="m_4778401096280995557moz-cite-prefix">On
                    07.06.2018 09:21, Andreas Roussos wrote:<br>
                  </div>
                </div>
              </div>
              <blockquote type="cite">
                <div>
                  <div class="h5">
                    <div dir="ltr">Dear Developers,<br>
                      <br>
                      If you:<br>
                      <br>
                      1) edit the ISBD and OPACISBD system preferences
                      so that they contain the following code:<br>
                      <br>
                      #453| - translated as: |<a
                      href="/cgi-bin/koha/catalogue/<a
                        href="http://detail.pl?biblionumber=%7B4530%7D"
                        target="_blank" moz-do-not-send="true"><wbr>detail.pl?biblionumber={4530}</a>"<wbr>>{453t}</a>
                      {(453d)}|<br>
                      #454| - translation of: |<a
                      href="/cgi-bin/koha/catalogue/<a
                        href="http://detail.pl?biblionumber=%7B4540%7D"
                        target="_blank" moz-do-not-send="true"><wbr>detail.pl?biblionumber={4540}</a>"<wbr>>{454t}</a>
                      {(454d)}|<br>
                      <br>
                      2) set the visibility of (UNIMARC) fields 453$0
                      and 454$0 to 'hidden' in the OPAC<br>
                      <br>
                      ...then the generated links will work fine in the
                      Staff client but will be broken in the OPAC (i.e.
                      the URL will not include the biblionumber
                      contained in subfield 0 of fields 453/454).<br>
                      <br>
                      I've tracked this down to ISBDdetail.pl and
                      opac-ISBDdetail.pl calling the GetISBDView
                      subroutine, which (for some reason) excludes
                      subfields that are hidden in the OPAC:<br>
                      <br>
                      <a
href="https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L773-L776"
                        target="_blank" moz-do-not-send="true">https://github.com/Koha-<wbr>Community/Koha/blob/master/C4/<wbr>Biblio.pm#L773-L776</a><br>
                      <a
href="https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L812-L815"
                        target="_blank" moz-do-not-send="true">https://github.com/Koha-<wbr>Community/Koha/blob/master/C4/<wbr>Biblio.pm#L812-L815</a><br>
                      <br>
                      What is the reasoning behind this?<br>
                      In other words, why is _OPAC_ subfield visibility
                      taken into account when displaying the OPAC ISBD
                      view (whereas visibility in Staff is not
                      considered)?<br>
                      <br>
                      If anything, it is more likely to have subfield 0
                      hidden in OPAC, while visible in Staff, so one
                      would expect the opposite logic.<br>
                      <br>
                      Thanks in advance for your time.<br>
                      <br>
                      Kind regards,<br>
                      Andreas Roussos<br>
                    </div>
                    <br>
                    <fieldset
                      class="m_4778401096280995557mimeAttachmentHeader"></fieldset>
                    <br>
                  </div>
                </div>
                <pre>______________________________<wbr>_________________
Koha-devel mailing list
<a class="m_4778401096280995557moz-txt-link-abbreviated" href="mailto:Koha-devel@lists.koha-community.org" target="_blank" moz-do-not-send="true">Koha-devel@lists.koha-<wbr>community.org</a>
<a class="m_4778401096280995557moz-txt-link-freetext" href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" target="_blank" moz-do-not-send="true">http://lists.koha-community.<wbr>org/cgi-bin/mailman/listinfo/<wbr>koha-devel</a>
website : <a class="m_4778401096280995557moz-txt-link-freetext" href="http://www.koha-community.org/" target="_blank" moz-do-not-send="true">http://www.koha-community.org/</a>
git : <a class="m_4778401096280995557moz-txt-link-freetext" href="http://git.koha-community.org/" target="_blank" moz-do-not-send="true">http://git.koha-community.org/</a>
bugs : <a class="m_4778401096280995557moz-txt-link-freetext" href="http://bugs.koha-community.org/" target="_blank" moz-do-not-send="true">http://bugs.koha-community.<wbr>org/</a></pre>
              </blockquote>
              <br>
            </div>
            <br>
            ______________________________<wbr>_________________<br>
            Koha-devel mailing list<br>
            <a href="mailto:Koha-devel@lists.koha-community.org"
              moz-do-not-send="true">Koha-devel@lists.koha-<wbr>community.org</a><br>
            <a
href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel"
              rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.koha-community.<wbr>org/cgi-bin/mailman/listinfo/<wbr>koha-devel</a><br>
            website : <a href="http://www.koha-community.org/"
              rel="noreferrer" target="_blank" moz-do-not-send="true">http://www.koha-community.org/</a><br>
            git : <a href="http://git.koha-community.org/"
              rel="noreferrer" target="_blank" moz-do-not-send="true">http://git.koha-community.org/</a><br>
            bugs : <a href="http://bugs.koha-community.org/"
              rel="noreferrer" target="_blank" moz-do-not-send="true">http://bugs.koha-community.<wbr>org/</a><br>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
  </body>
</html>