<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name="Generator" content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang="EN-AU" link="#0563C1" vlink="#954F72">Yes Bug 12345: not -<br>
<br>
And 50 chars is just the first line you can put a lot more in the rest. The bug number is the important bit in the first line. <br>
<br>
Chris <br>
<br>
<br><br><div class="gmail_quote">On 30 July 2018 4:39:46 PM NZST, David Cook <dcook@prosentient.com.au> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="WordSection1"><p class="MsoNormal"><span lang="FR-CA">Hi all,<o:p></o:p></span></p><p class="MsoNormal"><span lang="FR-CA"><o:p> </o:p></span></p><p class="MsoNormal">So Jonathan linked me to this the other day: <span lang="FR-CA"><a href="https://wiki.koha-community.org/wiki/Commit_messages#Good_commit_messages_2"><span lang="EN-AU">https://wiki.koha-community.org/wiki/Commit_messages#Good_commit_messages_2</span></a></span> <o:p></o:p></p><p class="MsoNormal"><o:p> </o:p></p><p class="MsoNormal">I don’t understand one of the “Bad commit messages” though. I thought everyone always starts a good commit message with “Bug 12345 - “. Am I missing something there?<o:p></o:p></p><p class="MsoNormal"><o:p> </o:p></p><p class="MsoNormal">Personally, I don’t think you can always explain what the *<b>bug</b>* is in 50 characters, although I’m super on board for the commit message containing what the *<b>fix</b>* does. <o:p></o:p></p><p class="MsoNormal"><o:p> </o:p></p><p class="MsoNormal">I’m writing a commit message for <a href="https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131">https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131</a> and struggling a bit as the bug is actually kind of convoluted. <o:p></o:p></p><p class="MsoNormal"><o:p> </o:p></p><p class="MsoNormal"><span style="mso-fareast-language:EN-AU">David Cook<o:p></o:p></span></p><p class="MsoNormal"><span style="mso-fareast-language:EN-AU">Systems Librarian<o:p></o:p></span></p><p class="MsoNormal"><span style="mso-fareast-language:EN-AU">Prosentient Systems<o:p></o:p></span></p><p class="MsoNormal"><span style="mso-fareast-language:EN-AU">72/330 Wattle St<o:p></o:p></span></p><p class="MsoNormal"><span style="mso-fareast-language:EN-AU">Ultimo, NSW 2007<o:p></o:p></span></p><p class="MsoNormal"><span style="mso-fareast-language:EN-AU">Australia<o:p></o:p></span></p><p class="MsoNormal"><span style="mso-fareast-language:EN-AU"><o:p> </o:p></span></p><p class="MsoNormal"><span style="mso-fareast-language:EN-AU">Office: 02 9212 0899<o:p></o:p></span></p><p class="MsoNormal"><span style="mso-fareast-language:EN-AU">Direct: 02 8005 0595<o:p></o:p></span></p><p class="MsoNormal"><o:p> </o:p></p></div></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>