<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Barton,</p>
<p>I think holds on items without item types is a special case of
"items without itemtypes". Generally items without itemtypes (with
item-level_itype on items) will cause problems with Koha and
should be avoided. I think the best option would be to make
itemtype mandatory now that bug 14662 is fixed.</p>
<p>Jonathan has started a new script to catch inconsistencies like
that, that can check for missing itemtypes:<br>
</p>
<p><span id="summary_container">Bug 21150 - <span
id="short_desc_nonedit_display">Data inconsistencies - item
types</span></span><br>
<a class="moz-txt-link-freetext" href="https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150">https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150</a></p>
<p>It can also check for false authority types, and missing
holdingbranch and homebranch in items. More could be added to it.</p>
<p>Hope this helps,<br>
</p>
<p>Katrin<br>
</p>
<p>On 28.09.2018 21:20, Barton Chittenden wrote:<br>
</p>
<blockquote type="cite"
cite="mid:CAMSJbVtcyDK+VjvMJuAD+Y+t615o6b=AGq8c-1EJ82X-Fm_yOA@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">When ByWater started upgrading our
partners to 17.11 last spring, I noticed that we were
getting a lot of errors of the form
<div><br>
</div>
<div>
<div>"can't call method * on an undefined value at
..."</div>
</div>
<div><br>
</div>
<div>We're starting to see these errors because more
and more of our code uses Koha objects, and these
will fail if a method is called on an undefined
object.</div>
<div><br>
</div>
<div>I brought this up here: <a
href="http://lists.koha-community.org/pipermail/koha-devel/2018-June/044613.html"
moz-do-not-send="true">http://lists.koha-community.org/pipermail/koha-devel/2018-June/044613.html</a><br>
</div>
<div><br>
</div>
<div>I think that there was also another thread about
this, which I can't find at the moment... Jonathan's
opinion on this is that we should start creating
queries which find data that will fail. This thread
is for those queries, since I have an example:</div>
<div><br>
</div>
<div>
<div>Circulating or holdable items without item type</div>
</div>
<div><br>
</div>
<div>
<div>SELECT</div>
<div> biblionumber,</div>
<div> itemnumber,</div>
<div> barcode,</div>
<div> title,</div>
<div> notforloan</div>
<div>FROM</div>
<div> items</div>
<div> INNER JOIN biblio USING (biblionumber)</div>
<div>WHERE</div>
<div> notforloan < 1</div>
<div> AND itype IS NULL</div>
</div>
<div><br>
</div>
<div>Once we have a few of these at hand, I'll start a
page on the Koha wiki.</div>
<div><br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Koha-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Koha-devel@lists.koha-community.org">Koha-devel@lists.koha-community.org</a>
<a class="moz-txt-link-freetext" href="http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel">http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a>
website : <a class="moz-txt-link-freetext" href="http://www.koha-community.org/">http://www.koha-community.org/</a>
git : <a class="moz-txt-link-freetext" href="http://git.koha-community.org/">http://git.koha-community.org/</a>
bugs : <a class="moz-txt-link-freetext" href="http://bugs.koha-community.org/">http://bugs.koha-community.org/</a></pre>
</blockquote>
<br>
</body>
</html>