<div dir="ltr">I happened to spot the same only yesterday and wondered about doing such a tidy up too..<div><br></div><div>I'd agree with Tomas, where the collate matches the table I'd drop it from the column.. I didn't go ahead and do it yet as I didn't want to introduce any pain for RMaints without discussing it first.</div><div><br></div><div><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><table cellspacing="0" cellpadding="0" width="410" style="font-family:"Times New Roman""><tbody><tr><td colspan="2"><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"></p></td></tr></tbody></table><table cellspacing="0" cellpadding="0" width="450" style="font-family:"Times New Roman""><colgroup><col width="99"><col><col></colgroup><tbody><tr><td width="300"><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><strong>Martin Renvoize</strong></p></td><td rowspan="2"><p style="line-height:20px;margin:0px"><a href="https://www.ptfs-europe.com" border="0" target="_blank"><img src="https://www.ptfs-europe.com/wp-content/uploads/2018/10/ptfs-logo-full-email-sig.png" width="" height="" border="0"></a></p></td></tr><tr><td colspan="2"><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)">Development Team Manager</p></td></tr><tr><td colspan="2"><p style="font-family:Arial;margin:0px"> </p></td></tr><tr><td colspan="2"><p style="font-family:Arial;margin:0px"> </p></td></tr><tr><td><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><strong>Phone:</strong> +44 (0) 1483 378728</p></td><td><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><strong>Mobile:</strong> +44 (0) 7725 985 636</p></td></tr><tr><td><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><strong>Email:</strong> <a href="mailto:martin.renvoize@ptfs-europe.com" style="color:rgb(45,92,136)" target="_blank">martin.renvoize@ptfs-europe.com</a><br></p></td><td><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><strong>Fax:</strong> +44 (0) 800 756 6384</p></td></tr><tr><td><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><br></p></td><td><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><a href="https://www.ptfs-europe.com" style="color:rgb(45,92,136)" target="_blank">www.ptfs-europe.com</a></p></td></tr><tr><td><p style="font-family:Arial;margin:0px"> </p></td></tr><tr><td><p style="font-family:Arial;margin:0px"> </p></td></tr><tr><td><p style="font-family:Arial;margin:0px"> </p></td></tr></tbody></table><table cellspacing="0" cellpadding="0" style="font-family:"Times New Roman";border-top:1px solid rgb(194,194,194);padding:20px 0px 0px;margin:0px"><tbody><tr><td><p style="font-family:Arial;font-size:12px;color:rgb(45,92,136);margin:0px">Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30</p><br><p style="font-family:Arial;font-size:12px;color:rgb(45,92,136);margin:0px">The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at <a href="mailto:info@ptfs-europe.com" target="_blank">info@ptfs-europe.com</a></p></td></tr></tbody></table><span style="font-size:12.8px"><br></span></div></div><div dir="ltr"></div></div></div></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 27 Sep 2019 at 18:06, Tomas Cohen Arazi <<a href="mailto:tomascohen@gmail.com">tomascohen@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I think it doesn't really make sense. There are cases in which the general table collation is utf8mb4_unicode_ci and some columns need utf8mb4_binary. I think those are the only meaningful ones.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">El vie., 27 sept. 2019 a las 11:27, Fridolin SOMERS (<<a href="mailto:fridolin.somers@biblibre.com" target="_blank">fridolin.somers@biblibre.com</a>>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi<br>
<br>
I'm working on DB structure compare.<br>
I note that in installer/data/mysql/kohastructure.sql, a few columns <br>
define CHARACTER SET and/or COLLATE, with same values as table.<br>
<br>
Is this usefull or should we remove it ?<br>
<br>
$ grep 'COLLATE' installer/data/mysql/kohastructure.sql | grep -v <br>
ENGIN | grep 'utf8mb4_unicode_ci'<br>
`category_name` varchar(32) COLLATE utf8mb4_unicode_ci NOT NULL <br>
DEFAULT '',<br>
`font` char(10) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT <br>
NULL DEFAULT 'TR',<br>
`text_justify` char(1) CHARACTER SET utf8mb4 COLLATE <br>
utf8mb4_unicode_ci NOT NULL DEFAULT 'L',<br>
`auto_renew_error` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT <br>
NULL, -- automatic renewal error<br>
`auto_renew_error` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT <br>
NULL, -- automatic renewal error<br>
`suppliers_report` MEDIUMTEXT COLLATE utf8mb4_unicode_ci, -- reports <br>
received from suppliers<br>
entity varchar(16) COLLATE utf8mb4_unicode_ci NOT NULL,<br>
code varchar(64) COLLATE utf8mb4_unicode_ci NOT NULL,<br>
lang varchar(25) COLLATE utf8mb4_unicode_ci NOT NULL, -- could be <br>
a foreign key<br>
translation MEDIUMTEXT COLLATE utf8mb4_unicode_ci,<br>
`branchcode` varchar(10) CHARACTER SET utf8mb4 COLLATE <br>
utf8mb4_unicode_ci DEFAULT NULL,<br>
<br>
-- <br>
Fridolin SOMERS <<a href="mailto:fridolin.somers@biblibre.com" target="_blank">fridolin.somers@biblibre.com</a>><br>
BibLibre, France - software and system maintainer<br>
_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-community.org</a><br>
<a href="https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.org/</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div style="font-size:12.8px">Tomás Cohen Arazi</div><div style="font-size:12.8px">Theke Solutions (<a href="http://theke.io/" target="_blank">http://theke.io</a>)<br>✆ +54 9351 3513384<br>GPG: B2F3C15F</div></div></div></div></div>
_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-community.org</a><br>
<a href="https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.org/</a><br>
</blockquote></div>