<div dir="ltr"><div>href is supposed to be an anchor, but it's an url</div><div><a href="https://www.w3schools.com/Bootstrap/bootstrap_ref_js_modal.asp">https://www.w3schools.com/Bootstrap/bootstrap_ref_js_modal.asp</a></div><div><br></div><div>Caused by</div><div> commit 8b1fb387acee35ba64f61d59fd332a79<br> Bug 14862: Upgrade jQuery from 1.7 to 3.4.1 in OPAC</div><div><br></div><div>We should replace the href="/cgi-bin/koha/<a href="http://opac-user.pl">opac-user.pl</a>" with href="#". But I first glance I'd say that the open id connect stuff is broken.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le mer. 4 mars 2020 à 09:36, <<a href="mailto:dcook@prosentient.com.au">dcook@prosentient.com.au</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-AU"><div class="gmail-m_-3011596237024127907WordSection1"><p class="MsoNormal">Hi all (and especially Owen),<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">I’m noticing some odd Javascript errors in the OPAC in 19.11 and master. <u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">Steps to reproduce:<u></u><u></u></p><ol style="margin-top:0cm" type="1" start="1"><li class="gmail-m_-3011596237024127907MsoListParagraph" style="margin-left:0cm">Go to the OPAC and open the F12 dev tools. <u></u><u></u></li><li class="gmail-m_-3011596237024127907MsoListParagraph" style="margin-left:0cm">Click on “Log in to your account”<u></u><u></u></li><li class="gmail-m_-3011596237024127907MsoListParagraph" style="margin-left:0cm">Note the following in your console logs<u></u><u></u></li></ol><p class="MsoNormal">jquery-3.4.1.min_19.1200030.js:2 Uncaught Error: Syntax error, unrecognized expression: /cgi-bin/koha/<a href="http://opac-user.pl" target="_blank">opac-user.pl</a><u></u><u></u></p><p class="MsoNormal"> at Function.se.error (jquery-3.4.1.min_19.1200030.js:2)<u></u><u></u></p><p class="MsoNormal"> at se.tokenize (jquery-3.4.1.min_19.1200030.js:2)<u></u><u></u></p><p class="MsoNormal"> at se.select (jquery-3.4.1.min_19.1200030.js:2)<u></u><u></u></p><p class="MsoNormal"> at Function.se (jquery-3.4.1.min_19.1200030.js:2)<u></u><u></u></p><p class="MsoNormal"> at Function.s.find (jquery-migrate-3.1.0.min_19.1200030.js:2)<u></u><u></u></p><p class="MsoNormal"> at k.fn.init.find (jquery-3.4.1.min_19.1200030.js:2)<u></u><u></u></p><p class="MsoNormal"> at s.fn.init.k.fn.init (jquery-3.4.1.min_19.1200030.js:2)<u></u><u></u></p><p class="MsoNormal"> at new s.fn.init (jquery-migrate-3.1.0.min_19.1200030.js:2)<u></u><u></u></p><p class="MsoNormal"> at k (jquery-3.4.1.min_19.1200030.js:2)<u></u><u></u></p><p class="MsoNormal" style="text-indent:9.75pt">at HTMLAnchorElement.<anonymous> (bootstrap.min_19.1200030.js:6)<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">Using the Chrome tools, I was able to pretty print the Javascript, so now I see the following:<u></u><u></u></p><p class="MsoNormal">Uncaught Error: Syntax error, unrecognized expression: /cgi-bin/koha/<a href="http://opac-user.pl" target="_blank">opac-user.pl</a><u></u><u></u></p><p class="MsoNormal"> at Function.se.error (jquery-3.4.1.min_19.1200030.js:formatted:546)<u></u><u></u></p><p class="MsoNormal"> at se.tokenize (jquery-3.4.1.min_19.1200030.js:formatted:969)<u></u><u></u></p><p class="MsoNormal"> at se.select (jquery-3.4.1.min_19.1200030.js:formatted:1024)<u></u><u></u></p><p class="MsoNormal"> at Function.se (jquery-3.4.1.min_19.1200030.js:formatted:289)<u></u><u></u></p><p class="MsoNormal"> at Function.s.find (jquery-migrate-3.1.0.min_19.1200030.js:2)<u></u><u></u></p><p class="MsoNormal"> at k.fn.init.find (jquery-3.4.1.min_19.1200030.js:formatted:1138)<u></u><u></u></p><p class="MsoNormal"> at s.fn.init.k.fn.init (jquery-3.4.1.min_19.1200030.js:formatted:1159)<u></u><u></u></p><p class="MsoNormal"> at new s.fn.init (jquery-migrate-3.1.0.min_19.1200030.js:2)<u></u><u></u></p><p class="MsoNormal"> at k (jquery-3.4.1.min_19.1200030.js:formatted:50)<u></u><u></u></p><p class="MsoNormal" style="text-indent:9.75pt">at HTMLAnchorElement.<anonymous> (bootstrap.min_19.1200030.js:formatted:535)<u></u><u></u></p><p class="MsoNormal" style="text-indent:9.75pt"><u></u> <u></u></p><p class="MsoNormal">It kind of looks to me like some sort of incompatibility between Bootstrap 2.3.1 and Jquery 3.4.1?<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">I’ve put breakpoints up and down this code but it’s not jumping out at me exactly what’s happening except that maybe it’s trying to use the href attribute as a selector and it’s not working… but why it would even try in the first place confuses me. It looks like a Bootstrap-level thing, which is why I’m thinking maybe older versions of Jquery worked a bit differently? <u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">Anyway I’ve already stayed way too late at work today. Maybe someone smarter than me can figure this one out.<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">David Cook<u></u><u></u></p><p class="MsoNormal">Systems Librarian<u></u><u></u></p><p class="MsoNormal">Prosentient Systems<u></u><u></u></p><p class="MsoNormal">72/330 Wattle St<u></u><u></u></p><p class="MsoNormal">Ultimo, NSW 2007<u></u><u></u></p><p class="MsoNormal">Australia<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">Office: 02 9212 0899<u></u><u></u></p><p class="MsoNormal">Direct: 02 8005 0595<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p></div></div>_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-community.org</a><br>
<a href="https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="http://www.koha-community.org/" rel="noreferrer" target="_blank">http://www.koha-community.org/</a><br>
git : <a href="http://git.koha-community.org/" rel="noreferrer" target="_blank">http://git.koha-community.org/</a><br>
bugs : <a href="http://bugs.koha-community.org/" rel="noreferrer" target="_blank">http://bugs.koha-community.org/</a><br>
</blockquote></div>