<div dir="ltr">Hi Thomas, <div><br></div><div>Welcome aboard the Koha devs. I'm afraid we don't accept github pull requests at this time. It's come up a few times, but to keep our workflows clear for the largest group of people we've stuck to Bugzilla and mailbox patches so far (They're easy to apply to all our other infrastructure for testing etc).</div><div><br></div><div>Onto the patch itself.</div><div><br></div><div>I've come across this exact case a month or so now.. in fact, I have a vague recollection of pointing it out to someone on IRC recently.. perhaps that was you.</div><div><br></div><div>Your code looks mostly reasonable to me, but I'm also not close enough to how the linking all fits together to know what side effect it might have.. :(.</div><div><br></div><div>If you're happy to give git-bz a try as Nicolas suggested, that would give us a head start in terms of onboarding fellow testers and devs.. if not let me know and I can extract your patch from github for you and submit it to BZ.</div><div><br></div><div><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><p class="MsoNormal" style="color:rgb(0,0,0);font-size:medium;font-family:Arial;margin:0in 0in 0pt"></p><table cellspacing="0" cellpadding="0" width="500" style="font-family:"Times New Roman""><colgroup><col width="99"><col><col></colgroup><tbody><tr><td width="350"><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><strong>Martin Renvoize, MPhys (Hons)</strong></p></td><td rowspan="2"><p style="line-height:20px;margin:0px"><a href="https://www.ptfs-europe.com" border="0" target="_blank"><img src="https://www.ptfs-europe.com/wp-content/uploads/2018/10/ptfs-logo-full-email-sig.png" width="" height="" border="0"></a></p></td></tr><tr><td colspan="2"><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)">Head of Development and Community Engagement</p></td></tr><tr><td colspan="2"><p style="font-family:Arial;margin:0px"> </p></td></tr><tr><td><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><strong>Phone:</strong> +44 (0) 1483 378728</p></td><td><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><strong>Mobile:</strong> +44 (0) 7725 985 636</p></td></tr><tr><td><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><strong>Email:</strong> <a href="mailto:martin.renvoize@ptfs-europe.com" style="color:rgb(45,92,136)" target="_blank">martin.renvoize@ptfs-europe.com</a></p></td><td><p style="font-family:Arial;font-size:12px;line-height:20px;margin:0px;color:rgb(45,92,136)"><a href="https://www.ptfs-europe.com" style="color:rgb(45,92,136)" target="_blank">www.ptfs-europe.com</a></p></td></tr><tr><td><p style="font-family:Arial;margin:0px"> </p></td></tr></tbody></table><table cellspacing="0" cellpadding="0" style="font-family:"Times New Roman";border-top:1px solid rgb(194,194,194);padding:20px 0px 0px;margin:0px;width:500px"><tbody><tr><td width="70"><img src="https://docs.google.com/uc?export=download&id=1ZF3h_pmAPyM0wRMtph03kj5IQkHBf18H&revid=0BzHGjNEMDNbNYzNwY2FaK20wQVFwYTM1d0hzUXd4T3JXMzNrPQ"></td><td><strong style="color:rgb(45,92,136);font-size:12px"><a href="http://eepurl.com/dPjjkn" target="_blank">Sign up for our newsletters here</a> or by scanning the QR code</strong></td></tr><tr><td><p style="font-family:Arial;margin:0px"> </p></td></tr></tbody></table><table cellspacing="0" cellpadding="0" style="font-family:"Times New Roman";border-top:1px solid rgb(194,194,194);padding:20px 0px 0px;margin:0px;width:500px"><tbody><tr><td><p style="font-family:Arial;font-size:12px;color:rgb(45,92,136);margin:0px">Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30</p><br><p style="font-family:Arial;font-size:12px;color:rgb(45,92,136);margin:0px">The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at <a href="mailto:info@ptfs-europe.com" target="_blank">info@ptfs-europe.com</a></p></td></tr></tbody></table></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 30 Mar 2021 at 08:34, Nicolas Legrand <<a href="mailto:nicolas.legrand@bulac.fr">nicolas.legrand@bulac.fr</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hiya Thomas,<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le mar. 30 mars 2021 à 09:28, Thomas Klausner <<a href="mailto:domm@plix.at" target="_blank">domm@plix.at</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi!<br>
<br>
Can anybody here maybe review / comment on my bug report & patch 28022<br>
<a href="https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022" rel="noreferrer" target="_blank">https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022</a><br>
<br>
<br>
Here's the patch:<br>
<a href="https://github.com/domm/Koha/commit/d19abcc23d5793becdd5edca26c4bd2d47fcd33f" rel="noreferrer" target="_blank">https://github.com/domm/Koha/commit/d19abcc23d5793becdd5edca26c4bd2d47fcd33f</a></blockquote><div><br></div><div>Here is the doc explaining how to submit a patch for Koha :</div><div><br></div><div><a href="https://wiki.koha-community.org/wiki/Git_bz_configuration" target="_blank">https://wiki.koha-community.org/wiki/Git_bz_configuration</a></div><div><br></div><div>You have to install a utility (git bz) that uploads your patches to Bugzilla. Then other people will be able to test, comment or sign your patch, also using git bz.</div><div><br></div><div>Regards,</div><div><br></div><div>-- <br></div><div>Nicolas</div></div></div>
_______________________________________________<br>
Koha-devel mailing list<br>
<a href="mailto:Koha-devel@lists.koha-community.org" target="_blank">Koha-devel@lists.koha-community.org</a><br>
<a href="https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel" rel="noreferrer" target="_blank">https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel</a><br>
website : <a href="https://www.koha-community.org/" rel="noreferrer" target="_blank">https://www.koha-community.org/</a><br>
git : <a href="https://git.koha-community.org/" rel="noreferrer" target="_blank">https://git.koha-community.org/</a><br>
bugs : <a href="https://bugs.koha-community.org/" rel="noreferrer" target="_blank">https://bugs.koha-community.org/</a><br>
</blockquote></div>