<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body>A new request with request id 19218 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is : <br><br>Title : Koha-devel Digest, Vol 184, Issue 24<br>Category : <br>Description : <div>Send Koha-devel mailing list submissions to<br> koha-devel@lists.koha-community.org<br><br>To subscribe or unsubscribe via the World Wide Web, visit<br> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>or, via email, send a message with subject or body 'help' to<br> koha-devel-request@lists.koha-community.org<br><br>You can reach the person managing the list at<br> koha-devel-owner@lists.koha-community.org<br><br>When replying, please edit your Subject line so it is more specific<br>than "Re: Contents of Koha-devel digest..."<br><br><br>Today's Topics:<br><br> 1. Second look needed on a few (2!) lines related to plugins<br> (Victor Grousset/tuxayo)<br> 2. Re: Second look needed on a few (2!) lines related to plugins<br> (Mason James)<br> 3. Re: Second look needed on a few (2!) lines related to plugins<br> (Fridolin SOMERS)<br> 4. Bug 28022 - MARC subfield 9 not honoring visibility<br> (Thomas Klausner)<br> 5. Re: Bug 28022 - MARC subfield 9 not honoring visibility<br> (Nicolas Legrand)<br> 6. Re: Switching from SysV to Systemd for koha-common service<br> (Fridolin SOMERS)<br><br><br>----------------------------------------------------------------------<br><br>Message: 1<br>Date: Mon, 29 Mar 2021 18:25:15 +0200<br>From: Victor Grousset/tuxayo <victor@tuxayo.net><br>To: koha-devel <koha-devel@lists.koha-community.org><br>Subject: [Koha-devel] Second look needed on a few (2!) lines related<br> to plugins<br>Message-ID: <565e5e29-2ebc-2490-aaec-c5aa1e4def97@tuxayo.net><br>Content-Type: text/plain; charset=utf-8; format=flowed<br><br>Hi :)<br><br>It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl<br><br>There are two lines in the patch that are out of my knowledge to QA:<br>https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6<br><br>[% PROCESS plugin_pars %]<br>[...]<br>$plugin? ( public => 1 ): ()<br><br>Does this look familiar to anyone?<br><br>Cheers,<br><br>-- <br>Victor Grousset/tuxayo<br><br><br>------------------------------<br><br>Message: 2<br>Date: Tue, 30 Mar 2021 12:31:08 +1300<br>From: Mason James <mtj@kohaaloha.com><br>To: Victor Grousset/tuxayo <victor@tuxayo.net>, koha-devel<br> <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Second look needed on a few (2!) lines<br> related to plugins<br>Message-ID: <0b274655-7c51-8e25-48ab-619cf77fcc83@kohaaloha.com><br>Content-Type: text/plain; charset=utf-8; format=flowed<br><br>hiya, here's some info...<br><br>https://docstore.mik.ua/orelly/perl3/prog/ch03_16.htm<br><br><br>On 30/03/21 5:25 am, Victor Grousset/tuxayo wrote:<br>> Hi :)<br>><br>> It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl<br>><br>> There are two lines in the patch that are out of my knowledge to QA:<br>> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6<br>><br>> [% PROCESS plugin_pars %]<br>> [...]<br>> $plugin? ( public => 1 ): ()<br>><br>> Does this look familiar to anyone?<br>><br>> Cheers,<br>><br><br><br><br>------------------------------<br><br>Message: 3<br>Date: Tue, 30 Mar 2021 09:08:21 +0200<br>From: Fridolin SOMERS <fridolin.somers@biblibre.com><br>To: koha-devel@lists.koha-community.org<br>Subject: Re: [Koha-devel] Second look needed on a few (2!) lines<br> related to plugins<br>Message-ID: <ba0659bf-bf3b-56a2-6f2c-ae319460ee4c@biblibre.com><br>Content-Type: text/plain; charset=utf-8; format=flowed<br><br>Hi,<br><br>In my opinion this syntax looks strange.<br>I'd prefer :<br> my $filter = { uploadcategorycode => $browsecategory };<br> $filter{public} = 1 if $plugin;<br> $uploads = Koha::UploadedFiles->search($filter)->unblessed;<br><br>Super cool enhancement BTW ;)<br><br>Best regards,<br><br>Le 29/03/2021 à 18:25, Victor Grousset/tuxayo a écrit :<br>> Hi :)<br>> <br>> It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl<br>> <br>> There are two lines in the patch that are out of my knowledge to QA:<br>> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6<br>> <br>> [% PROCESS plugin_pars %]<br>> [...]<br>> $plugin? ( public => 1 ): ()<br>> <br>> Does this look familiar to anyone?<br>> <br>> Cheers,<br>> <br><br>-- <br>Fridolin SOMERS <fridolin.somers@biblibre.com><br>Software and system maintainer 🦄<br>BibLibre, France<br><br><br>------------------------------<br><br>Message: 4<br>Date: Tue, 30 Mar 2021 09:28:13 +0200<br>From: Thomas Klausner <domm@plix.at><br>To: koha-devel@lists.koha-community.org<br>Subject: [Koha-devel] Bug 28022 - MARC subfield 9 not honoring<br> visibility<br>Message-ID: <YGLTDU2S01n5x5fn@plix.at><br>Content-Type: text/plain; charset=us-ascii<br><br>Hi!<br><br>Can anybody here maybe review / comment on my bug report & patch 28022<br>https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022<br><br><br>Here's the patch:<br>https://github.com/domm/Koha/commit/d19abcc23d5793becdd5edca26c4bd2d47fcd33f<br><br>Greetings,<br>domm<br><br>-- <br>#!/usr/bin/perl http://domm.plix.at<br>for(ref bless{},just'another'perl'hacker){s-:+-$"-g&&print$_.$/}<br><br><br>------------------------------<br><br>Message: 5<br>Date: Tue, 30 Mar 2021 09:34:03 +0200<br>From: Nicolas Legrand <nicolas.legrand@bulac.fr><br>To: koha-devel <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Bug 28022 - MARC subfield 9 not honoring<br> visibility<br>Message-ID:<br> <CAODBKZfZxdO+QTONGM=JJr+a3yu0vqDVZ4sFKynUBuFNNZzvoA@mail.gmail.com><br>Content-Type: text/plain; charset="utf-8"<br><br>Hiya Thomas,<br><br>Le mar. 30 mars 2021 à 09:28, Thomas Klausner <domm@plix.at> a écrit :<br><br>> Hi!<br>><br>> Can anybody here maybe review / comment on my bug report & patch 28022<br>> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022<br>><br>><br>> Here's the patch:<br>><br>> https://github.com/domm/Koha/commit/d19abcc23d5793becdd5edca26c4bd2d47fcd33f<br><br><br>Here is the doc explaining how to submit a patch for Koha :<br><br>https://wiki.koha-community.org/wiki/Git_bz_configuration<br><br>You have to install a utility (git bz) that uploads your patches to<br>Bugzilla. Then other people will be able to test, comment or sign your<br>patch, also using git bz.<br><br>Regards,<br><br>-- <br>Nicolas<br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210330/503d6455/attachment-0001.htm><br><br>------------------------------<br><br>Message: 6<br>Date: Tue, 30 Mar 2021 10:08:10 +0200<br>From: Fridolin SOMERS <fridolin.somers@biblibre.com><br>To: koha-devel@lists.koha-community.org<br>Subject: Re: [Koha-devel] Switching from SysV to Systemd for<br> koha-common service<br>Message-ID: <5788f577-0831-90cf-4696-444268910a3e@biblibre.com><br>Content-Type: text/plain; charset=UTF-8; format=flowed<br><br>Hi,<br><br>Very good idea :D<br><br>We at Biblibre have build a systemd unit for Starman and Zebra, it is <br>quite simple. But we dont use several Koha.<br><br>In ordre to implement for several Koha, I think we should use %i vars in <br>systemd unit.<br>Like it is in openvpn :<br>https://github.com/OpenVPN/openvpn/blob/master/distro/systemd/openvpn-client%40.service.in<br><br>It allows to call any unit (for example demo Koha) :<br>systemctl start koha-common@demo.<br><br>About restart :<br>I see you can define a different kill signal than stop :<br>https://www.freedesktop.org/software/systemd/man/systemd.kill.html#RestartKillSignal=<br><br>But you may use "reload" action instead :<br>https://www.freedesktop.org/software/systemd/man/systemd.service.html#ExecReload=<br><br>We use reload for starman it is more soft (it acts like apache gracefull <br>restart).<br><br>I attach some files here :<br>https://git.biblibre.com/biblibre/koha-nginx/src/branch/master/etc/systemd/system<br><br>Feel free to ask for help.<br><br>Best regards,<br><br>Le 25/03/2021 à 04:42, dcook@prosentient.com.au a écrit :<br>> Hi all,<br>> <br>> I was just installing koha-common, as you do, and I noticed the <br>> following warning:<br>> <br>> Failed to enable unit: Unit <br>> /run/systemd/generator.late/koha-common.service is transient or generated.<br>> <br>> This is the product of the following command: “update-rc.d koha-common <br>> enable”<br>> <br>> I think I was able to work around it by running the following: <br>> “/lib/systemd/systemd-sysv-install enable koha-common”<br>> <br>> However, I’m thinking it is probably time to switch koha-common from <br>> SysV to Systemd. We’ll lose a bit of functionality for the “status” <br>> option, but otherwise it shouldn’t be too bad. I think we’ll lose the <br>> “restart” as well as I think the systemd restart is a “stop” and “start”.<br>> <br>> David Cook<br>> <br>> Software Engineer<br>> <br>> Prosentient Systems<br>> <br>> Suite 7.03<br>> <br>> 6a Glen St<br>> <br>> Milsons Point NSW 2061<br>> <br>> Australia<br>> <br>> Office: 02 9212 0899<br>> <br>> Online: 02 8005 0595<br>> <br>> <br>> _______________________________________________<br>> Koha-devel mailing list<br>> Koha-devel@lists.koha-community.org<br>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>> website : https://www.koha-community.org/<br>> git : https://git.koha-community.org/<br>> bugs : https://bugs.koha-community.org/<br>> <br><br>-- <br>Fridolin SOMERS <fridolin.somers@biblibre.com><br>Software and system maintainer 🦄<br>BibLibre, France<br><br><br>------------------------------<br><br>Subject: Digest Footer<br><br>_______________________________________________<br>Koha-devel mailing list<br>Koha-devel@lists.koha-community.org<br>https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>website : https://www.koha-community.org/<br>git : https://git.koha-community.org/<br>bugs : https://bugs.koha-community.org/<br><br><br>------------------------------<br><br>End of Koha-devel Digest, Vol 184, Issue 24<br>*******************************************<br></div><br><br>NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.<br></body></html>