<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body>A new request with request id 17505 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is : <br><br>Title : Koha-devel Digest, Vol 187, Issue 14<br>Category : <br>Description : <div>Send Koha-devel mailing list submissions to<br> koha-devel@lists.koha-community.org<br><br>To subscribe or unsubscribe via the World Wide Web, visit<br> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>or, via email, send a message with subject or body 'help' to<br> koha-devel-request@lists.koha-community.org<br><br>You can reach the person managing the list at<br> koha-devel-owner@lists.koha-community.org<br><br>When replying, please edit your Subject line so it is more specific<br>than "Re: Contents of Koha-devel digest..."<br><br><br>Today's Topics:<br><br> 1. pqf.properties / Zebra / Z3950 (Marcel de Rooy)<br> 2. Re: Follow-up patches and why not to use them (Marcel de Rooy)<br><br><br>----------------------------------------------------------------------<br><br>Message: 1<br>Date: Fri, 18 Jun 2021 08:36:11 +0200<br>From: Marcel de Rooy <rooy.de.m@gmail.com><br>To: koha-devel <koha-devel@lists.koha-community.org><br>Subject: [Koha-devel] pqf.properties / Zebra / Z3950<br>Message-ID:<br> <CAGv4ghb980n7AmDzoRCJLgJFYdRyQBsSntjyGVWEHVm=738U9A@mail.gmail.com><br>Content-Type: text/plain; charset="utf-8"<br><br>Hi all,<br>Looking at bug 8280.<br>I am wondering why we should have two pqf.properties files. They are<br>already not exactly the same.<br>Could we let the new daemon use the pqf file from the Zebra folder ?<br><br>Marcel<br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/eb559ee2/attachment-0001.htm><br><br>------------------------------<br><br>Message: 2<br>Date: Fri, 18 Jun 2021 06:45:33 +0000<br>From: Marcel de Rooy <M.de.Rooy@rijksmuseum.nl><br>To: Joonas Kylmälä <joonas.kylmala@helsinki.fi>, koha-devel<br> <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Follow-up patches and why not to use them<br>Message-ID:<br> <AM0PR05MB4851B17549F5B077DB9E8480CE0D9@AM0PR05MB4851.eurprd05.prod.outlook.com><br> <br>Content-Type: text/plain; charset="utf-8"<br><br>Agree with Julian here. It depends.<br>You could squash follow-up patches yourself too before reverting them?<br>In some cases patches tell us a nice story, in a lot of cases it might be confusing or messy..<br><br>________________________________<br><br>RIJKS<br>MUSEUM<br><br>T/m 18 jaar gratis <br><br>Kijk hier de nieuwste aflevering van Rijksmuseum Unlocked<br>RM<br><br>xxx<br><br>Please think before you print<br>Van: Koha-devel <koha-devel-bounces@lists.koha-community.org> namens Joonas Kylmälä <joonas.kylmala@helsinki.fi><br>Verzonden: vrijdag 4 juni 2021 12:36<br>Aan: koha-devel <koha-devel@lists.koha-community.org><br>Onderwerp: [Koha-devel] Follow-up patches and why not to use them<br><br>Hi,<br><br>I just bumped in another case of follow-up patch style causing us<br>trouble. In bug<br>https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.koha-community.org%2Fbugzilla3%2Fshow_bug.cgi%3Fid%3D28490&data=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C034cbe091d724aacf4bb08d927449659%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637583998828372650%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=MO%2B9n0LRxKvAcR56xjhqEKk9Rj%2F1LXAT2h%2F8Gs0KFuo%3D&reserved=0 I had to<br>spend considerable amount of time just reverting all the problematic<br>patches and making sure I didn't miss any related patches, instead of<br>just reverting one patch and knowing I would be good to go with that.<br>Reverting this many patches also means a lot more review work yet again<br>because you have no commit messages to reference to easily or if you<br>want to use those you have to jump from patch to patch to find out what<br>the change does. And this extra review work needs to be done by two<br>people when reverting such follow-up patch series!<br><br>If we instead asked the original author to fix the patches then this<br>work would need to be done only ~once. The argument against this I have<br>heard is that it makes the review work harder because you don't know<br>what has changed since the previous version. I think however that is not<br>very useful because the second reviewer doesn't benefit from this at all<br>and makes their work harder and also the first reviewer even sometimes<br>might review the revision after many days by which time they have<br>forgotten already the context so basically they end up in the same<br>situation as the second reviewer and have to jump between patches.<br><br>Just my two cents, I hope we can stop doing follow-ups and instead have<br>commits which contain one single change to decrease our time spent on<br>review and make sure we don't miss any problems due to having to jump<br>between so many contexts.<br><br>Joonas<br>_______________________________________________<br>Koha-devel mailing list<br>Koha-devel@lists.koha-community.org<br>https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.koha-community.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fkoha-devel&data=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C034cbe091d724aacf4bb08d927449659%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637583998828372650%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=YOfCRiFHuDipvbacs%2F7rSGBjfNdBLiMalVrX%2Fw6DPJU%3D&reserved=0<br>website : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.koha-community.org%2F&data=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C034cbe091d724aacf4bb08d927449659%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637583998828372650%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=BfRZNeIWzogwtfG6rXjeDhxj74KeD3fHMmpdkOD%2B5b4%3D&reserved=0<br>git : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.koha-community.org%2F&data=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C034cbe091d724aacf4bb08d927449659%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637583998828382643%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=pofwHQiWC6PyO%2BOdya3i4bs4SMRX%2Bj61%2Fg3EZo6Y5iA%3D&reserved=0<br>bugs : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.koha-community.org%2F&data=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C034cbe091d724aacf4bb08d927449659%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637583998828382643%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=tg71m%2Fsy1lxJpDd7rIX9CIbqVgcvMiOOi4%2BsGFM1534%3D&reserved=0<br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment.htm><br>-------------- next part --------------<br>A non-text attachment was scrubbed...<br>Name: image015731.jpg<br>Type: image/jpeg<br>Size: 10243 bytes<br>Desc: image015731.jpg<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment.jpg><br>-------------- next part --------------<br>A non-text attachment was scrubbed...<br>Name: image692184.png<br>Type: image/png<br>Size: 910 bytes<br>Desc: image692184.png<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment.png><br>-------------- next part --------------<br>A non-text attachment was scrubbed...<br>Name: image098181.png<br>Type: image/png<br>Size: 737 bytes<br>Desc: image098181.png<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment-0001.png><br>-------------- next part --------------<br>A non-text attachment was scrubbed...<br>Name: image399729.png<br>Type: image/png<br>Size: 799 bytes<br>Desc: image399729.png<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment-0002.png><br>-------------- next part --------------<br>A non-text attachment was scrubbed...<br>Name: image713238.png<br>Type: image/png<br>Size: 804 bytes<br>Desc: image713238.png<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/d2dd8cd3/attachment-0003.png><br><br>------------------------------<br><br>Subject: Digest Footer<br><br>_______________________________________________<br>Koha-devel mailing list<br>Koha-devel@lists.koha-community.org<br>https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>website : https://www.koha-community.org/<br>git : https://git.koha-community.org/<br>bugs : https://bugs.koha-community.org/<br><br><br>------------------------------<br><br>End of Koha-devel Digest, Vol 187, Issue 14<br>*******************************************<br></div><br><br>NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.<br></body></html>