<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body>A new request with request id 17508 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is : <br><br>Title : Koha-devel Digest, Vol 187, Issue 15<br>Category : <br>Description : <div>Send Koha-devel mailing list submissions to<br> koha-devel@lists.koha-community.org<br><br>To subscribe or unsubscribe via the World Wide Web, visit<br> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>or, via email, send a message with subject or body 'help' to<br> koha-devel-request@lists.koha-community.org<br><br>You can reach the person managing the list at<br> koha-devel-owner@lists.koha-community.org<br><br>When replying, please edit your Subject line so it is more specific<br>than "Re: Contents of Koha-devel digest..."<br><br><br>Today's Topics:<br><br> 1. Re: Follow-up patches and why not to use them (Joonas Kylmälä)<br> 2. Re: Follow-up patches and why not to use them (Marcel de Rooy)<br><br><br>----------------------------------------------------------------------<br><br>Message: 1<br>Date: Fri, 18 Jun 2021 10:35:39 +0300<br>From: Joonas Kylmälä <joonas.kylmala@helsinki.fi><br>To: Marcel de Rooy <M.de.Rooy@rijksmuseum.nl>, koha-devel<br> <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Follow-up patches and why not to use them<br>Message-ID: <56d5f1a4-3d99-a851-c044-6184e949ba19@helsinki.fi><br>Content-Type: text/plain; charset=utf-8<br><br>Hi Marcel,<br><br>On 18/06/2021 09:45, Marcel de Rooy wrote:<br>> Agree with Julian here. It depends.<br>> You could squash follow-up patches yourself too before reverting them?<br>> In some cases patches tell us a nice story, in a lot of cases it might<br>> be confusing or messy..<br><br>I think you might not have seen yet my follow-up email yet to Julian<br>sent on the 7th of June. Basically squashing or reverting blindly is not<br>an option when you want to review that the changes make sense on top of<br>the new code base. Then the "nice story" or "confusing/messy story"<br>part: as I said in the follow-up email to Julian my wish was to have as<br>well commits with one logical change in each so then we should have<br>*always* a nice story to read.<br><br>Would love to hear your opinion now with these points clarified.<br><br>Joonas<br><br><br>------------------------------<br><br>Message: 2<br>Date: Fri, 18 Jun 2021 09:40:47 +0200<br>From: Marcel de Rooy <rooy.de.m@gmail.com><br>To: Joonas Kylmälä <joonas.kylmala@helsinki.fi><br>Cc: Marcel de Rooy <M.de.Rooy@rijksmuseum.nl>, koha-devel<br> <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Follow-up patches and why not to use them<br>Message-ID:<br> <CAGv4ghb7_mjPPRO8XK+9gG=dkh5=VG6=w28h-JpCrExWfqKz7g@mail.gmail.com><br>Content-Type: text/plain; charset="utf-8"<br><br>Yeah I probably missed it while catching up ;)<br>What you say makes sense, but the problem probably boils down to the gap<br>between theory and practice.<br><br>Op vr 18 jun. 2021 om 09:36 schreef Joonas Kylmälä <<br>joonas.kylmala@helsinki.fi>:<br><br>> Hi Marcel,<br>><br>> On 18/06/2021 09:45, Marcel de Rooy wrote:<br>> > Agree with Julian here. It depends.<br>> > You could squash follow-up patches yourself too before reverting them?<br>> > In some cases patches tell us a nice story, in a lot of cases it might<br>> > be confusing or messy..<br>><br>> I think you might not have seen yet my follow-up email yet to Julian<br>> sent on the 7th of June. Basically squashing or reverting blindly is not<br>> an option when you want to review that the changes make sense on top of<br>> the new code base. Then the "nice story" or "confusing/messy story"<br>> part: as I said in the follow-up email to Julian my wish was to have as<br>> well commits with one logical change in each so then we should have<br>> *always* a nice story to read.<br>><br>> Would love to hear your opinion now with these points clarified.<br>><br>> Joonas<br>> _______________________________________________<br>> Koha-devel mailing list<br>> Koha-devel@lists.koha-community.org<br>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>> website : https://www.koha-community.org/<br>> git : https://git.koha-community.org/<br>> bugs : https://bugs.koha-community.org/<br>><br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210618/34caaa89/attachment-0001.htm><br><br>------------------------------<br><br>Subject: Digest Footer<br><br>_______________________________________________<br>Koha-devel mailing list<br>Koha-devel@lists.koha-community.org<br>https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>website : https://www.koha-community.org/<br>git : https://git.koha-community.org/<br>bugs : https://bugs.koha-community.org/<br><br><br>------------------------------<br><br>End of Koha-devel Digest, Vol 187, Issue 15<br>*******************************************<br></div><br><br>NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.<br></body></html>