<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body>A new request with request id 9943 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is : <br><br>Title : Koha-devel Digest, Vol 198, Issue 14<br>Category : <br>Description : <div>Send Koha-devel mailing list submissions to<br> koha-devel@lists.koha-community.org<br><br>To subscribe or unsubscribe via the World Wide Web, visit<br> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>or, via email, send a message with subject or body 'help' to<br> koha-devel-request@lists.koha-community.org<br><br>You can reach the person managing the list at<br> koha-devel-owner@lists.koha-community.org<br><br>When replying, please edit your Subject line so it is more specific<br>than "Re: Contents of Koha-devel digest..."<br><br><br>Today's Topics:<br><br> 1. Plack graceful restart / reload (Bug 21366)<br> (dcook@prosentient.com.au)<br> 2. Bug 30684: Requesting community feedback on change to restart<br> behaviour of koha-* scripts (Alex Buckley)<br> 3. Re: Bug 30684: Requesting community feedback on change to<br> restart behaviour of koha-* scripts (dcook@prosentient.com.au)<br><br><br>----------------------------------------------------------------------<br><br>Message: 1<br>Date: Fri, 20 May 2022 11:35:47 +1000<br>From: <dcook@prosentient.com.au><br>To: "'Koha-devel'" <koha-devel@lists.koha-community.org><br>Subject: [Koha-devel] Plack graceful restart / reload (Bug 21366)<br>Message-ID: <08bd01d86be9$fb41b8d0$f1c52a70$@prosentient.com.au><br>Content-Type: text/plain; charset="utf-8"<br><br>Hi all,<br><br> <br><br>For years, we've been talking about providing a graceful restart for<br>Starman. <br><br> <br><br>Today, I needed it for a production instance to enable plugins without<br>disrupting anyone's Koha usage, so I ran: kill -SIGHUP $(cat<br>/var/run/koha/<instance name>/plack.pid)<br><br> <br><br>It worked so well.<br><br> <br><br>I'd be happy to provide a patch, but I imagine there might be some debate<br>about the precise implementation. So if folk could comment on<br>https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 that would<br>be great.<br><br> <br><br>David Cook<br><br>Senior Software Engineer<br><br>Prosentient Systems<br><br>Suite 7.03<br><br>6a Glen St<br><br>Milsons Point NSW 2061<br><br>Australia<br><br> <br><br>Office: 02 9212 0899<br><br>Online: 02 8005 0595<br><br> <br><br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20220520/be83ea2a/attachment-0001.htm><br><br>------------------------------<br><br>Message: 2<br>Date: Fri, 20 May 2022 16:11:18 +1200<br>From: Alex Buckley <alexbuckley@catalyst.net.nz><br>To: koha-devel@lists.koha-community.org<br>Subject: [Koha-devel] Bug 30684: Requesting community feedback on<br> change to restart behaviour of koha-* scripts<br>Message-ID: <6ea69452-e75a-0841-b52f-2b31e3b87fc4@catalyst.net.nz><br>Content-Type: text/plain; charset="utf-8"<br><br>Kia ora Koha community,<br><br>I'd love to hear your thoughts please on adding the following behaviour<br>across all koha-* scripts when passing the --restart parameter:<br><br>1. If the service is not running<br><br>2. You run sudo koha-<service> --restart <instancename> , e.g. sudo<br>koha-plack --restart kohadev<br><br>3. Koha stops the service, then starts it<br><br>*Context*<br><br>Bug 30684 was initially written to resolve the below error that is<br>thrown when you try restarting plack, if it's not already running:<br><br>/[FAIL] Error: Plack not running for <instancename>: failed!/<br><br>However, as Marcel noted the error is thrown by design: If you didn't<br>start it, you cannot restart it.<br><br>So it would be better to stop and then start the service. Also to ensure<br>this change was consistent, it should be implemented in all koha-*<br>scripts, not just koha-plack.<br><br>Is everyone happy for this change to be implemented in all koha-* scripts?<br><br>Thanks,<br><br>Alex<br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20220520/80daba67/attachment-0001.htm><br><br>------------------------------<br><br>Message: 3<br>Date: Fri, 20 May 2022 14:46:50 +1000<br>From: <dcook@prosentient.com.au><br>To: "'Alex Buckley'" <alexbuckley@catalyst.net.nz>,<br> <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Bug 30684: Requesting community feedback on<br> change to restart behaviour of koha-* scripts<br>Message-ID: <08cd01d86c04$a5d29520$f177bf60$@prosentient.com.au><br>Content-Type: text/plain; charset="utf-8"<br><br>I’m happy for this change. I think it would make the koha-* scripts more in line with the standard methodology of restarting Linux services.<br><br> <br><br>Another reason to do this… *I think* if you try to do a “koha-plack --restart" against 10 instances where the 5th instance isn’t running, the first 4 will restart but then the script will error out, and it won’t restart the last 5 instances. So this change would make batch updates much safer.<br><br> <br><br>(As an aside, Bug 21366 is about adding a --reload (ie graceful restart) to koha-plack, so I’m also holding off on doing that patch until Bug 30684 is resolved…)<br><br> <br><br>David Cook<br><br>Senior Software Engineer<br><br>Prosentient Systems<br><br>Suite 7.03<br><br>6a Glen St<br><br>Milsons Point NSW 2061<br><br>Australia<br><br> <br><br>Office: 02 9212 0899<br><br>Online: 02 8005 0595<br><br> <br><br>From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Alex Buckley<br>Sent: Friday, 20 May 2022 2:11 PM<br>To: koha-devel@lists.koha-community.org<br>Subject: [Koha-devel] Bug 30684: Requesting community feedback on change to restart behaviour of koha-* scripts<br><br> <br><br>Kia ora Koha community,<br><br>I'd love to hear your thoughts please on adding the following behaviour across all koha-* scripts when passing the --restart parameter:<br><br>1. If the service is not running<br><br>2. You run sudo koha-<service> --restart <instancename> , e.g. sudo koha-plack --restart kohadev<br><br>3. Koha stops the service, then starts it<br><br>Context<br><br>Bug 30684 was initially written to resolve the below error that is thrown when you try restarting plack, if it's not already running:<br><br>[FAIL] Error: Plack not running for <instancename>: failed!<br><br>However, as Marcel noted the error is thrown by design: If you didn't start it, you cannot restart it. <br><br>So it would be better to stop and then start the service. Also to ensure this change was consistent, it should be implemented in all koha-* scripts, not just koha-plack.<br><br>Is everyone happy for this change to be implemented in all koha-* scripts?<br><br>Thanks,<br><br>Alex<br><br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20220520/1a82a87d/attachment-0001.htm><br><br>------------------------------<br><br>Subject: Digest Footer<br><br>_______________________________________________<br>Koha-devel mailing list<br>Koha-devel@lists.koha-community.org<br>https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>website : https://www.koha-community.org/<br>git : https://git.koha-community.org/<br>bugs : https://bugs.koha-community.org/<br><br><br>------------------------------<br><br>End of Koha-devel Digest, Vol 198, Issue 14<br>*******************************************<br></div><br><br>NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.<br></body></html>