<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body>A new request with request id 18145 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is : <br><br>Title : Koha-devel Digest, Vol 186, Issue 19<br>Category : <br>Description : <div>Send Koha-devel mailing list submissions to<br> koha-devel@lists.koha-community.org<br><br>To subscribe or unsubscribe via the World Wide Web, visit<br> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>or, via email, send a message with subject or body 'help' to<br> koha-devel-request@lists.koha-community.org<br><br>You can reach the person managing the list at<br> koha-devel-owner@lists.koha-community.org<br><br>When replying, please edit your Subject line so it is more specific<br>than "Re: Contents of Koha-devel digest..."<br><br><br>Today's Topics:<br><br> 1. Release of Koha 20.11.06 (Fridolin SOMERS)<br> 2. Release of Koha 20.05.12 (Andrew Fuerste-Henry)<br> 3. Deadlock issues when running the tests in parallel, and maybe<br> not only in the tests? (Victor Grousset/tuxayo)<br> 4. Re: Deadlock issues when running the tests in parallel, and<br> maybe not only in the tests? (Joonas Kylmälä)<br> 5. Re: Deadlock issues when running the tests in parallel, and<br> maybe not only in the tests? (Joonas Kylmälä)<br> 6. Re: Deadlock issues when running the tests in parallel, and<br> maybe not only in the tests? (Victor Grousset/tuxayo)<br><br><br>----------------------------------------------------------------------<br><br>Message: 1<br>Date: Tue, 25 May 2021 16:25:18 +0200<br>From: Fridolin SOMERS <fridolin.somers@biblibre.com><br>To: koha-devel <koha-devel@lists.koha-community.org>,<br> "koha@lists.katipo.co.nz" <koha@lists.katipo.co.nz><br>Subject: [Koha-devel] Release of Koha 20.11.06<br>Message-ID: <6b3ad47c-f965-0bd8-bedc-82b68ae46e14@biblibre.com><br>Content-Type: text/plain; charset=utf-8; format=flowed<br><br>Hello everyone 🤗<br><br>The Koha community is proud to announce the release of Koha 20.11.06.<br><br>It is a maintenance release with 3 security fixes.<br><br>The full release notes are available here:<br>https://koha-community.org/koha-20-11-06-released/<br><br>Debian packages should be available in a few days.<br><br>PS : 🌼<br><br>This is last release of 21.05 cycle.<br>I'll continue maintaining 20.11.x that will switch to 'oldstable'.<br><br>In 20.11.1889 was born Mr. Hubble https://en.wikipedia.org/wiki/Edwin_Hubble<br>So 20.11 is going to infinity ... and beyond 🚀<br><br>Best regards 🤓<br><br>-- <br>Fridolin SOMERS <fridolin.somers@biblibre.com><br>Software and system maintainer 🦄<br>BibLibre, France<br><br><br>------------------------------<br><br>Message: 2<br>Date: Tue, 25 May 2021 10:29:38 -0500<br>From: Andrew Fuerste-Henry <andrew@bywatersolutions.com><br>To: koha-devel <koha-devel@lists.koha-community.org><br>Subject: [Koha-devel] Release of Koha 20.05.12<br>Message-ID:<br> <CANGX5Dw8WE2bPQnvvrHvuEJuGQo4Lvgg-LK_F+=D02kBOE-jWw@mail.gmail.com><br>Content-Type: text/plain; charset="utf-8"<br><br>Hi all!<br><br>The Koha community is pleased to announce the release of Koha 20.05.12!<br>The full release notes can be found here:<br>https://koha-community.org/koha-20-05-12-released/<br><br>Thanks!<br>Andrew<br><br>-- <br>Andrew Fuerste-Henry<br>Educator<br>(he/him/his)<br>ByWater Solutions<br>bywatersolutions.com<br>Phone:(888)900-8944 <(888)%20900-8944><br><br>What is Koha? <http://bywatersolutions.com/what-is-koha/><br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210525/dfd9f8ab/attachment-0001.htm><br><br>------------------------------<br><br>Message: 3<br>Date: Tue, 25 May 2021 17:45:20 +0200<br>From: Victor Grousset/tuxayo <victor@tuxayo.net><br>To: koha-devel <koha-devel@lists.koha-community.org><br>Subject: [Koha-devel] Deadlock issues when running the tests in<br> parallel, and maybe not only in the tests?<br>Message-ID: <b87d154b-1545-65f9-3549-94d9fcd8d164@tuxayo.net><br>Content-Type: text/plain; charset=utf-8; format=flowed<br><br>Hi :)<br><br>IIUC this is where the CI calls "prove" to run the tests<br>https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L213<br><br>And this is the place where KOHA_PROVE_CPUS is set.<br>https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L155<br>It's not set in ".env" file so it should use "nproc" and this calls <br>"prove" with more than one thread.<br><br>Is that really the case? I tried locally use to "prove -j 4" and I'm <br>getting deadlocks with the database after a few minutes.<br><br>And do these deadlock in tests mean that Koha can hit them while running <br>in production?<br><br>I expect the tests to fail due to messing up with each other data but a <br>deadlock is something else.<br><br><br>Cheers,<br><br>-- <br>Victor Grousset/tuxayo<br><br><br>------------------------------<br><br>Message: 4<br>Date: Tue, 25 May 2021 18:54:36 +0300<br>From: Joonas Kylmälä <joonas.kylmala@helsinki.fi><br>To: Victor Grousset/tuxayo <victor@tuxayo.net><br>Cc: koha-devel <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Deadlock issues when running the tests in<br> parallel, and maybe not only in the tests?<br>Message-ID: <bae47af1-fd40-9711-51bd-248837964ada@helsinki.fi><br>Content-Type: text/plain; charset=utf-8<br><br>Hey Victor,<br><br>can you please check whether the $ENV{KOHA_TESTING} variable is set<br>correctly in your CI setup, and if it is not, does it fix the issue?<br>Please see the code in C4::Circulation::SendCirculationAlert(), it is<br>the only place where we do manual db locking as far as I know. It is<br>something we should fix by re-architecturing the message_queue database<br>table for digest messages. However, I'm interested in knowing if the<br>deadlocks now happen because of this and whether it is unit test<br>specific issue because at least based on the comments in<br>SendCirculationAlert() it appears to be so.<br><br>Regards,<br>Joonas<br><br>On 25/05/2021 18:45, Victor Grousset/tuxayo wrote:<br>> Hi :)<br>> <br>> IIUC this is where the CI calls "prove" to run the tests<br>> https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L213<br>> <br>> <br>> And this is the place where KOHA_PROVE_CPUS is set.<br>> https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L155<br>> <br>> It's not set in ".env" file so it should use "nproc" and this calls<br>> "prove" with more than one thread.<br>> <br>> Is that really the case? I tried locally use to "prove -j 4" and I'm<br>> getting deadlocks with the database after a few minutes.<br>> <br>> And do these deadlock in tests mean that Koha can hit them while running<br>> in production?<br>> <br>> I expect the tests to fail due to messing up with each other data but a<br>> deadlock is something else.<br>> <br>> <br>> Cheers,<br>> <br><br>-- <br>Joonas Kylmälä<br>Tietojärjestelmäasiantuntija<br><br>Kansalliskirjasto<br>Kirjastoverkkopalvelut<br>PL 15 (Unioninkatu 36)<br>00014 Helsingin yliopisto<br><br><br>------------------------------<br><br>Message: 5<br>Date: Tue, 25 May 2021 19:00:50 +0300<br>From: Joonas Kylmälä <joonas.kylmala@helsinki.fi><br>To: Victor Grousset/tuxayo <victor@tuxayo.net><br>Cc: koha-devel <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Deadlock issues when running the tests in<br> parallel, and maybe not only in the tests?<br>Message-ID: <f563d919-2ee4-76c4-2b0a-cf164f3f959f@helsinki.fi><br>Content-Type: text/plain; charset=utf-8<br><br>Hmm, based on the line<br>https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L204<br>I would think the ENV variable is actually set so maybe it is not this.<br>Any more info on the tables it locks on?<br><br>Regards,<br>Joonas<br><br>On 25/05/2021 18:54, Joonas Kylmälä wrote:<br>> Hey Victor,<br>> <br>> can you please check whether the $ENV{KOHA_TESTING} variable is set<br>> correctly in your CI setup, and if it is not, does it fix the issue?<br>> Please see the code in C4::Circulation::SendCirculationAlert(), it is<br>> the only place where we do manual db locking as far as I know. It is<br>> something we should fix by re-architecturing the message_queue database<br>> table for digest messages. However, I'm interested in knowing if the<br>> deadlocks now happen because of this and whether it is unit test<br>> specific issue because at least based on the comments in<br>> SendCirculationAlert() it appears to be so.<br>> <br>> Regards,<br>> Joonas<br>> <br>> On 25/05/2021 18:45, Victor Grousset/tuxayo wrote:<br>>> Hi :)<br>>><br>>> IIUC this is where the CI calls "prove" to run the tests<br>>> https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L213<br>>><br>>><br>>> And this is the place where KOHA_PROVE_CPUS is set.<br>>> https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L155<br>>><br>>> It's not set in ".env" file so it should use "nproc" and this calls<br>>> "prove" with more than one thread.<br>>><br>>> Is that really the case? I tried locally use to "prove -j 4" and I'm<br>>> getting deadlocks with the database after a few minutes.<br>>><br>>> And do these deadlock in tests mean that Koha can hit them while running<br>>> in production?<br>>><br>>> I expect the tests to fail due to messing up with each other data but a<br>>> deadlock is something else.<br>>><br>>><br>>> Cheers,<br>>><br>> <br><br>-- <br>Joonas Kylmälä<br>Tietojärjestelmäasiantuntija<br><br>Kansalliskirjasto<br>Kirjastoverkkopalvelut<br>PL 15 (Unioninkatu 36)<br>00014 Helsingin yliopisto<br><br><br>------------------------------<br><br>Message: 6<br>Date: Tue, 25 May 2021 18:05:52 +0200<br>From: Victor Grousset/tuxayo <victor@tuxayo.net><br>To: Joonas Kylmälä <joonas.kylmala@helsinki.fi><br>Cc: koha-devel <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Deadlock issues when running the tests in<br> parallel, and maybe not only in the tests?<br>Message-ID: <d4db783b-ca6c-a942-92e3-d03753839ad8@tuxayo.net><br>Content-Type: text/plain; charset=utf-8; format=flowed<br><br>Hi :)<br><br>On 21-05-25 18:00, Joonas Kylmälä wrote:<br>> Hmm, based on the line<br>> https://gitlab.com/koha-community/koha-testing-docker/-/blob/master/files/run.sh#L204<br>> I would think the ENV variable is actually set so maybe it is not this.<br>> Any more info on the tables it locks on?<br><br>I did yet processed your previous message but here quickly the error <br>messages. Important info, it has been ran on 19.11.x<br><br>t/db_dependent/Charset.t ................................................ ok<br>===( 4190;485 797/? 0/? 17/47 2/15 <br>)============================DBD::mysql::db do failed: Deadlock found <br>when trying to get lock; try restarting transaction [for Statement <br>"DELETE FROM issues"] at t/db_dependent/Circulation/Branch.t line 49.<br>===( 4191;486 797/? 0/? 17/47 3/15 <br>)============================DBD::mysql::db do failed: Deadlock found <br>when trying to get lock; try restarting transaction [for Statement <br>"DELETE FROM items"] at t/db_dependent/Circulation.t line 1174.<br> # No tests run!<br><br># Failed test 'No tests run for subtest <br>"AllowRenewalIfOtherItemsAvailable tests"'<br># at t/db_dependent/Circulation.t line 1269.<br>DBD::mysql::db do failed: Deadlock found when trying to get lock; try <br>restarting transaction [for Statement "DELETE FROM items"] at <br>t/db_dependent/Circulation.t line 1174.<br># Looks like your test exited with 255 just after 18.<br>t/db_dependent/Circulation.t <br>............................................ Dubious, test returned 255 <br>(wstat 65280, 0xff00)<br><br><br><br><br><br><br>-- <br>Victor Grousset/tuxayo<br><br><br>------------------------------<br><br>Subject: Digest Footer<br><br>_______________________________________________<br>Koha-devel mailing list<br>Koha-devel@lists.koha-community.org<br>https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>website : https://www.koha-community.org/<br>git : https://git.koha-community.org/<br>bugs : https://bugs.koha-community.org/<br><br><br>------------------------------<br><br>End of Koha-devel Digest, Vol 186, Issue 19<br>*******************************************<br></div><br><br>NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.<br></body></html>