<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body>A new request with request id 19267 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is : <br><br>Title : Koha-devel Digest, Vol 185, Issue 1<br>Category : <br>Description : <div>Send Koha-devel mailing list submissions to<br> koha-devel@lists.koha-community.org<br><br>To subscribe or unsubscribe via the World Wide Web, visit<br> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>or, via email, send a message with subject or body 'help' to<br> koha-devel-request@lists.koha-community.org<br><br>You can reach the person managing the list at<br> koha-devel-owner@lists.koha-community.org<br><br>When replying, please edit your Subject line so it is more specific<br>than "Re: Contents of Koha-devel digest..."<br><br><br>Today's Topics:<br><br> 1. Re: Bug 28022 - MARC subfield 9 not honoring visibility<br> (Renvoize, Martin)<br> 2. Re: Bug 28022 - MARC subfield 9 not honoring visibility<br> (Thomas Klausner)<br><br><br>----------------------------------------------------------------------<br><br>Message: 1<br>Date: Wed, 31 Mar 2021 14:04:22 +0100<br>From: "Renvoize, Martin" <martin.renvoize@ptfs-europe.com><br>To: koha-devel <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Bug 28022 - MARC subfield 9 not honoring<br> visibility<br>Message-ID:<br> <CAB7SL8DRpE4rnQ4ryw_rOTWSjjFyV=1CS-9Bp=TzSW2VLP8CjQ@mail.gmail.com><br>Content-Type: text/plain; charset="utf-8"<br><br>Hi Thomas,<br><br>Welcome aboard the Koha devs. I'm afraid we don't accept github pull<br>requests at this time. It's come up a few times, but to keep our workflows<br>clear for the largest group of people we've stuck to Bugzilla and mailbox<br>patches so far (They're easy to apply to all our other infrastructure for<br>testing etc).<br><br>Onto the patch itself.<br><br>I've come across this exact case a month or so now.. in fact, I have a<br>vague recollection of pointing it out to someone on IRC recently.. perhaps<br>that was you.<br><br>Your code looks mostly reasonable to me, but I'm also not close enough to<br>how the linking all fits together to know what side effect it might have..<br>:(.<br><br>If you're happy to give git-bz a try as Nicolas suggested, that would give<br>us a head start in terms of onboarding fellow testers and devs.. if not let<br>me know and I can extract your patch from github for you and submit it to<br>BZ.<br><br><br>*Martin Renvoize, MPhys (Hons)*<br><br><https://www.ptfs-europe.com><br><br>Head of Development and Community Engagement<br><br><br><br>*Phone:* +44 (0) 1483 378728<br><br>*Mobile:* +44 (0) 7725 985 636<br><br>*Email:* martin.renvoize@ptfs-europe.com<br><br>www.ptfs-europe.com<br><br><br>*Sign up for our newsletters here <http://eepurl.com/dPjjkn> or by scanning<br>the QR code*<br><br><br><br>Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30<br><br>The information contained in this email message may be privileged,<br>confidential and protected from disclosure. If you are not the intended<br>recipient, any dissemination, distribution or copying is strictly<br>prohibited. If you think that you have received this email message in<br>error, please email the sender at info@ptfs-europe.com<br><br><br>On Tue, 30 Mar 2021 at 08:34, Nicolas Legrand <nicolas.legrand@bulac.fr><br>wrote:<br><br>> Hiya Thomas,<br>><br>> Le mar. 30 mars 2021 à 09:28, Thomas Klausner <domm@plix.at> a écrit :<br>><br>>> Hi!<br>>><br>>> Can anybody here maybe review / comment on my bug report & patch 28022<br>>> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022<br>>><br>>><br>>> Here's the patch:<br>>><br>>> https://github.com/domm/Koha/commit/d19abcc23d5793becdd5edca26c4bd2d47fcd33f<br>><br>><br>> Here is the doc explaining how to submit a patch for Koha :<br>><br>> https://wiki.koha-community.org/wiki/Git_bz_configuration<br>><br>> You have to install a utility (git bz) that uploads your patches to<br>> Bugzilla. Then other people will be able to test, comment or sign your<br>> patch, also using git bz.<br>><br>> Regards,<br>><br>> --<br>> Nicolas<br>> _______________________________________________<br>> Koha-devel mailing list<br>> Koha-devel@lists.koha-community.org<br>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>> website : https://www.koha-community.org/<br>> git : https://git.koha-community.org/<br>> bugs : https://bugs.koha-community.org/<br>><br>-------------- next part --------------<br>An HTML attachment was scrubbed...<br>URL: <http://lists.koha-community.org/pipermail/koha-devel/attachments/20210331/d6074da8/attachment-0001.htm><br><br>------------------------------<br><br>Message: 2<br>Date: Wed, 31 Mar 2021 16:59:43 +0200<br>From: Thomas Klausner <domm@plix.at><br>To: koha-devel@lists.koha-community.org<br>Subject: Re: [Koha-devel] Bug 28022 - MARC subfield 9 not honoring<br> visibility<br>Message-ID: <YGSOX8bI/UJXa7iO@plix.at><br>Content-Type: text/plain; charset=us-ascii<br><br>Hi!<br><br>On Wed, Mar 31, 2021 at 02:04:22PM +0100, Renvoize, Martin wrote:<br> <br>> If you're happy to give git-bz a try as Nicolas suggested, that would give<br>> us a head start in terms of onboarding fellow testers and devs.. if not let<br>> me know and I can extract your patch from github for you and submit it to<br>> BZ.<br><br>ok, I'll do that (in the next few days, modulo Easter and the current <br>Corona lockdown..)<br><br>Thanks for the feedback,<br>Thomas<br><br>-- <br>#!/usr/bin/perl http://domm.plix.at<br>for(ref bless{},just'another'perl'hacker){s-:+-$"-g&&print$_.$/}<br><br><br>------------------------------<br><br>Subject: Digest Footer<br><br>_______________________________________________<br>Koha-devel mailing list<br>Koha-devel@lists.koha-community.org<br>https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>website : https://www.koha-community.org/<br>git : https://git.koha-community.org/<br>bugs : https://bugs.koha-community.org/<br><br><br>------------------------------<br><br>End of Koha-devel Digest, Vol 185, Issue 1<br>******************************************<br></div><br><br>NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.<br></body></html>