<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body>A new request with request id 19242 has been created by koha-devel-request@lists.koha-community.org. Short info on the request is : <br><br>Title : Koha-devel Digest, Vol 184, Issue 25<br>Category : <br>Description : <div>Send Koha-devel mailing list submissions to<br> koha-devel@lists.koha-community.org<br><br>To subscribe or unsubscribe via the World Wide Web, visit<br> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>or, via email, send a message with subject or body 'help' to<br> koha-devel-request@lists.koha-community.org<br><br>You can reach the person managing the list at<br> koha-devel-owner@lists.koha-community.org<br><br>When replying, please edit your Subject line so it is more specific<br>than "Re: Contents of Koha-devel digest..."<br><br><br>Today's Topics:<br><br> 1. Re: Second look needed on a few (2!) lines related to plugins<br> (Victor Grousset/tuxayo)<br> 2. Re: Second look needed on a few (2!) lines related to plugins<br> (dcook@prosentient.com.au)<br> 3. Re: Switching from SysV to Systemd for koha-common service<br> (dcook@prosentient.com.au)<br><br><br>----------------------------------------------------------------------<br><br>Message: 1<br>Date: Tue, 30 Mar 2021 17:48:43 +0200<br>From: Victor Grousset/tuxayo <victor@tuxayo.net><br>To: Mason James <mtj@kohaaloha.com>, koha-devel<br> <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Second look needed on a few (2!) lines<br> related to plugins<br>Message-ID: <44ddc466-06b9-8915-f3cd-e8a420eb465c@tuxayo.net><br>Content-Type: text/plain; charset=utf-8; format=flowed<br><br>On 21-03-30 01:31, Mason James wrote:<br>> hiya, here's some info...<br>> <br>> https://docstore.mik.ua/orelly/perl3/prog/ch03_16.htm<br><br>Indeed there is a trinary, but it's about if it makes sense to do "those <br>things" related to plugins. Is that useful, is that valid, is that enough?<br><br>Cheers,<br><br>-- <br>Victor Grousset/tuxayo<br><br><br>------------------------------<br><br>Message: 2<br>Date: Wed, 31 Mar 2021 09:20:05 +1100<br>From: <dcook@prosentient.com.au><br>To: "'Fridolin SOMERS'" <fridolin.somers@biblibre.com>,<br> <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Second look needed on a few (2!) lines<br> related to plugins<br>Message-ID: <02d401d725b2$d6242b60$826c8220$@prosentient.com.au><br>Content-Type: text/plain; charset="utf-8"<br><br>I wrote the patch close to a year ago so I have no idea why I used the syntax that I did. I think maybe I was copying what was already there for the search feature at the time.<br><br>But I'm happy for people to change it! <br><br>And thanks for the compliment. I do like this feature!<br><br>David Cook<br>Software Engineer<br>Prosentient Systems<br>Suite 7.03<br>6a Glen St<br>Milsons Point NSW 2061<br>Australia<br><br>Office: 02 9212 0899<br>Online: 02 8005 0595<br><br>-----Original Message-----<br>From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Fridolin SOMERS<br>Sent: Tuesday, 30 March 2021 6:08 PM<br>To: koha-devel@lists.koha-community.org<br>Subject: Re: [Koha-devel] Second look needed on a few (2!) lines related to plugins<br><br>Hi,<br><br>In my opinion this syntax looks strange.<br>I'd prefer :<br> my $filter = { uploadcategorycode => $browsecategory };<br> $filter{public} = 1 if $plugin;<br> $uploads = Koha::UploadedFiles->search($filter)->unblessed;<br><br>Super cool enhancement BTW ;)<br><br>Best regards,<br><br>Le 29/03/2021 à 18:25, Victor Grousset/tuxayo a écrit :<br>> Hi :)<br>> <br>> It's about Bug 25476 - Uploaded files can't be easily browsed via <br>> upload.pl<br>> <br>> There are two lines in the patch that are out of my knowledge to QA:<br>> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6<br>> <br>> [% PROCESS plugin_pars %]<br>> [...]<br>> $plugin? ( public => 1 ): ()<br>> <br>> Does this look familiar to anyone?<br>> <br>> Cheers,<br>> <br><br>--<br>Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄<br>BibLibre, France<br>_______________________________________________<br>Koha-devel mailing list<br>Koha-devel@lists.koha-community.org<br>https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/<br><br><br><br><br>------------------------------<br><br>Message: 3<br>Date: Wed, 31 Mar 2021 09:35:22 +1100<br>From: <dcook@prosentient.com.au><br>To: "'Fridolin SOMERS'" <fridolin.somers@biblibre.com>,<br> <koha-devel@lists.koha-community.org><br>Subject: Re: [Koha-devel] Switching from SysV to Systemd for<br> koha-common service<br>Message-ID: <02d501d725b4$f8abd230$ea037690$@prosentient.com.au><br>Content-Type: text/plain; charset="utf-8"<br><br>Hi Frido,<br><br>You only have 1 Koha per server? That's amazing.<br><br>I agree about using %i. With the koha-worker systemd service, we've done that. (Bug 26363 and 27844)<br><br>I suppose the way to make a global koha-common would be to have individual systemd units for each of the individual services and then have koha-common as the parent service. I manage a different system where I control a few daemons via a parent systemd service and it works quite well. <br><br>The only thing with that is that we'd have to re-write everything to use systemd heh. Not that I'm opposed to that, although - as Tomas noted - it would make things tougher to do in containers in the short-term. <br><br>Sometimes, I wish that I had all the time and money to make these things happen. I am extra short on time at the moment, so no plans to work on this any time soon.<br><br>David Cook<br>Software Engineer<br>Prosentient Systems<br>Suite 7.03<br>6a Glen St<br>Milsons Point NSW 2061<br>Australia<br><br>Office: 02 9212 0899<br>Online: 02 8005 0595<br><br>-----Original Message-----<br>From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Fridolin SOMERS<br>Sent: Tuesday, 30 March 2021 7:08 PM<br>To: koha-devel@lists.koha-community.org<br>Subject: Re: [Koha-devel] Switching from SysV to Systemd for koha-common service<br><br>Hi,<br><br>Very good idea :D<br><br>We at Biblibre have build a systemd unit for Starman and Zebra, it is quite simple. But we dont use several Koha.<br><br>In ordre to implement for several Koha, I think we should use %i vars in systemd unit.<br>Like it is in openvpn :<br>https://github.com/OpenVPN/openvpn/blob/master/distro/systemd/openvpn-client%40.service.in<br><br>It allows to call any unit (for example demo Koha) :<br>systemctl start koha-common@demo.<br><br>About restart :<br>I see you can define a different kill signal than stop :<br>https://www.freedesktop.org/software/systemd/man/systemd.kill.html#RestartKillSignal=<br><br>But you may use "reload" action instead :<br>https://www.freedesktop.org/software/systemd/man/systemd.service.html#ExecReload=<br><br>We use reload for starman it is more soft (it acts like apache gracefull restart).<br><br>I attach some files here :<br>https://git.biblibre.com/biblibre/koha-nginx/src/branch/master/etc/systemd/system<br><br>Feel free to ask for help.<br><br>Best regards,<br><br>Le 25/03/2021 à 04:42, dcook@prosentient.com.au a écrit :<br>> Hi all,<br>> <br>> I was just installing koha-common, as you do, and I noticed the <br>> following warning:<br>> <br>> Failed to enable unit: Unit<br>> /run/systemd/generator.late/koha-common.service is transient or generated.<br>> <br>> This is the product of the following command: “update-rc.d koha-common <br>> enable”<br>> <br>> I think I was able to work around it by running the following: <br>> “/lib/systemd/systemd-sysv-install enable koha-common”<br>> <br>> However, I’m thinking it is probably time to switch koha-common from <br>> SysV to Systemd. We’ll lose a bit of functionality for the “status”<br>> option, but otherwise it shouldn’t be too bad. I think we’ll lose the <br>> “restart” as well as I think the systemd restart is a “stop” and “start”.<br>> <br>> David Cook<br>> <br>> Software Engineer<br>> <br>> Prosentient Systems<br>> <br>> Suite 7.03<br>> <br>> 6a Glen St<br>> <br>> Milsons Point NSW 2061<br>> <br>> Australia<br>> <br>> Office: 02 9212 0899<br>> <br>> Online: 02 8005 0595<br>> <br>> <br>> _______________________________________________<br>> Koha-devel mailing list<br>> Koha-devel@lists.koha-community.org<br>> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>> website : https://www.koha-community.org/ git : <br>> https://git.koha-community.org/ bugs : <br>> https://bugs.koha-community.org/<br>> <br><br>--<br>Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄<br>BibLibre, France<br>_______________________________________________<br>Koha-devel mailing list<br>Koha-devel@lists.koha-community.org<br>https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/<br><br><br><br><br>------------------------------<br><br>Subject: Digest Footer<br><br>_______________________________________________<br>Koha-devel mailing list<br>Koha-devel@lists.koha-community.org<br>https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel<br>website : https://www.koha-community.org/<br>git : https://git.koha-community.org/<br>bugs : https://bugs.koha-community.org/<br><br><br>------------------------------<br><br>End of Koha-devel Digest, Vol 184, Issue 25<br>*******************************************<br></div><br><br>NOTE: You are receiving this mail because, the Requester/Technician wanted you to get notified on this request creation.<br></body></html>