[Koha-patches] [PATCH] Replace TMPL_ELSIF with TMPL_ELSE and TMPL_IF in label-manager.tmpl;
Joe Atzberger
joe.atzberger at liblime.com
Tue Jul 29 15:55:06 CEST 2008
On Tue, Jul 29, 2008 at 7:37 AM, MJ Ray <mjr at phonecoop.coop> wrote:
> "Joe Atzberger" <joe.atzberger at liblime.com> wrote:
> > On Mon, Jul 28, 2008 at 1:18 PM, MJ Ray <mjr at phonecoop.coop> wrote:
> > > It doesn't seem to work reliably on one of my Koha 3 systems.
> > > TMPL_ELSIF appears to be a fairly recent HTML::Template::Pro-ism so it
> > > limits portability and there's a big WARNING on perldoc
> > > HTML::Template::SYNTAX, so it seemed like a good idea to remove it.
> > > What's the problem?
> >
> > HTML::Template warns because ELSIF is part of HTML::Template::Pro.
>
> HTML::Template::SYNTAX is part of HTML::Template::Pro.
Yes, and what that syntax says is that ELSIF is part of Pro. That's the
connection. The warning you cited does not apply to us.
> We use only HTML::Template::Pro, so there is no reason to avoid ELSIF's.
> No
> > problems have been reported upgrading H:T:P on any exising Koha system.
>
> Consider this the first, then!
> http://rt.cpan.org/Ticket/Display.html?id=38013
>
Not sure what else might be problematic in that MacOS installation of perl.
If I read your report correctly, it looks like HTML::Template::Expr is
actually the component that failed.
You seem to have version 5.8.8 on OS 10.5.x. I only have 5.8.6 on 10.4.11
on my MacBook, for what it's worth, but H:T:P installed cleanly on this
one. My H:T:Expr version is 0.07. Log for comparison:
http://pastebin.com/m7bce216c
--Joe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20080729/c464e170/attachment-0002.htm>
More information about the Koha-patches
mailing list