[Koha-patches] [PATCH] C4::Context::import reloaded

[Joe Atzberger]

Yeah, we just discusses this here a week or two ago in detail, with the
conclusion that Context should use INIT rather than slyly redefine import.
So this patch looks ok, but that whole sub should still be going away
whenever we can get to it.

--Joe

On Wed, Jul 30, 2008 at 3:10 PM, Andrew Moore <andrew.moore at liblime.com>wrote:

> Hi -
>
> Just a second opinion since this patch hits the confusing and
> important C4::Context module.
>
> I applied this patch, ran the test suite on it, did a few searches in
> the opac and staff client, and ran a cronjob. It appears to work fine.
> So, I think it's OK to apply in my opinion.
>
> By eye, it does look like it will help, but I don't really know enough
> about how C4::Context works or should work best to be able to comment
> if it's the best way to improve it or not.
>
> Anyway, I resent it along with my signoff.
>
> -Andy
>
>
> On Wed, Jul 30, 2008 at 2:06 PM, Andrew Moore <andrew.moore at liblime.com>
> wrote:
> > From: Marc Chantreux <marc.chantreux at biblibre.com>
> >
> > the problem was a context was stored every time C4::Context was called.
> >
> > Signed-off-by: Andrew Moore <andrew.moore at liblime.com>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20080730/80dc3d0f/attachment-0002.htm>