[Koha-patches] [PATCH] bug 2825: improving readability of output messages in updatedatabase.pl

Andrew Moore andrew.moore at liblime.com
Wed Nov 26 20:22:50 CET 2008


Two recent changes to updatedatabase.pl don't include newlines at the
end of their status messages. This patch adds them. This is only useful
if you're running this from the command line.

Note: there is an opportunity here to extract some of the simlar logic
from each of these blocks to a function.
---
 installer/data/mysql/updatedatabase.pl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
index 03e13c3..2fc8634 100755
--- a/installer/data/mysql/updatedatabase.pl
+++ b/installer/data/mysql/updatedatabase.pl
@@ -1993,7 +1993,7 @@ if ( C4::Context->preference('Version') < TransformToNum($DBversion) ) {
             ADD item_level_request tinyint(4) NOT NULL default 0
     ");
 
-    print "Upgrade to $DBversion done (add hold_fill_targets table and a column to tmp_holdsqueue)";
+    print "Upgrade to $DBversion done (add hold_fill_targets table and a column to tmp_holdsqueue)\n";
     SetVersion($DBversion);
 }
 
@@ -2029,7 +2029,7 @@ if ( C4::Context->preference('Version') < TransformToNum($DBversion) ) {
         print STDERR "After the upgrade to $DBversion, there are still $num_bad_issuedates loan(s) with a NULL (blank) loan date. ",
                      "Please check the issues table in your database.";
     }
-    print "Upgrade to $DBversion done (bug 2582: set null issues.issuedate to lastreneweddate)";
+    print "Upgrade to $DBversion done (bug 2582: set null issues.issuedate to lastreneweddate)\n";
     SetVersion($DBversion);
 }
 
-- 
1.5.6




More information about the Koha-patches mailing list