[Koha-patches] [PATCH] Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591

[Galen Charlton]

Hi,

Patch pushed, but with reservations: suppressing the enter key in all
fields in the patron and item forms may be casting the net too wide;
an operator who is used to hitting enter now has to reach for the
mouse.

Regards,

Galen

On Mon, Sep 15, 2008 at 12:33 PM, Owen Leonard <oleonard at myacpl.org> wrote:
> ---
>  koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js |   20 +++++++++++++++++++-
>  .../prog/en/modules/cataloguing/additem.tmpl       |    3 +++
>  .../prog/en/modules/members/memberentrygen.tmpl    |    1 +
>  3 files changed, 23 insertions(+), 1 deletions(-)
>
> diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js
> index ddbc3ce..30855ef 100644
> --- a/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js
> +++ b/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js
> @@ -70,4 +70,22 @@ YAHOO.util.Event.onContentReady("changelanguage", function () {
>                                YAHOO.util.Event.addListener("showlang", "click", onYahooClick);
>
>                                YAHOO.widget.Overlay.windowResizeEvent.subscribe(positionoMenu);
> -            });
> \ No newline at end of file
> +            });
> +
> +// http://jennifermadden.com/javascript/stringEnterKeyDetector.html
> +function checkEnter(e){ //e is event object passed from function invocation
> +       var characterCode; // literal character code will be stored in this variable
> +       if(e && e.which){ //if which property of event object is supported (NN4)
> +               e = e;
> +               characterCode = e.which; //character code is contained in NN4's which property
> +       } else {
> +               e = event;
> +               characterCode = e.keyCode; //character code is contained in IE's keyCode property
> +       }
> +
> +       if(characterCode == 13){ //if generated character code is equal to ascii 13 (if enter key)
> +               return false;
> +       } else {
> +               return true;
> +       }
> +}
> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tmpl
> index 3f48ac2..03ec860 100644
> --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tmpl
> +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tmpl
> @@ -3,6 +3,9 @@
>  <!-- TMPL_INCLUDE NAME="doc-head-close.inc" -->
>  <script type="text/javascript">
>  //<![CDATA[
> +$(document).ready(function(){
> +               $("fieldset.rows input").keydown(function(e){ return checkEnter(e); });
> +});
>  function active(numlayer)
>  {
>     for (i=10; i < 11 ; i++ ) {
> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tmpl
> index 98566f6..6d5a959 100644
> --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tmpl
> +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tmpl
> @@ -7,6 +7,7 @@
>  <script type="text/JavaScript" language="JavaScript">
>  //<![CDATA[
>     $(document).ready(function() {
> +               $("fieldset.rows input").keydown(function(e){ return checkEnter(e); });
>         $("#guarantordelete").click(function() {
>             $("#contact-details").hide().find('a').remove();
>             $("#guarantorid, #contactname, #contactfirstname").each(function () { this.value = "" });
> --
> 1.5.5.GIT
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>



-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt