[Koha-patches] [PATCH] bug 2615: remove unneeded 'require Exporter'
Galen Charlton
galen.charlton at liblime.com
Wed Sep 17 14:07:51 CEST 2008
Most Perl scripts (as opposed to modules) do
not need to require Exporter.
No user-visible or documentation changes.
---
about.pl | 1 -
acqui/newordersuggestion.pl | 2 +-
authorities/auth_finder.pl | 2 +-
authorities/authorities-home.pl | 2 +-
authorities/blinddetail-biblio-search.pl | 2 +-
authorities/detail-biblio-search.pl | 2 +-
authorities/detail.pl | 2 +-
catalogue/ISBDdetail.pl | 2 +-
catalogue/MARCdetail.pl | 2 +-
catalogue/cardview.pl | 2 +-
catalogue/detail.pl | 2 +-
catalogue/detailprint.pl | 2 +-
catalogue/export.pl | 2 +-
catalogue/issuehistory.pl | 2 +-
catalogue/suggest.pl | 2 +-
cataloguing/value_builder/barcode.pl | 2 +-
cataloguing/value_builder/dateaccessioned.pl | 2 +-
cataloguing/value_builder/labs_theses.pl | 2 +-
cataloguing/value_builder/marc21_field_003.pl | 2 +-
cataloguing/value_builder/marc21_field_005.pl | 2 +-
cataloguing/value_builder/marc21_field_040c.pl | 2 +-
cataloguing/value_builder/marc21_field_040d.pl | 2 +-
cataloguing/value_builder/unimarc_field_210c.pl | 2 +-
cataloguing/value_builder/unimarc_field_4XX.pl | 2 +-
mainpage.pl | 1 -
misc/exportauth.pl | 2 +-
opac/maintenance.pl | 1 -
opac/opac-ISBDdetail.pl | 1 -
opac/opac-MARCdetail.pl | 1 -
opac/opac-authorities-home.pl | 2 +-
opac/opac-authoritiesdetail.pl | 1 -
opac/opac-basket.pl | 1 -
opac/opac-browser.pl | 1 -
opac/opac-detail.pl | 2 +-
opac/opac-detailprint.pl | 1 -
opac/opac-export.pl | 2 +-
opac/opac-main.pl | 1 -
opac/opac-messaging.pl | 2 +-
opac/opac-mymessages.pl | 2 +-
opac/opac-passwd.pl | 2 +-
opac/opac-readingrecord.pl | 2 +-
opac/opac-sendbasket.pl | 2 +-
opac/opac-showreviews.pl | 2 +-
opac/opac-suggestions.pl | 2 +-
opac/opac-user.pl | 2 +-
opac/opac-userupdate.pl | 2 +-
opac/sco/sco-main.pl | 2 +-
serials/subscription-bib-search.pl | 2 +-
serials/subscription-renew.pl | 2 +-
suggestion/acceptorreject.pl | 2 +-
tools/export.pl | 2 +-
tools/pdfViewer.pl | 2 +-
52 files changed, 42 insertions(+), 52 deletions(-)
diff --git a/about.pl b/about.pl
index 0c47aa0..7fb2efc 100755
--- a/about.pl
+++ b/about.pl
@@ -16,7 +16,6 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
use C4::Output; # contains gettemplate
use C4::Auth;
diff --git a/acqui/newordersuggestion.pl b/acqui/newordersuggestion.pl
index ee7bb94..e56e521 100755
--- a/acqui/newordersuggestion.pl
+++ b/acqui/newordersuggestion.pl
@@ -87,7 +87,7 @@ can be equal to
=cut
use strict;
-require Exporter;
+
use CGI;
use C4::Auth; # get_template_and_user
use C4::Output;
diff --git a/authorities/auth_finder.pl b/authorities/auth_finder.pl
index 49bb0b5..fef6cbf 100755
--- a/authorities/auth_finder.pl
+++ b/authorities/auth_finder.pl
@@ -19,7 +19,7 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
+
use CGI;
use C4::Output;
use C4::Auth;
diff --git a/authorities/authorities-home.pl b/authorities/authorities-home.pl
index 428954c..d80acc4 100755
--- a/authorities/authorities-home.pl
+++ b/authorities/authorities-home.pl
@@ -18,7 +18,7 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
+
use CGI;
use C4::Auth;
diff --git a/authorities/blinddetail-biblio-search.pl b/authorities/blinddetail-biblio-search.pl
index afbb16b..b137f50 100755
--- a/authorities/blinddetail-biblio-search.pl
+++ b/authorities/blinddetail-biblio-search.pl
@@ -38,7 +38,7 @@ parameters tables.
=cut
use strict;
-require Exporter;
+
use C4::AuthoritiesMarc;
use C4::Auth;
use C4::Context;
diff --git a/authorities/detail-biblio-search.pl b/authorities/detail-biblio-search.pl
index 07ba283..204dd57 100755
--- a/authorities/detail-biblio-search.pl
+++ b/authorities/detail-biblio-search.pl
@@ -39,7 +39,7 @@ parameters tables.
use strict;
-require Exporter;
+
use C4::AuthoritiesMarc;
use C4::Auth;
use C4::Context;
diff --git a/authorities/detail.pl b/authorities/detail.pl
index 5a2456b..9096d1c 100755
--- a/authorities/detail.pl
+++ b/authorities/detail.pl
@@ -39,7 +39,7 @@ parameters tables.
use strict;
-require Exporter;
+
use C4::AuthoritiesMarc;
use C4::Auth;
use C4::Context;
diff --git a/catalogue/ISBDdetail.pl b/catalogue/ISBDdetail.pl
index 66a98ef..250fda6 100755
--- a/catalogue/ISBDdetail.pl
+++ b/catalogue/ISBDdetail.pl
@@ -35,7 +35,7 @@ This script needs a biblionumber as parameter
=cut
use strict;
-require Exporter;
+
use C4::Auth;
use C4::Context;
use C4::Output;
diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl
index d10d4ba..12c6544 100755
--- a/catalogue/MARCdetail.pl
+++ b/catalogue/MARCdetail.pl
@@ -44,7 +44,7 @@ the items attached to the biblio
=cut
use strict;
-require Exporter;
+
use C4::Auth;
use C4::Context;
use C4::Output;
diff --git a/catalogue/cardview.pl b/catalogue/cardview.pl
index e7622da..a88d296 100755
--- a/catalogue/cardview.pl
+++ b/catalogue/cardview.pl
@@ -1,6 +1,6 @@
#!/usr/bin/perl
use strict;
-require Exporter;
+
use CGI;
use XML::LibXSLT;
use XML::LibXML;
diff --git a/catalogue/detail.pl b/catalogue/detail.pl
index d6e4000..8bef7e3 100755
--- a/catalogue/detail.pl
+++ b/catalogue/detail.pl
@@ -17,7 +17,7 @@
use strict;
-require Exporter;
+
use CGI;
use C4::Auth;
use C4::Dates qw/format_date/;
diff --git a/catalogue/detailprint.pl b/catalogue/detailprint.pl
index 00c0863..b36a962 100755
--- a/catalogue/detailprint.pl
+++ b/catalogue/detailprint.pl
@@ -18,7 +18,7 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
+
use C4::Context;
use CGI;
use C4::Auth;
diff --git a/catalogue/export.pl b/catalogue/export.pl
index 758afd3..0093ce0 100755
--- a/catalogue/export.pl
+++ b/catalogue/export.pl
@@ -1,7 +1,7 @@
#!/usr/bin/perl
use HTML::Template::Pro;
use strict;
-require Exporter;
+
use C4::Record;
use C4::Auth;
use C4::Output;
diff --git a/catalogue/issuehistory.pl b/catalogue/issuehistory.pl
index 6e7e107..37b52ae 100755
--- a/catalogue/issuehistory.pl
+++ b/catalogue/issuehistory.pl
@@ -17,7 +17,7 @@
use strict;
-require Exporter;
+
use CGI;
use C4::Auth;
use C4::Output;
diff --git a/catalogue/suggest.pl b/catalogue/suggest.pl
index b9373d5..9463f85 100755
--- a/catalogue/suggest.pl
+++ b/catalogue/suggest.pl
@@ -19,7 +19,7 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
+
use CGI;
use C4::Auth;
diff --git a/cataloguing/value_builder/barcode.pl b/cataloguing/value_builder/barcode.pl
index 21fd1ec..cfa3b15 100755
--- a/cataloguing/value_builder/barcode.pl
+++ b/cataloguing/value_builder/barcode.pl
@@ -19,7 +19,7 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
-require Exporter;
+
use C4::Context;
my $DEBUG = 0;
diff --git a/cataloguing/value_builder/dateaccessioned.pl b/cataloguing/value_builder/dateaccessioned.pl
index 185a9b1..19f7227 100755
--- a/cataloguing/value_builder/dateaccessioned.pl
+++ b/cataloguing/value_builder/dateaccessioned.pl
@@ -19,7 +19,7 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
-require Exporter;
+
=head1
diff --git a/cataloguing/value_builder/labs_theses.pl b/cataloguing/value_builder/labs_theses.pl
index 4497461..382c763 100755
--- a/cataloguing/value_builder/labs_theses.pl
+++ b/cataloguing/value_builder/labs_theses.pl
@@ -18,7 +18,7 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
+
use CGI;
use C4::Output;
diff --git a/cataloguing/value_builder/marc21_field_003.pl b/cataloguing/value_builder/marc21_field_003.pl
index 5d7a7ef..e18b9b9 100755
--- a/cataloguing/value_builder/marc21_field_003.pl
+++ b/cataloguing/value_builder/marc21_field_003.pl
@@ -18,7 +18,7 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
-require Exporter;
+
use C4::Auth;
use C4::Context;
use C4::Output;
diff --git a/cataloguing/value_builder/marc21_field_005.pl b/cataloguing/value_builder/marc21_field_005.pl
index eb3dfa6..23308d8 100755
--- a/cataloguing/value_builder/marc21_field_005.pl
+++ b/cataloguing/value_builder/marc21_field_005.pl
@@ -18,7 +18,7 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
-require Exporter;
+
use C4::Auth;
use C4::Context;
use C4::Output;
diff --git a/cataloguing/value_builder/marc21_field_040c.pl b/cataloguing/value_builder/marc21_field_040c.pl
index 417af78..667d0ae 100755
--- a/cataloguing/value_builder/marc21_field_040c.pl
+++ b/cataloguing/value_builder/marc21_field_040c.pl
@@ -18,7 +18,7 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
-require Exporter;
+
use C4::AuthoritiesMarc;
use C4::Auth;
use C4::Context;
diff --git a/cataloguing/value_builder/marc21_field_040d.pl b/cataloguing/value_builder/marc21_field_040d.pl
index 417af78..667d0ae 100755
--- a/cataloguing/value_builder/marc21_field_040d.pl
+++ b/cataloguing/value_builder/marc21_field_040d.pl
@@ -18,7 +18,7 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
-require Exporter;
+
use C4::AuthoritiesMarc;
use C4::Auth;
use C4::Context;
diff --git a/cataloguing/value_builder/unimarc_field_210c.pl b/cataloguing/value_builder/unimarc_field_210c.pl
index 64c243f..27ced19 100755
--- a/cataloguing/value_builder/unimarc_field_210c.pl
+++ b/cataloguing/value_builder/unimarc_field_210c.pl
@@ -18,7 +18,7 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
-require Exporter;
+
use C4::AuthoritiesMarc;
use C4::Auth;
use C4::Context;
diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl
index f317bb7..b97f27b 100755
--- a/cataloguing/value_builder/unimarc_field_4XX.pl
+++ b/cataloguing/value_builder/unimarc_field_4XX.pl
@@ -19,7 +19,7 @@
use strict;
-require Exporter;
+
use CGI;
use C4::Output;
use C4::Context;
diff --git a/mainpage.pl b/mainpage.pl
index fa5e814..8116eeb 100755
--- a/mainpage.pl
+++ b/mainpage.pl
@@ -17,7 +17,6 @@
#
use strict;
-require Exporter;
use CGI;
use C4::Output;
diff --git a/misc/exportauth.pl b/misc/exportauth.pl
index 31abe29..52a0ec8 100755
--- a/misc/exportauth.pl
+++ b/misc/exportauth.pl
@@ -10,7 +10,7 @@ BEGIN {
use FindBin;
eval { require "$FindBin::Bin/kohalib.pl" };
}
-require Exporter;
+
use C4::Context;
use C4::Output; # contains gettemplate
use C4::Biblio;
diff --git a/opac/maintenance.pl b/opac/maintenance.pl
index 22698a6..49b7491 100755
--- a/opac/maintenance.pl
+++ b/opac/maintenance.pl
@@ -17,7 +17,6 @@
use strict;
-require Exporter;
use CGI;
use C4::Auth;
use C4::Output;
diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl
index bbb0427..6767922 100755
--- a/opac/opac-ISBDdetail.pl
+++ b/opac/opac-ISBDdetail.pl
@@ -42,7 +42,6 @@ the items attached to the biblio
=cut
use strict;
-require Exporter;
use C4::Auth;
use C4::Context;
use C4::Output;
diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl
index a1ecb99..c384569 100755
--- a/opac/opac-MARCdetail.pl
+++ b/opac/opac-MARCdetail.pl
@@ -40,7 +40,6 @@ the items attached to the biblio
=cut
use strict;
-require Exporter;
use C4::Auth;
use C4::Context;
use C4::Output;
diff --git a/opac/opac-authorities-home.pl b/opac/opac-authorities-home.pl
index ec6b579..06ad711 100755
--- a/opac/opac-authorities-home.pl
+++ b/opac/opac-authorities-home.pl
@@ -19,7 +19,7 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
+
use CGI;
use C4::Auth;
diff --git a/opac/opac-authoritiesdetail.pl b/opac/opac-authoritiesdetail.pl
index 40e2d6b..430f0f2 100755
--- a/opac/opac-authoritiesdetail.pl
+++ b/opac/opac-authoritiesdetail.pl
@@ -38,7 +38,6 @@ parameters tables.
=cut
use strict;
-require Exporter;
use C4::AuthoritiesMarc;
use C4::Auth;
use C4::Context;
diff --git a/opac/opac-basket.pl b/opac/opac-basket.pl
index 7b52178..399e666 100755
--- a/opac/opac-basket.pl
+++ b/opac/opac-basket.pl
@@ -17,7 +17,6 @@
use strict;
-require Exporter;
use CGI;
use C4::Koha;
use C4::Biblio;
diff --git a/opac/opac-browser.pl b/opac/opac-browser.pl
index 360dcd9..f1d98f0 100755
--- a/opac/opac-browser.pl
+++ b/opac/opac-browser.pl
@@ -25,7 +25,6 @@ TODO :: Description here
=cut
use strict;
-require Exporter;
use C4::Auth;
use C4::Context;
use C4::Output;
diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
index 149209c..314dbe0 100755
--- a/opac/opac-detail.pl
+++ b/opac/opac-detail.pl
@@ -19,7 +19,7 @@
use strict;
-require Exporter;
+
use CGI;
use C4::Auth;
use C4::Branch;
diff --git a/opac/opac-detailprint.pl b/opac/opac-detailprint.pl
index d420bd9..8d11cfc 100755
--- a/opac/opac-detailprint.pl
+++ b/opac/opac-detailprint.pl
@@ -19,7 +19,6 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
use C4::Context;
use CGI;
use C4::Biblio;
diff --git a/opac/opac-export.pl b/opac/opac-export.pl
index 758afd3..0093ce0 100755
--- a/opac/opac-export.pl
+++ b/opac/opac-export.pl
@@ -1,7 +1,7 @@
#!/usr/bin/perl
use HTML::Template::Pro;
use strict;
-require Exporter;
+
use C4::Record;
use C4::Auth;
use C4::Output;
diff --git a/opac/opac-main.pl b/opac/opac-main.pl
index 1bce420..1062109 100755
--- a/opac/opac-main.pl
+++ b/opac/opac-main.pl
@@ -17,7 +17,6 @@
use strict;
-require Exporter;
use CGI;
use C4::Auth; # get_template_and_user
use C4::Output;
diff --git a/opac/opac-messaging.pl b/opac/opac-messaging.pl
index b7ecac0..86da193 100755
--- a/opac/opac-messaging.pl
+++ b/opac/opac-messaging.pl
@@ -19,7 +19,7 @@
use strict;
use warnings;
-require Exporter;
+
use CGI;
use C4::Auth; # checkauth, getborrowernumber.
diff --git a/opac/opac-mymessages.pl b/opac/opac-mymessages.pl
index 3cfd4fc..80013d5 100755
--- a/opac/opac-mymessages.pl
+++ b/opac/opac-mymessages.pl
@@ -17,7 +17,7 @@
use strict;
use warnings;
-require Exporter;
+
use CGI;
use C4::Auth;
diff --git a/opac/opac-passwd.pl b/opac/opac-passwd.pl
index a4f27df..491cce0 100755
--- a/opac/opac-passwd.pl
+++ b/opac/opac-passwd.pl
@@ -19,7 +19,7 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
+
use CGI;
use C4::Auth; # checkauth, getborrowernumber.
diff --git a/opac/opac-readingrecord.pl b/opac/opac-readingrecord.pl
index 648532b..489e64b 100755
--- a/opac/opac-readingrecord.pl
+++ b/opac/opac-readingrecord.pl
@@ -17,7 +17,7 @@
use strict;
-require Exporter;
+
use CGI;
use C4::Auth;
diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl
index 79b5f46..efa4ea5 100755
--- a/opac/opac-sendbasket.pl
+++ b/opac/opac-sendbasket.pl
@@ -16,7 +16,7 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
+
use CGI;
use Mail::Sendmail;
use MIME::QuotedPrint;
diff --git a/opac/opac-showreviews.pl b/opac/opac-showreviews.pl
index e9ce121..d4eaa93 100755
--- a/opac/opac-showreviews.pl
+++ b/opac/opac-showreviews.pl
@@ -16,7 +16,7 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
+
use CGI;
use C4::Auth;
use C4::Koha;
diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl
index e1535f5..4001694 100755
--- a/opac/opac-suggestions.pl
+++ b/opac/opac-suggestions.pl
@@ -16,7 +16,7 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
+
use CGI;
use C4::Auth; # get_template_and_user
use C4::Output;
diff --git a/opac/opac-user.pl b/opac/opac-user.pl
index 04d0c9e..763e810 100755
--- a/opac/opac-user.pl
+++ b/opac/opac-user.pl
@@ -17,7 +17,7 @@
use strict;
-require Exporter;
+
use CGI;
use C4::Auth;
diff --git a/opac/opac-userupdate.pl b/opac/opac-userupdate.pl
index 384f003..f01a664 100755
--- a/opac/opac-userupdate.pl
+++ b/opac/opac-userupdate.pl
@@ -18,7 +18,7 @@
# Suite 330, Boston, MA 02111-1307 USA
use strict;
-require Exporter;
+
use CGI;
use Mail::Sendmail;
diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl
index d29e23f..1979758 100755
--- a/opac/sco/sco-main.pl
+++ b/opac/sco/sco-main.pl
@@ -6,7 +6,7 @@
# issue items to that borrower.
#
use strict;
-require Exporter;
+
use CGI;
#use C4::Authsco;
diff --git a/serials/subscription-bib-search.pl b/serials/subscription-bib-search.pl
index 2a83d3e..21341db 100755
--- a/serials/subscription-bib-search.pl
+++ b/serials/subscription-bib-search.pl
@@ -48,7 +48,7 @@ to multipage gestion.
use strict;
-require Exporter;
+
use CGI;
use C4::Koha;
use C4::Auth;
diff --git a/serials/subscription-renew.pl b/serials/subscription-renew.pl
index 484fbfb..10c1205 100755
--- a/serials/subscription-renew.pl
+++ b/serials/subscription-renew.pl
@@ -45,7 +45,7 @@ Id of the subscription this script has to renew
=cut
use strict;
-require Exporter;
+
use CGI;
use C4::Koha;
use C4::Auth;
diff --git a/suggestion/acceptorreject.pl b/suggestion/acceptorreject.pl
index 3fed003..5100334 100755
--- a/suggestion/acceptorreject.pl
+++ b/suggestion/acceptorreject.pl
@@ -65,7 +65,7 @@ op can be :
=cut
use strict;
-require Exporter;
+
use CGI;
use C4::Auth; # get_template_and_user
diff --git a/tools/export.pl b/tools/export.pl
index 6ee0145..b0cf6be 100755
--- a/tools/export.pl
+++ b/tools/export.pl
@@ -18,7 +18,7 @@
use strict;
-require Exporter;
+
use C4::Auth;
use C4::Output; # contains gettemplate
use C4::Biblio; # GetMarcBiblio GetXmlBiblio
diff --git a/tools/pdfViewer.pl b/tools/pdfViewer.pl
index aefedce..3ca61a8 100755
--- a/tools/pdfViewer.pl
+++ b/tools/pdfViewer.pl
@@ -20,7 +20,7 @@
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
-require Exporter;
+
use strict;
use C4::Context;
--
1.5.5.GIT
More information about the Koha-patches
mailing list