[Koha-patches] [PATCH] Cleanup stopwords.pl and .tmpl

Galen Charlton galen.charlton at liblime.com
Sat Jun 6 22:17:00 CEST 2009


Hi,

On Fri, Jun 5, 2009 at 8:02 PM, Joe Atzberger<joe.atzberger at liblime.com> wrote:
> +    my @page = @$results[ $offset .. $offset+$pagesize-1 ]; # FIXME: limit and offset should get to the SQL query

This needs work.  If @$results has fewer than $pagesize entries, the
@page array is padded with undef entries.  When H::T::Pro iterates
over that loop, it hits the first undef and complains that:

stopwords.pl: PARAM:LOOP:next_loop:hash pointer was expected but not
found at /usr/local/lib/perl/5.8.8/HTML/Template/Pro.pm line 191.

The resulting HTML also has validation errors.

Please fix and resubmit.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt



More information about the Koha-patches mailing list