[Koha-patches] [PATCH 2/2] Bug 3154 Re-activate facet count
Frédéric Demians
f.demians at tamil.fr
Wed Dec 1 22:38:22 CET 2010
This patch complements and comments Fridolyn proposed patch.
Facet count was disabled to hide that the count is wrong since it was
calculated based on the first result displayed page. This patch reactivate
facets count.
I can confirm that Fridolyn trick is efficient and quick but:
- Facets count are still wrong. The count are better (ie bigger) but still
wrong as soon as result set is larger than examined set used to build
facets.
- Libraries facet remains misleading. If a biblio record contains a 'foo'
library but is at the end of the resultset, 'foo' Library isn't displayed.
A patron can conclude that the ressource he's not available at his library.
- It reports a huge charge load on Zebra server which has to return a LOT of
records to build facets. It should be tested with simultaneous requests in
order to see if it impacts Zebra overall performances.
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
---
.../opac-tmpl/prog/en/includes/opac-facets.inc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc
index 85719f3..8563d8b 100644
--- a/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc
+++ b/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc
@@ -18,7 +18,7 @@
<!-- TMPL_IF NAME="type_label_Libraries" -->Libraries<!-- /TMPL_IF -->
<!-- /TMPL_UNLESS -->
<ul>
- <!-- TMPL_LOOP NAME="facets" --><li><a href="/cgi-bin/koha/opac-search.pl?<!-- TMPL_VAR NAME="query_cgi" --><!-- TMPL_VAR NAME="limit_cgi" --><!-- TMPL_IF NAME="sort_by" -->&sort_by=<!-- TMPL_VAR NAME="sort_by" --><!-- /TMPL_IF -->&limit=<!-- TMPL_VAR NAME="type_link_value" -->:<!-- TMPL_VAR NAME="facet_link_value" -->" title="<!-- TMPL_VAR NAME="facet_title_value" ESCAPE="HTML" -->"><!-- TMPL_VAR NAME="facet_label_value" --></a> <!-- (<!-- TMPL_VAR NAME="facet_count" -->) --></li><!-- /TMPL_LOOP --><!-- TMPL_IF NAME="expandable" -->
+ <!-- TMPL_LOOP NAME="facets" --><li><a href="/cgi-bin/koha/opac-search.pl?<!-- TMPL_VAR NAME="query_cgi" --><!-- TMPL_VAR NAME="limit_cgi" --><!-- TMPL_IF NAME="sort_by" -->&sort_by=<!-- TMPL_VAR NAME="sort_by" --><!-- /TMPL_IF -->&limit=<!-- TMPL_VAR NAME="type_link_value" -->:<!-- TMPL_VAR NAME="facet_link_value" -->" title="<!-- TMPL_VAR NAME="facet_title_value" ESCAPE="HTML" -->"><!-- TMPL_VAR NAME="facet_label_value" --></a> (<!-- TMPL_VAR NAME="facet_count" -->)</li><!-- /TMPL_LOOP --><!-- TMPL_IF NAME="expandable" -->
<li class="showmore"><a href="/cgi-bin/koha/opac-search.pl?<!-- TMPL_VAR NAME="query_cgi" --><!-- TMPL_VAR NAME="limit_cgi" --><!-- TMPL_IF NAME="sort_by" -->&sort_by=<!-- TMPL_VAR NAME="sort_by" --><!-- /TMPL_IF -->&offset=<!-- TMPL_VAR NAME="offset" -->&expand=<!-- TMPL_VAR NAME="expand" -->#<!-- TMPL_VAR NAME="type_id" -->">Show More</a></li>
<!-- /TMPL_IF -->
</ul></li>
--
1.7.3.2
More information about the Koha-patches
mailing list