[Koha-patches] [PATCH] Bug 5418: Rev-4 patch new itemBarcodeInputFilter for libsuite8 style barcodes

[Koustubha Kale]

Thanks for looking into this patch.

>
> But:
>
> Your patch modify installer/data/mysql/updatedatabase.pl. It souldn't.
> You're modifying an old DB update which will never been called again on
> new installation.

Suggested by chris while he was guiding me on irc on how to properly
implement a new syspref option. But I'll be happy to remove any
changes to installer/data/mysql/updatedatabase.pl if same is not
required..


>
> You also modify itemBarcodeInputFilter syspref in
> data/mysql/en/mandatory/sysprefs.sql. I'm not sure it's required
> anymore. You add your new syspref in circulation.pref. It's enough.
> Others can correct me if I'm wrong.

The reason to do this chris gave was, this file is translatable while
a db entry is not. Be happy to get rid of the changes if its not
required.

Should I remove changes to these two files, retest and resubmit?


Regards,
Koustubha Kale
Anant Corporation

Contact Details :
Address  : 103, Armaan Residency, R. W Sawant Road, Nr. Golden Dyes
Naka, Thane (w),
                Maharashtra, India, Pin : 400601.
TeleFax  : +91-22-21720108, +91-22-21720109
Mobile     : +919820715876
Website  : http://www.anantcorp.com
Blog : http://www.anantcorp.com/blog/?author=2