[Koha-patches] [PATCH] Bug 5373: Adds cardnumber to the field list of the Import Patrons NOTES.

[Chris Nighswonger]

I was just doing a bit of cherry-picking for 3.2.x and noticed this
patch which has been committed to HEAD.

This is not the correct way to fix this "bug." Cardnumber is one of
two fields stripped by line 64 in tools/import_borrowers.pl. If it is
desirable to include 'cardnumber' in the field list, it should be
removed from the grep in the underlying script at the above mentioned
line.

Doing this at the template level just results in an unnecessary remove
and re-addition.

Kind Regards,
Chris


On Sun, Dec 5, 2010 at 5:07 PM, Garry Collum <gcollum at gmail.com> wrote:
> Adds 'cardnumber' as an option to the list of possible fields in the NOTES section of the patron import tool.
> ---
>  .../prog/en/modules/tools/import_borrowers.tmpl    |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tmpl
> index 0e409b6..2bec508 100644
> --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tmpl
> +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tmpl
> @@ -144,8 +144,8 @@
>  <ul>
>  <li>The first line in the file must be a header row defining which columns you are supplying in the import file.</li>
>  <li><b>Download a starter CSV file with all the columns <a href="?sample=1">here</a>.</b>  Values are comma-separated.</li>
> -<li>OR choose which fields you want to supply from the following list:<ul><li>
> -    <!-- TMPL_LOOP name="columnkeys" -->'<!-- TMPL_VAR name="key" -->', <!-- /TMPL_LOOP -->
> +<li>OR choose which fields you want to supply from the following list:<ul>
> +<li>'cardnumber'<!-- TMPL_LOOP name="columnkeys" -->, '<!-- TMPL_VAR name="key" -->'<!-- /TMPL_LOOP -->
>  </li></ul></li>
>  <!-- TMPL_IF NAME="ExtendedPatronAttributes" -->
>  <li>If loading patron attributes, the 'patron_attributes' field should contain a comma-separated list of attribute types and values. The attribute type code and a colon should precede each value. For example: <b>INSTID:12345,LANG:fr</b> or <b>STARTDATE:January 1 2010,TRACK:Day</b>. If an input record has more than one attribute, the fields should either be entered as an unquoted string (previous examples), or with each field wrapped in separate double quotes and delimited by a comma: <b>&quot;STARTDATE:January 1, 2010&quot;,&quot;TRACK:Day&quot;</b>.  The second syntax would be required if the data might have a comma in it, like a date string.
> --
> 1.5.6.5
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>