[Koha-patches] [PATCH] Bugfix: 4046 Misc SQL Syntax Errors
Chris Nighswonger
cnighswonger at foundations.edu
Fri Jan 15 05:03:02 CET 2010
This patch fixes several SQL syntax errors with the ALTER TABLE pragma
---
installer/data/mysql/updatedatabase.pl | 47 +++++++++++++++----------------
1 files changed, 23 insertions(+), 24 deletions(-)
diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
index 901f98d..6a25bfd 100755
--- a/installer/data/mysql/updatedatabase.pl
+++ b/installer/data/mysql/updatedatabase.pl
@@ -2756,19 +2756,19 @@ if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
$DBversion = "3.01.00.068";
if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
- $dbh->do("ALTER TABLE issuingrules ADD
- COLUMN `finedays` int(11) default NULL AFTER `fine`,
- COLUMN `renewalsallowed` smallint(6) default NULL,
- COLUMN `reservesallowed` smallint(6) default NULL,
- ");
- my $sth = $dbh->prepare("SELECT itemtype, renewalsallowed FROM itemtypes");
+ $dbh->do("ALTER TABLE issuingrules
+ ADD COLUMN `finedays` int(11) default NULL AFTER `fine`,
+ ADD COLUMN `renewalsallowed` smallint(6) default NULL,
+ ADD COLUMN `reservesallowed` smallint(6) default NULL,
+ ");
+ my $sth = $dbh->prepare("SELECT itemtype, renewalsallowed FROM itemtypes");
$sth->execute();
- my $sthupd = $dbh->prepare("UPDATE issuingrules SET renewalsallowed = ? WHERE itemtype = ?");
- while(my $row = $sth->fetchrow_hashref){
- $sthupd->execute($row->{renewalsallowed}, $row->{itemtype});
- }
- $dbh->do('ALTER TABLE itemtypes DROP COLUMN `renewalsallowed`;');
- print "Upgrade done (Adding finedays renewalsallowed, and reservesallowed fields in issuingrules table)\n";
+ my $sthupd = $dbh->prepare("UPDATE issuingrules SET renewalsallowed = ? WHERE itemtype = ?");
+ while(my $row = $sth->fetchrow_hashref){
+ $sthupd->execute($row->{renewalsallowed}, $row->{itemtype});
+ }
+ $dbh->do('ALTER TABLE itemtypes DROP COLUMN `renewalsallowed`;');
+ print "Upgrade done (Adding finedays renewalsallowed, and reservesallowed fields in issuingrules table)\n";
}
@@ -3116,18 +3116,17 @@ if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
$DBversion = "3.01.00.086";
if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
$dbh->do(<<SUGGESTIONS);
-ALTER table suggestions
- ADD budgetid INT(11),
- ADD branchcode VARCHAR(10) default NULL,
- ADD acceptedby INT(11) default NULL,
- ADD accepteddate date default NULL,
- ADD suggesteddate date default NULL,
- ADD manageddate date default NULL,
- ADD rejectedby INT(11) default NULL,
- ADD rejecteddate date default NULL,
- ADD collectiontitle text default NULL,
- ADD itemtype VARCHAR(30) default NULL,
- ;
+ ALTER table suggestions
+ ADD COLUMN budgetid INT(11),
+ ADD COLUMN branchcode VARCHAR(10) default NULL,
+ ADD COLUMN acceptedby INT(11) default NULL,
+ ADD COLUMN accepteddate date default NULL,
+ ADD COLUMN suggesteddate date default NULL,
+ ADD COLUMN manageddate date default NULL,
+ ADD COLUMN rejectedby INT(11) default NULL,
+ ADD COLUMN rejecteddate date default NULL,
+ ADD COLUMN collectiontitle text default NULL,
+ ADD COLUMN itemtype VARCHAR(30) default NULL;
SUGGESTIONS
print "Upgrade to $DBversion done Suggestions";
SetVersion ($DBversion);
--
1.6.0.4
More information about the Koha-patches
mailing list