[Koha-patches] Pull request - git://git.librarypolice.com/git/koha-galen.git 3.4_BibLibre-reports-tested

[Galen Charlton]

This is a tested version of BibLibre's 3.4/BibLibre-reports branch 
including some follow-up patches.  The following patches in BibLibre's
original pull request do  *not* have my sign-off and are consequently 
omitted from this branch:

* MT2268 : Followup Reports Guided columns.def

Patch resulted in double-encoding of diacritics in both
the column picker and report output.  Without the patch, diacritics
in report output and the column picker display correctly for me, so
whatever problem this patch was trying to solve ... works for me.

* MT4038 : guided reports (Guided reports should be exported 
  according to the delimiter system preference)

I am in agreement with the general idea, but the implementation needs work:

[1] The patch does not check the value of the delimiter syspref correctly; in 
particular, if you set the syspref to 'tabs', the delimiter will be set to 
the literal string 'tabulation'.
[2] To be consistent with the non-guided reports, what it should be doing
is giving the user a choice of delimiters and using the syspref only to 
select the default choice.

* bugfix on catalogue_stat : barcode & acquire fields

[1] This patch adds an extraneous file, reports/catalogue_stats.pl.orig
[2] It also contains a regression for bug 4176.

* (MT #4417) support dates for debarred's patrons stats

This patch assumes that borrowers.debarred is a date column; it is 
currently a Boolean.  If BibLibre is proposing to make that column a date,
this patch belongs on a separate topic branch implementing such a change.

The following changes since commit 1aef81c354eb17c2cf2d557cac78d4e37c30a046:
  Chris Cormack (1):
        Ukranian and Russian syspref language updates

are available in the git repository at:

  git://git.librarypolice.com/git/koha-galen.git 3.4_BibLibre-reports-tested

Alex Arnaud (1):
      (MT 3267) Add Homebranch and Holdingbranch search criterion on circulation stat.

Galen Charlton (3):
      Removed two column definitions added in previous patch
      follow-up: improve use of home and holding library in circ stats report
      follow-up to reports permissions patch

Jean-André Santoni (1):
      Fixes a permission problem in guided reports

Paul POULAIN (1):
      MT4578 : remove edit & delete button if the user don't have edit/create report permission

Paul Poulain (1):
      MT2268 : Guided Reports Fix columns.def

 C4/Reports/Guided.pm                               |    3 +-
 koha-tmpl/intranet-tmpl/prog/en/columns.def        |    1 +
 .../en/modules/reports/guided_reports_start.tmpl   |   20 ++++-
 .../prog/en/modules/reports/issues_stats.tmpl      |   24 ++++++
 reports/guided_reports.pl                          |    6 +-
 reports/issues_stats.pl                            |   74 ++++++++++++--------
 6 files changed, 90 insertions(+), 38 deletions(-)