[Koha-patches] [PATCH 2/2] Bug 5415 Let calls of SimpleSearch utilize considtent interface

[Galen Charlton]

Hi,

On Thu, Nov 18, 2010 at 4:56 AM, LAURENT Henri-Damien
<henridamien.laurent at biblibre.com> wrote:
> I have seen that you are using die....

Where?  I don't see anything in the patch that adds a die() or croak().

As far as general question is concerned, I agree that module code
should not be calling die() unless the code that calls the module
routine is set up to catch the exception [although adding exception
handling to Koha's bag of tricks would be a good idea] or if something
is so badly wrong that terminating is the only way to prevent data
loss.

Regards,

Galen
-- 
Galen Charlton
gmcharlt at gmail.com