[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5687: Add pref StaffAuthorisedValueImages for staff search results

[Ian Walls]

From: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

This patch contains the functionality, not the install stuff.

Revised: with input of Ian Walls: populate authorised_value_images only if needed; no changes anymore for template and search.pl.

Signed-off-by: Ian Walls <ian.walls at bywatersolutions.com>
---
 C4/Search.pm                                       |    2 +-
 .../en/modules/admin/preferences/staff_client.pref |    6 ++++++
 2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/C4/Search.pm b/C4/Search.pm
index cd970b7..190c8df 100644
--- a/C4/Search.pm
+++ b/C4/Search.pm
@@ -1482,7 +1482,7 @@ sub searchResults {
         # add imageurl to itemtype if there is one
         $oldbiblio->{imageurl} = getitemtypeimagelocation( 'opac', $itemtypes{ $oldbiblio->{itemtype} }->{imageurl} );
 
-        $oldbiblio->{'authorised_value_images'}  = C4::Items::get_authorised_value_images( C4::Biblio::get_biblio_authorised_values( $oldbiblio->{'biblionumber'}, $marcrecord ) );
+        $oldbiblio->{'authorised_value_images'}  = ($search_context eq 'opac' && C4::Context->preference('AuthorisedValueImages')) || ($search_context eq 'intranet' && C4::Context->preference('StaffAuthorisedValueImages')) ? C4::Items::get_authorised_value_images( C4::Biblio::get_biblio_authorised_values( $oldbiblio->{'biblionumber'}, $marcrecord ) ) : [];
 		$oldbiblio->{normalized_upc}  = GetNormalizedUPC(       $marcrecord,$marcflavour);
 		$oldbiblio->{normalized_ean}  = GetNormalizedEAN(       $marcrecord,$marcflavour);
 		$oldbiblio->{normalized_oclc} = GetNormalizedOCLCNumber($marcrecord,$marcflavour);
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
index 50dae66..b658954 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref
@@ -68,6 +68,12 @@ Staff Client:
               choices:
                   local: "included with Koha (faster, will work if internet goes down)."
                   "http://yui.yahooapis.com/2.5.1/build": "from Yahoo's own servers (less demand on your servers)."
+        -
+            - pref: StaffAuthorisedValueImages
+              choices:
+                  yes: Show
+                  no: "Don't show"
+            - images for <a href="/cgi-bin/koha/admin/authorised_values.pl">authorized values</a> (such as lost statuses and locations) in search results.
     Options:
         -
             - pref: viewMARC
-- 
1.5.6.5