From sw at weilnetz.de Sun Jun 14 22:30:12 2015 From: sw at weilnetz.de (Stefan Weil) Date: Sun, 14 Jun 2015 22:30:12 +0200 Subject: [Koha-patches] [PATCH] debian: Fix some trivial typos Message-ID: <1434313812-5902-1-git-send-email-sw@weilnetz.de> They were found and fixed using codespell. Signed-off-by: Stefan Weil --- debian/control | 8 ++++---- debian/control.in | 8 ++++---- debian/templates/koha-sites.conf | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/debian/control b/debian/control index bfcceaa..8a3b9d0 100644 --- a/debian/control +++ b/debian/control @@ -153,7 +153,7 @@ Suggests: mysql-server | virtual-mysql-server, memcached Homepage: http://koha-community.org/ Description: integrated (physical) library management system - Koha is an Integrated Library Managment system for real-world libraries + Koha is an Integrated Library Management system for real-world libraries (the kinds with books). . This package contains everything needed to run Koha, except the site @@ -167,7 +167,7 @@ Depends: ${shlib:Depends}, ${misc:Depends}, mysql-server | virtual-mysql-server Homepage: http://koha-community.org/ Description: integrated (physical) library management system - Koha is an Integrated Library Managment system for real-world libraries + Koha is an Integrated Library Management system for real-world libraries (the kinds with books). . This package contains site-specific configuration files and sets up @@ -199,7 +199,7 @@ Depends: ${misc:Depends}, yaz Architecture: all Description: Other dep. for koha - Koha is an Integrated Library Managment system for real-world libraries + Koha is an Integrated Library Management system for real-world libraries (the kinds with books). . This meta-package contains general dependencies packages for koha (apache2, @@ -325,7 +325,7 @@ Depends: libalgorithm-checkdigits-perl, perl-modules Architecture: all Description: Perl dep. for koha - Koha is an Integrated Library Managment system for real-world libraries + Koha is an Integrated Library Management system for real-world libraries (the kinds with books). . This meta-package contains perl dependencies packages for koha (all diff --git a/debian/control.in b/debian/control.in index e23c8b3..c77c633 100644 --- a/debian/control.in +++ b/debian/control.in @@ -37,7 +37,7 @@ Suggests: mysql-server | virtual-mysql-server, memcached Homepage: http://koha-community.org/ Description: integrated (physical) library management system - Koha is an Integrated Library Managment system for real-world libraries + Koha is an Integrated Library Management system for real-world libraries (the kinds with books). . This package contains everything needed to run Koha, except the site @@ -51,7 +51,7 @@ Depends: ${shlib:Depends}, ${misc:Depends}, mysql-server | virtual-mysql-server Homepage: http://koha-community.org/ Description: integrated (physical) library management system - Koha is an Integrated Library Managment system for real-world libraries + Koha is an Integrated Library Management system for real-world libraries (the kinds with books). . This package contains site-specific configuration files and sets up @@ -83,7 +83,7 @@ Depends: ${misc:Depends}, yaz Architecture: all Description: Other dep. for koha - Koha is an Integrated Library Managment system for real-world libraries + Koha is an Integrated Library Management system for real-world libraries (the kinds with books). . This meta-package contains general dependencies packages for koha (apache2, @@ -93,7 +93,7 @@ Package: koha-perldeps Depends:__AUTODEPENDS__ Architecture: all Description: Perl dep. for koha - Koha is an Integrated Library Managment system for real-world libraries + Koha is an Integrated Library Management system for real-world libraries (the kinds with books). . This meta-package contains perl dependencies packages for koha (all diff --git a/debian/templates/koha-sites.conf b/debian/templates/koha-sites.conf index c14cb3d..47d5033 100644 --- a/debian/templates/koha-sites.conf +++ b/debian/templates/koha-sites.conf @@ -38,7 +38,7 @@ ZEBRA_LANGUAGE="en" BIBLIOS_INDEXING_MODE="dom" # AUTHORITIES_INDEXING_MODE: 'dom' | 'grs1' -# Indexing mode for authorithy records +# Indexing mode for authority records # default: 'dom' AUTHORITIES_INDEXING_MODE="dom" -- 2.1.4 From sw at weilnetz.de Sun Jun 14 22:42:57 2015 From: sw at weilnetz.de (Stefan Weil) Date: Sun, 14 Jun 2015 22:42:57 +0200 Subject: [Koha-patches] [PATCH] misc: Fix some typos in comments and documentation Message-ID: <1434314577-6603-1-git-send-email-sw@weilnetz.de> Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil --- misc/cronjobs/cloud-kw.pl | 10 +++++----- misc/cronjobs/fines.pl | 2 +- misc/cronjobs/overdue_notices.pl | 6 +++--- misc/cronjobs/rss/README | 2 +- misc/cronjobs/staticfines.pl | 2 +- misc/devel/update_dbix_class_files.pl | 2 +- misc/load_testing/benchmark_circulation.pl | 2 +- misc/maintenance/MARC21_utf8_flag_fix.pl | 2 +- misc/migration_tools/bulkmarcimport.pl | 6 +++--- misc/migration_tools/koha-svc.pl | 2 +- misc/plack/koha.psgi | 2 +- 11 files changed, 19 insertions(+), 19 deletions(-) diff --git a/misc/cronjobs/cloud-kw.pl b/misc/cronjobs/cloud-kw.pl index 82ce25f..9686415 100755 --- a/misc/cronjobs/cloud-kw.pl +++ b/misc/cronjobs/cloud-kw.pl @@ -128,12 +128,12 @@ sub new { # RETURN: # A 4-dimensionnal array in $self->{top_terms} # [0] term -# [1] term number of occurences +# [1] term number of occurrences # [2] term proportional relative weight in terms set E[0-1] # [3] term logarithmic relative weight E [0-levels_cloud] # # This array is sorted alphabetically by terms ([0]) -# It can be easily sorted by occurences: +# It can be easily sorted by occurrences: # @t = sort { $a[1] <=> $a[1] } @{$self->{top_terms}}; # sub scan { @@ -236,7 +236,7 @@ sub scan { # -# Returns a HTML version of index top terms formated +# Returns a HTML version of index top terms formatted # as a 'tag cloud'. # sub html_cloud { @@ -376,14 +376,14 @@ Configuration file looks like that: =head1 IMPROVEMENTS Generated top terms have more informations than those outputted from -the time beeing. Some parameters could be easily added to improve +the time being. Some parameters could be easily added to improve this script: =over =item B -In order to output terms with the number of occurences they +In order to output terms with the number of occurrences they have been found in Koha Catalogue by Zebra. =item B diff --git a/misc/cronjobs/fines.pl b/misc/cronjobs/fines.pl index 75d3fbb..538f962 100755 --- a/misc/cronjobs/fines.pl +++ b/misc/cronjobs/fines.pl @@ -3,7 +3,7 @@ # This script loops through each overdue item, determines the fine, # and updates the total amount of fines due by each user. It relies on # the existence of /tmp/fines, which is created by ??? -# Doesnt really rely on it, it relys on being able to write to /tmp/ +# Doesn't really rely on it, it relys on being able to write to /tmp/ # It creates the fines file # # This script is meant to be run nightly out of cron. diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index 7068d3d..f87f254 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -119,7 +119,7 @@ overdues that could not be emailed are sent in CSV format to the admin. Produces html data. If patron does not have an email address or -n (no mail) flag is set, an HTML file is generated in the specified -directory. This can be downloaded or futher processed by library staff. +directory. This can be downloaded or further processed by library staff. The file will be called notices-YYYY-MM-DD.html and placed in the directory specified. @@ -127,7 +127,7 @@ specified. Produces plain text data. If patron does not have an email address or -n (no mail) flag is set, a text file is generated in the specified -directory. This can be downloaded or futher processed by library staff. +directory. This can be downloaded or further processed by library staff. The file will be called notices-YYYY-MM-DD.txt and placed in the directory specified. @@ -268,7 +268,7 @@ overdues in the last 2 weeks for the MAIN library. =head1 SEE ALSO The F program allows you to send -messages to patrons in advance of thier items becoming due, or to +messages to patrons in advance of their items becoming due, or to alert them of items that have just become due. =cut diff --git a/misc/cronjobs/rss/README b/misc/cronjobs/rss/README index b3967d5..421a4f8 100644 --- a/misc/cronjobs/rss/README +++ b/misc/cronjobs/rss/README @@ -27,7 +27,7 @@ content, or at least modify the ones present here, let's review the config file and the template file. A config file is divided into three sections; channel, image, and -config. A section begins with the name of the section occuring alone +config. A section begins with the name of the section occurring alone on a line, and ends with the beginning of the next section (or the end of the file). Each of these sections contains series of configuration options in the form: diff --git a/misc/cronjobs/staticfines.pl b/misc/cronjobs/staticfines.pl index 1309c8b..eb5284c 100755 --- a/misc/cronjobs/staticfines.pl +++ b/misc/cronjobs/staticfines.pl @@ -3,7 +3,7 @@ # This script loops through each overdue item, determines the fine, # and updates the total amount of fines due by each user. It relies on # the existence of /tmp/fines, which is created by ??? -# Doesnt really rely on it, it relys on being able to write to /tmp/ +# Doesn't really rely on it, it relies on being able to write to /tmp/ # It creates the fines file # # This script is meant to be run nightly out of cron. diff --git a/misc/devel/update_dbix_class_files.pl b/misc/devel/update_dbix_class_files.pl index 9b080e0..a291cef 100755 --- a/misc/devel/update_dbix_class_files.pl +++ b/misc/devel/update_dbix_class_files.pl @@ -72,7 +72,7 @@ misc/devel/update_dbix_class_files.pl --db_passwd=db-pass ... The command in usually called from the root directory for the Koha source tree. -If you are runing from another directory, use the --path switch to specify +If you are running from another directory, use the --path switch to specify a different path. =head1 OPTIONS diff --git a/misc/load_testing/benchmark_circulation.pl b/misc/load_testing/benchmark_circulation.pl index 8974edb..5c6ecdb 100755 --- a/misc/load_testing/benchmark_circulation.pl +++ b/misc/load_testing/benchmark_circulation.pl @@ -71,7 +71,7 @@ my @mainpage; print "--------------\n"; print "Koha circulation benchmarking utility\n"; print "--------------\n"; -print "Benchmarking with $max_tries occurences of each operation and $concurrency concurrent sessions \n"; +print "Benchmarking with $max_tries occurrences of each operation and $concurrency concurrent sessions \n"; print "Load testing staff client dashboard page"; for (my $i=1;$i<=$max_tries;$i++) { push @mainpage,"$baseurl/mainpage.pl"; diff --git a/misc/maintenance/MARC21_utf8_flag_fix.pl b/misc/maintenance/MARC21_utf8_flag_fix.pl index fda68be..b0efb8d 100755 --- a/misc/maintenance/MARC21_utf8_flag_fix.pl +++ b/misc/maintenance/MARC21_utf8_flag_fix.pl @@ -170,7 +170,7 @@ The default is to target all records with bad leaders. =item B<--offset=N> -Like an OFFSET statement in SQL, this tells the script to skip N of the targetted records. +Like an OFFSET statement in SQL, this tells the script to skip N of the targeted records. The default is 0, i.e. skip none of them. =back diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl index 8d1f518..fc68e40 100755 --- a/misc/migration_tools/bulkmarcimport.pl +++ b/misc/migration_tools/bulkmarcimport.pl @@ -122,7 +122,7 @@ if ((not defined $sourcesubfield) && (not defined $sourcetag)){ } -# Disable logging for the biblios and authorities import operation. It would unnecesarily +# Disable logging for the biblios and authorities import operation. It would unnecessarily # slow the import # Disable the syspref cache so we can change logging settings @@ -727,7 +727,7 @@ if set, do whatever is required =item B<-k, -keepids>= -Field store ids in I (usefull for authorities, where 001 contains the +Field store ids in I (useful for authorities, where 001 contains the authid for Koha, that can contain a very valuable info for authorities coming from LOC or BNF. useless for biblios probably) @@ -761,7 +761,7 @@ I for the koha bib and source id =item B<-keepids> -Store ids in 009 (usefull for authorities, where 001 contains the authid for +Store ids in 009 (useful for authorities, where 001 contains the authid for Koha, that can contain a very valuable info for authorities coming from LOC or BNF. useless for biblios probably) diff --git a/misc/migration_tools/koha-svc.pl b/misc/migration_tools/koha-svc.pl index 8d2acf5..055c238 100755 --- a/misc/migration_tools/koha-svc.pl +++ b/misc/migration_tools/koha-svc.pl @@ -77,7 +77,7 @@ This same script can be used as module (as it defines T package) usin require "koha-svc.pl" -at begining of script. Rest of API is described below. Example of it's usage is at beginning of this script. +at beginning of script. Rest of API is described below. Example of its usage is at beginning of this script. =head2 new diff --git a/misc/plack/koha.psgi b/misc/plack/koha.psgi index a35eb77..b0cd20a 100644 --- a/misc/plack/koha.psgi +++ b/misc/plack/koha.psgi @@ -28,7 +28,7 @@ $ENV{PLACK_DEBUG} = 1; # toggle debugging $ENV{MEMCACHED_SERVERS} = "localhost:11211"; #$ENV{MEMCACHED_DEBUG} = 0; -$ENV{PROFILE_PER_PAGE} = 1; # reset persistant and profile counters after each page, like CGI +$ENV{PROFILE_PER_PAGE} = 1; # reset persistent and profile counters after each page, like CGI #$ENV{INTRANET} = 1; # usually passed from script #$ENV{DBI_AUTOPROXY}='dbi:Gofer:transport=null;cache=DBI::Util::CacheMemory' -- 2.1.4 From robin at catalyst.net.nz Tue Jun 16 07:59:22 2015 From: robin at catalyst.net.nz (Robin Sheat) Date: Tue, 16 Jun 2015 17:59:22 +1200 Subject: [Koha-patches] [PATCH] debian: Fix some trivial typos In-Reply-To: <1434313812-5902-1-git-send-email-sw@weilnetz.de> References: <1434313812-5902-1-git-send-email-sw@weilnetz.de> Message-ID: <1434434362.24795.2.camel@catalyst.net.nz> Thanks for these. If you like, create a bug for them at bugs.koha-community.org and file them there. See here for a quick guide to the process: http://wiki.koha-community.org/wiki/SubmitingAPatch if you can't be bothered, let me know and I'll do them for you. Stefan Weil schreef op zo 14-06-2015 om 22:30 [+0200]: > They were found and fixed using codespell. > > Signed-off-by: Stefan Weil > --- > debian/control | 8 ++++---- > debian/control.in | 8 ++++---- > debian/templates/koha-sites.conf | 2 +- > 3 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/debian/control b/debian/control > index bfcceaa..8a3b9d0 100644 > --- a/debian/control > +++ b/debian/control > @@ -153,7 +153,7 @@ Suggests: mysql-server | virtual-mysql-server, > memcached > Homepage: http://koha-community.org/ > Description: integrated (physical) library management system > - Koha is an Integrated Library Managment system for real-world libraries > + Koha is an Integrated Library Management system for real-world libraries > (the kinds with books). > . > This package contains everything needed to run Koha, except the site > @@ -167,7 +167,7 @@ Depends: ${shlib:Depends}, ${misc:Depends}, > mysql-server | virtual-mysql-server > Homepage: http://koha-community.org/ > Description: integrated (physical) library management system > - Koha is an Integrated Library Managment system for real-world libraries > + Koha is an Integrated Library Management system for real-world libraries > (the kinds with books). > . > This package contains site-specific configuration files and sets up > @@ -199,7 +199,7 @@ Depends: ${misc:Depends}, > yaz > Architecture: all > Description: Other dep. for koha > - Koha is an Integrated Library Managment system for real-world libraries > + Koha is an Integrated Library Management system for real-world libraries > (the kinds with books). > . > This meta-package contains general dependencies packages for koha (apache2, > @@ -325,7 +325,7 @@ Depends: libalgorithm-checkdigits-perl, > perl-modules > Architecture: all > Description: Perl dep. for koha > - Koha is an Integrated Library Managment system for real-world libraries > + Koha is an Integrated Library Management system for real-world libraries > (the kinds with books). > . > This meta-package contains perl dependencies packages for koha (all > diff --git a/debian/control.in b/debian/control.in > index e23c8b3..c77c633 100644 > --- a/debian/control.in > +++ b/debian/control.in > @@ -37,7 +37,7 @@ Suggests: mysql-server | virtual-mysql-server, > memcached > Homepage: http://koha-community.org/ > Description: integrated (physical) library management system > - Koha is an Integrated Library Managment system for real-world libraries > + Koha is an Integrated Library Management system for real-world libraries > (the kinds with books). > . > This package contains everything needed to run Koha, except the site > @@ -51,7 +51,7 @@ Depends: ${shlib:Depends}, ${misc:Depends}, > mysql-server | virtual-mysql-server > Homepage: http://koha-community.org/ > Description: integrated (physical) library management system > - Koha is an Integrated Library Managment system for real-world libraries > + Koha is an Integrated Library Management system for real-world libraries > (the kinds with books). > . > This package contains site-specific configuration files and sets up > @@ -83,7 +83,7 @@ Depends: ${misc:Depends}, > yaz > Architecture: all > Description: Other dep. for koha > - Koha is an Integrated Library Managment system for real-world libraries > + Koha is an Integrated Library Management system for real-world libraries > (the kinds with books). > . > This meta-package contains general dependencies packages for koha (apache2, > @@ -93,7 +93,7 @@ Package: koha-perldeps > Depends:__AUTODEPENDS__ > Architecture: all > Description: Perl dep. for koha > - Koha is an Integrated Library Managment system for real-world libraries > + Koha is an Integrated Library Management system for real-world libraries > (the kinds with books). > . > This meta-package contains perl dependencies packages for koha (all > diff --git a/debian/templates/koha-sites.conf b/debian/templates/koha-sites.conf > index c14cb3d..47d5033 100644 > --- a/debian/templates/koha-sites.conf > +++ b/debian/templates/koha-sites.conf > @@ -38,7 +38,7 @@ ZEBRA_LANGUAGE="en" > BIBLIOS_INDEXING_MODE="dom" > > # AUTHORITIES_INDEXING_MODE: 'dom' | 'grs1' > -# Indexing mode for authorithy records > +# Indexing mode for authority records > # default: 'dom' > AUTHORITIES_INDEXING_MODE="dom" > -- Robin Sheat Catalyst IT Ltd. ? +64 4 803 2204 GPG: 5FA7 4B49 1E4D CAA4 4C38 8505 77F5 B724 F871 3BDF -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: This is a digitally signed message part URL: From chrisc at catalyst.net.nz Tue Jun 16 08:47:57 2015 From: chrisc at catalyst.net.nz (Chris Cormack) Date: Tue, 16 Jun 2015 18:47:57 +1200 Subject: [Koha-patches] [PATCH] debian: Fix some trivial typos In-Reply-To: <1434434362.24795.2.camel@catalyst.net.nz> References: <1434313812-5902-1-git-send-email-sw@weilnetz.de> <1434434362.24795.2.camel@catalyst.net.nz> Message-ID: <20150616064757.GD28516@rorohiko.wgtn.cat-it.co.nz> * Robin Sheat (robin at catalyst.net.nz) wrote: > Thanks for these. If you like, create a bug for them at > bugs.koha-community.org and file them there. See here for a quick guide > to the process: > > http://wiki.koha-community.org/wiki/SubmitingAPatch > > if you can't be bothered, let me know and I'll do them for you. > All done http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Chris -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From vanoudt at gmail.com Thu Jun 25 06:59:28 2015 From: vanoudt at gmail.com (Nicholas van Rheede van Oudtshoorn) Date: Thu, 25 Jun 2015 12:59:28 +0800 Subject: [Koha-patches] Bug 14407 - Limit web-based self-checkout to specific IP addresses Message-ID: Greetings everyone, As I'm still very much a perl newbie, I'd love to get some feedback on a patch I just pushed to bug 14407 (my own bug!) We use Self-Checkout here , with users just having to scan their barcode to take books out. Our OPAC is also live over the internet. That means that anyone who knows Koha, can access the self-checkout from off campus! This patch adds a preference allowing one to limit access to those pages to specific IP addresses or ranges. I've used Net::IP::Match::XS to do the heavy lifting - is there another library that Koha already uses to do the same sort of thing? Thanks in advance, Nick Perth Bible College -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: Bug-14407-Allow-web-based-self-checkout-to-be-limite.patch Type: application/octet-stream Size: 7328 bytes Desc: not available URL: