From bugzilla-daemon@bugs.koha-community.org Sun Oct 29 16:26:37 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] New: Remove html tags from sample notices Date: Sun, 29 Oct 2023 15:26:36 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7247038379988456537==" --===============7247038379988456537== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Bug ID: 35186 Summary: Remove html tags from sample notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Blocks: 34704 HTML notices don't require that we explicitly add tags. We have 2 notices where these are included in the sample notices and should be removed: PASSWORD_RESET STAFF_PASSWORD_RESET Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 [Bug 34704] Print templates are formatted incorrectly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============7247038379988456537==-- From bugzilla-daemon@bugs.koha-community.org Sun Oct 29 16:26:57 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Sun, 29 Oct 2023 15:26:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5670105913490632944==" --===============5670105913490632944== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============5670105913490632944==-- From bugzilla-daemon@bugs.koha-community.org Sun Oct 29 16:47:30 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Sun, 29 Oct 2023 15:47:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8860154679401860130==" --===============8860154679401860130== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============8860154679401860130==-- From bugzilla-daemon@bugs.koha-community.org Sun Oct 29 16:47:40 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Sun, 29 Oct 2023 15:47:32 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5175930544683367208==" --===============5175930544683367208== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 --- Comment #1 from Katrin Fischer --- Created attachment 158048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158048&action=edit Bug 35186: Remove unnecessary html tags from PASSWORD notices In HTML notices we don't need to explicitly use . This removes them from the 2 notices using them: * PASSWORD_RESET * STAFF_PASSWORD_RESET To test: * Apply patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Send password reset" * Log out * In the OPAC, request password reset ("forgot your password?") * Verify both notices appear nicely formatted (line breaks, bold, etc.) -- You are receiving this mail because: You are watching all bug changes. --===============5175930544683367208==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 30 00:10:43 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Sun, 29 Oct 2023 23:10:42 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1839444108093871064==" --===============1839444108093871064== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============1839444108093871064==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 30 00:10:53 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Sun, 29 Oct 2023 23:10:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5968685468900148378==" --===============5968685468900148378== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158048|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 158054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158054&action=edit Bug 35186: Remove unnecessary html tags from PASSWORD notices In HTML notices we don't need to explicitly use . This removes them from the 2 notices using them: * PASSWORD_RESET * STAFF_PASSWORD_RESET To test: * Apply patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Send password reset" * Log out * In the OPAC, request password reset ("forgot your password?") * Verify both notices appear nicely formatted (line breaks, bold, etc.) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. --===============5968685468900148378==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 30 00:11:27 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Sun, 29 Oct 2023 23:11:27 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9133623030954780249==" --===============9133623030954780249== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 --- Comment #3 from Katrin Fischer --- Thanks David :) -- You are receiving this mail because: You are watching all bug changes. --===============9133623030954780249==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 30 00:21:59 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Sun, 29 Oct 2023 23:21:58 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5266950011803483446==" --===============5266950011803483446== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes unnecessary release notes| | tags in two | |email notices: | |* | |PASSWORD_RESET | |* | |STAFF_PASSWORD_RESET | |These | |notices are only updated in | |new installations, for | |existing installation | |manually change the | |notices. CC| |david@davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD): 1. After applying the patch, ran reset_all, so that the notices are updated. 2. Needed to set the OpacResetPassword and KohaAdminEmailAddress system preference. OpacResetPassword required for Patron account > More > Send password reset option to appear. 3. To test sending emails using a Google account: 3.1 Set up an App password in your Google Account 3.2 Edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where = your Google email address; = your APP password, not your Google account password): smtp.gmail.com 587 5 STARTTLS GOOGLEACCOUNTUSER GOOGLEAPPPASSWORD 1 -- You are receiving this mail because: You are watching all bug changes. --===============5266950011803483446==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 30 17:05:57 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Mon, 30 Oct 2023 16:05:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5103034009763198513==" --===============5103034009763198513== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. --===============5103034009763198513==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 30 17:06:07 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Mon, 30 Oct 2023 16:05:58 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7306007546351024684==" --===============7306007546351024684== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158054|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 158079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158079&action=edit Bug 35186: Remove unnecessary html tags from PASSWORD notices In HTML notices we don't need to explicitly use . This removes them from the 2 notices using them: * PASSWORD_RESET * STAFF_PASSWORD_RESET To test: * Apply patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Send password reset" * Log out * In the OPAC, request password reset ("forgot your password?") * Verify both notices appear nicely formatted (line breaks, bold, etc.) Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. --===============7306007546351024684==-- From bugzilla-daemon@bugs.koha-community.org Mon Oct 30 17:06:17 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Mon, 30 Oct 2023 16:06:08 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4946613942463386460==" --===============4946613942463386460== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. --===============4946613942463386460==-- From bugzilla-daemon@bugs.koha-community.org Tue Oct 31 15:08:48 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Tue, 31 Oct 2023 14:06:51 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5075979034701530706==" --===============5075979034701530706== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. --===============5075979034701530706==-- From bugzilla-daemon@bugs.koha-community.org Tue Oct 31 15:08:58 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Tue, 31 Oct 2023 14:06:53 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4622186192613770642==" --===============4622186192613770642== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. --===============4622186192613770642==-- From bugzilla-daemon@bugs.koha-community.org Wed Nov 8 09:25:33 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Wed, 08 Nov 2023 08:25:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5772618912151380600==" --===============5772618912151380600== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.06 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes. --===============5772618912151380600==-- From bugzilla-daemon@bugs.koha-community.org Mon Nov 13 16:31:22 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Mon, 13 Nov 2023 15:29:24 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0981161737409811321==" --===============0981161737409811321== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. --===============0981161737409811321==-- From bugzilla-daemon@bugs.koha-community.org Mon Nov 13 16:31:33 2023 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 35186] Remove html tags from sample notices Date: Mon, 13 Nov 2023 15:29:25 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7550749755227920062==" --===============7550749755227920062== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35186 --- Comment #8 from Matt Blenkinsop --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. --===============7550749755227920062==--