From bugzilla-daemon@bugs.koha-community.org Wed May 22 10:30:35 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] New: TestBuilder generates incorrect JS and CSS for libraries Date: Wed, 22 May 2024 08:30:34 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2459070089733716820==" --===============2459070089733716820== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D36916 Bug ID: 36916 Summary: TestBuilder generates incorrect JS and CSS for libraries Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 32721 TestBuilder generates random strings for branches.opacuserjs and branches.opacusercss which produces invalid JS and CSS. Selenium has several warnings related to this: koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-user.pl, line 1744: ReferenceError: CLYxPjQ152 is not defined koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-search.pl, line 2069: ReferenceError: CLYxPjQ152 is not defined koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-reserve.pl, line 1351: ReferenceError: CLYxPjQ152 is not defined Because of the following in the DOM I would suggest to set to an empty string by default, to prevent random failu= re or inconsistent behaviours when testing the UI. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D32721 [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC --=20 You are receiving this mail because: You are watching all bug changes. --===============2459070089733716820==-- From bugzilla-daemon@bugs.koha-community.org Wed May 22 10:33:07 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] TestBuilder generates incorrect JS and CSS for libraries Date: Wed, 22 May 2024 08:33:06 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3597926593923627256==" --===============3597926593923627256== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============3597926593923627256==-- From bugzilla-daemon@bugs.koha-community.org Wed May 22 10:33:18 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] TestBuilder generates incorrect JS and CSS for libraries Date: Wed, 22 May 2024 08:33:09 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8132698285525732634==" --===============8132698285525732634== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916 --- Comment #1 from Jonathan Druart --- Created attachment 167011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167011&action=edit Bug 36916: Do not generate invalid JS or CSS from TestBuilder TestBuilder generates random strings for branches.opacuserjs and branches.opacusercss which produces invalid JS and CSS. Selenium has several warnings related to this: koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-user.pl, line 1744: ReferenceError: CLYxPjQ152 is not defined koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-search.pl, line 2069: ReferenceError: CLYxPjQ152 is not defined koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-reserve.pl, line 1351: ReferenceError: CLYxPjQ152 is not defined Because of the following in the DOM This patch suggests to set to an empty string by default, to prevent random failure or inconsistent behaviours when testing the UI. Test plan: Run t/db_dependent/selenium/authentication.t and watch the selenium output. With this patch applied you will not see the "JavaScript error" lines -- You are receiving this mail because: You are watching all bug changes. --===============8132698285525732634==-- From bugzilla-daemon@bugs.koha-community.org Thu May 23 06:04:16 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] TestBuilder generates incorrect JS and CSS for libraries Date: Thu, 23 May 2024 04:04:15 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0487309442290359920==" --===============0487309442290359920== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============0487309442290359920==-- From bugzilla-daemon@bugs.koha-community.org Thu May 23 06:04:26 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] TestBuilder generates incorrect JS and CSS for libraries Date: Thu, 23 May 2024 04:04:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6160016698978273736==" --===============6160016698978273736== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167011|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 167055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167055&action=edit Bug 36916: Do not generate invalid JS or CSS from TestBuilder TestBuilder generates random strings for branches.opacuserjs and branches.opacusercss which produces invalid JS and CSS. Selenium has several warnings related to this: koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-user.pl, line 1744: ReferenceError: CLYxPjQ152 is not defined koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-search.pl, line 2069: ReferenceError: CLYxPjQ152 is not defined koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-reserve.pl, line 1351: ReferenceError: CLYxPjQ152 is not defined Because of the following in the DOM This patch suggests to set to an empty string by default, to prevent random failure or inconsistent behaviours when testing the UI. Test plan: Run t/db_dependent/selenium/authentication.t and watch the selenium output. With this patch applied you will not see the "JavaScript error" lines Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. --===============6160016698978273736==-- From bugzilla-daemon@bugs.koha-community.org Fri May 24 11:44:29 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] TestBuilder generates incorrect JS and CSS for libraries Date: Fri, 24 May 2024 09:44:28 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0230224179130056455==" --===============0230224179130056455== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. --===============0230224179130056455==-- From bugzilla-daemon@bugs.koha-community.org Fri May 24 11:44:50 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] TestBuilder generates incorrect JS and CSS for libraries Date: Fri, 24 May 2024 09:44:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7601614147615328491==" --===============7601614147615328491== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167055|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 167161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167161&action=edit Bug 36916: Do not generate invalid JS or CSS from TestBuilder TestBuilder generates random strings for branches.opacuserjs and branches.opacusercss which produces invalid JS and CSS. Selenium has several warnings related to this: koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-user.pl, line 1744: ReferenceError: CLYxPjQ152 is not defined koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-search.pl, line 2069: ReferenceError: CLYxPjQ152 is not defined koha-selenium-1 | JavaScript error: http://koha:8080/cgi-bin/koha/opac-reserve.pl, line 1351: ReferenceError: CLYxPjQ152 is not defined Because of the following in the DOM This patch suggests to set to an empty string by default, to prevent random failure or inconsistent behaviours when testing the UI. Test plan: Run t/db_dependent/selenium/authentication.t and watch the selenium output. With this patch applied you will not see the "JavaScript error" lines Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. --===============7601614147615328491==-- From bugzilla-daemon@bugs.koha-community.org Fri May 24 11:45:00 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] TestBuilder generates incorrect JS and CSS for libraries Date: Fri, 24 May 2024 09:44:41 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5955323802811250157==" --===============5955323802811250157== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. --===============5955323802811250157==-- From bugzilla-daemon@bugs.koha-community.org Fri May 24 15:41:12 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] TestBuilder generates incorrect JS and CSS for libraries Date: Fri, 24 May 2024 13:40:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1780005440615393857==" --===============1780005440615393857== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. --===============1780005440615393857==-- From bugzilla-daemon@bugs.koha-community.org Fri May 24 15:41:22 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] TestBuilder generates incorrect JS and CSS for libraries Date: Fri, 24 May 2024 13:40:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5698603972060906717==" --===============5698603972060906717== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916 --- Comment #4 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. --===============5698603972060906717==-- From bugzilla-daemon@bugs.koha-community.org Thu May 30 10:13:19 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] TestBuilder generates incorrect JS and CSS for libraries Date: Thu, 30 May 2024 08:13:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6297767587214724048==" --===============6297767587214724048== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes. --===============6297767587214724048==-- From bugzilla-daemon@bugs.koha-community.org Fri May 31 17:34:57 2024 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 36916] TestBuilder generates incorrect JS and CSS for libraries Date: Fri, 31 May 2024 15:34:56 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0451114573976979965==" --===============0451114573976979965== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36916 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #6 from Lucas Gass --- Missing 23,05.x dependencies, no backport -- You are receiving this mail because: You are watching all bug changes. --===============0451114573976979965==--