From bugzilla-daemon@bugs.koha-community.org Tue Feb 18 23:54:26 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
Date: Tue, 18 Feb 2020 22:54:25 +0000
Message-ID: <bug-4461-70-ifHEa9tpxd@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0324873507509316130=="

--===============0324873507509316130==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D4461

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Hi Aleisha,=20

starting with review and QA tools here:

1) Can you check if this is a real one or a false positive?=20
 FAIL   Koha/ProblemReport.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=3DPackageName -e666


2) Please fix filters:

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt
   FAIL   filters
                missing_filter at line 3 (<title>[% IF ( LibraryNameTitle )
%][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog &rsaquo; Report
a Problem</title>)
                missing_filter at line 31 (                        <div
class=3D"alert alert-info">Your problem report has been sent to the [% IF (
recipient =3D=3D 'admin' ) %]Koha Administrator[% ELSE %][% recipient %][% END
%].</div>)
                missing_filter at line 56 (                                  =
 =20
       <input type=3D"hidden" name=3D"place" id=3D"place" value=3D"[% probpag=
e %]">)
                missing_filter at line 61 (                                  =
 =20
       <input type=3D"hidden" name=3D"user" id=3D"user" value=3D"[% username =
%]"
class=3D"span3">)
                missing_filter at line 65 (                                  =
 =20
       <input type=3D"text" name=3D"subject" id=3D"subject" value=3D"[% subje=
ct %]"
class=3D"span3">)


3) Database update

You got:
+    $dbh->do(q{ DROP TABLE IF EXISTS `problem_reports` });

I think this could be destructive in some cases. I think checking for existen=
ce
of the table is better:

20126     if ( !TableExists('return_claims') ) {


4) Capitalization

catalog &rsaquo; Report a Problem</title>
Koha Administrator

5)   print
$input->redirect("/cgi-bin/koha/opac-reportproblem?norecipients=3D1.pl");

Looks like a typo with the .pl at the end?

6) Translatatability

I these go in the email to the library/admin, but won't be translatable:=20

+    $problemreport->{code} =3D 'PROBLEM_REPORT';
+    $problemreport->{content} .=3D "\nUsername: $username";
+    $problemreport->{content} .=3D "\nProblem page: $place";

Using a notice template would be the most elegant way to make those
translatable. I think with
https://bugs.koha-community.org/bugzilla3/showdependencytree.cgi?id=3D15395&h=
ide_resolved=3D1
you can not yet add strings to .pl fils in a translatable way.


If I understand correctly the only way to access the reports for now would be=
 a
report? It might be nice (new bug!) to have this on the dashoard and visible =
in
staff or even the patron account :)

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============0324873507509316130==--