From bugzilla-daemon@bugs.koha-community.org Wed Sep  6 08:46:57 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] New: Remove use of onclick for OPAC cart
Date: Wed, 06 Sep 2023 06:46:56 +0000
Message-ID: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0217788157664009217=="

--===============0217788157664009217==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

            Bug ID: 34725
           Summary: Remove use of onclick for OPAC cart
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard@myacpl.org
          Reporter: dcook@prosentient.com.au
        QA Contact: testopia@bugs.koha-community.org
            Blocks: 34709

Like bug 34570, we want to get rid of "onclick".


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709
[Bug 34709] Eliminate event handler attributes in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============0217788157664009217==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  6 08:58:13 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Wed, 06 Sep 2023 06:58:12 +0000
Message-ID: <bug-34725-70-eQsa5zJFJ9@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6470460129106544544=="

--===============6470460129106544544==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6470460129106544544==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  6 08:58:24 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Wed, 06 Sep 2023 06:58:15 +0000
Message-ID: <bug-34725-70-jmC3o0Ku77@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6393432084677185229=="

--===============6393432084677185229==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

--- Comment #1 from David Cook <dcook@prosentient.com.au> ---
Created attachment 155256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155256&action=edit
Bug 34725: Remove use of onclick for OPAC cart

This patch moves the click handler in the OPAC cart from the inline HTML
and out to an existing <script> element.

Test plan:
0. Apply the patch
1. Go to
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
2. Add the results to the cart
3. Click on the "Cart"
4. One by one click on the title of each row
5. Notice how the parent window changes to the detail record for that title

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6393432084677185229==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  6 09:01:21 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Wed, 06 Sep 2023 07:00:56 +0000
Message-ID: <bug-34725-70-tsU49gMV0R@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4655513049156125549=="

--===============4655513049156125549==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=34726

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4655513049156125549==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  6 09:01:31 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Wed, 06 Sep 2023 07:01:03 +0000
Message-ID: <bug-34725-70-7MXbFwVMQ1@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3221510979566216287=="

--===============3221510979566216287==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard@myacpl.org         |dcook@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============3221510979566216287==--


From bugzilla-daemon@bugs.koha-community.org Wed Sep  6 09:04:06 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Wed, 06 Sep 2023 07:03:56 +0000
Message-ID: <bug-34725-70-lVubysmOh2@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1242117142787194545=="

--===============1242117142787194545==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

David Cook <dcook@prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |34726


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726
[Bug 34726] Clicking the title of a record in cart creates URL with duplicate
query strings
-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1242117142787194545==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  7 14:25:04 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Thu, 07 Sep 2023 12:25:03 +0000
Message-ID: <bug-34725-70-ljvRsqfGVS@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4577536762102974615=="

--===============4577536762102974615==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

Pedro Amorim <pedro.amorim@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4577536762102974615==--


From bugzilla-daemon@bugs.koha-community.org Thu Sep  7 14:25:14 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Thu, 07 Sep 2023 12:25:05 +0000
Message-ID: <bug-34725-70-e20NzGk9f3@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4615469861804967871=="

--===============4615469861804967871==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

Pedro Amorim <pedro.amorim@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155256|0                           |1
        is obsolete|                            |

--- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> ---
Created attachment 155297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155297&action=edit
Bug 34725: Remove use of onclick for OPAC cart

This patch moves the click handler in the OPAC cart from the inline HTML
and out to an existing <script> element.

Test plan:
0. Apply the patch
1. Go to
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
2. Add the results to the cart
3. Click on the "Cart"
4. One by one click on the title of each row
5. Notice how the parent window changes to the detail record for that title

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4615469861804967871==--


From bugzilla-daemon@bugs.koha-community.org Sun Sep 17 16:10:32 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Sun, 17 Sep 2023 14:10:31 +0000
Message-ID: <bug-34725-70-1tBWfmYdgM@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6477062715634532622=="

--===============6477062715634532622==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6477062715634532622==--


From bugzilla-daemon@bugs.koha-community.org Sun Sep 17 16:13:00 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Sun, 17 Sep 2023 14:13:00 +0000
Message-ID: <bug-34725-70-Ac8GGHuXav@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1170543196005370930=="

--===============1170543196005370930==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============1170543196005370930==--


From bugzilla-daemon@bugs.koha-community.org Sun Sep 17 16:13:11 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Sun, 17 Sep 2023 14:13:02 +0000
Message-ID: <bug-34725-70-S3iebTlhqB@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4966677224403008551=="

--===============4966677224403008551==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155297|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Created attachment 155757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155757&action=edit
Bug 34725: Remove use of onclick for OPAC cart

This patch moves the click handler in the OPAC cart from the inline HTML
and out to an existing <script> element.

Test plan:
0. Apply the patch
1. Go to
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
2. Add the results to the cart
3. Click on the "Cart"
4. One by one click on the title of each row
5. Notice how the parent window changes to the detail record for that title

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4966677224403008551==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep 18 17:06:49 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Mon, 18 Sep 2023 15:04:24 +0000
Message-ID: <bug-34725-70-PRKfuZ3xrA@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2490622074777700269=="

--===============2490622074777700269==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

Tomás Cohen Arazi <tomascohen@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |23.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============2490622074777700269==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep 18 17:06:59 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Mon, 18 Sep 2023 15:04:26 +0000
Message-ID: <bug-34725-70-4fRCERqgtw@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8981664594935344889=="

--===============8981664594935344889==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

--- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============8981664594935344889==--


From bugzilla-daemon@bugs.koha-community.org Mon Sep 18 22:40:27 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Mon, 18 Sep 2023 20:40:26 +0000
Message-ID: <bug-34725-70-Gr2PadL95J@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4782230309271212175=="

--===============4782230309271212175==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

Fridolin Somers <fridolin.somers@biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers@biblibre.co
                   |                            |m
             Status|Pushed to master            |Pushed to stable
         Version(s)|23.11.00                    |23.11.00,23.05.04
        released in|                            |

--- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Pushed to 23.05.x for 23.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============4782230309271212175==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct 12 18:03:19 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Thu, 12 Oct 2023 16:01:04 +0000
Message-ID: <bug-34725-70-acYKRlvhOq@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6570658668408105553=="

--===============6570658668408105553==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|23.11.00,23.05.04           |23.11.00,23.05.04,22.11.11
        released in|                            |
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6570658668408105553==--


From bugzilla-daemon@bugs.koha-community.org Thu Oct 12 18:03:30 2023
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 34725] Remove use of onclick for OPAC cart
Date: Thu, 12 Oct 2023 16:01:06 +0000
Message-ID: <bug-34725-70-QxLqKruch4@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-34725-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6954213570450846078=="

--===============6954213570450846078==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34725

--- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> ---
Nice work everyone!

Pushed to oldstable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

--===============6954213570450846078==--