From bugzilla-daemon@bugs.koha-community.org Mon Feb  1 12:52:40 2016
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on
 self registration.
Date: Mon, 01 Feb 2016 11:52:35 +0000
Message-ID: <bug-15343-70-xf8m8xqBK2@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-15343-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2845459736043786855=="

--===============2845459736043786855==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D15343

--- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org=
> ---
Comment on attachment 47407
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3D47407
Bug 15343 - Allow user to set password on opac-memberentry.pl

Review of attachment 47407:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=3Dsplinter.html&b=
ug=3D15343&attachment=3D47407)
-----------------------------------------------------------------

There is a third case to check: if the password contain leading or trailing
whitespaces, see bug 14509.

::: C4/Members.pm
@@ +2482,5 @@
>      $borrower{'cardnumber'} =3D fixup_cardnumber();
> =20
>      my $borrowernumber =3D AddMember(%borrower);
> =20
> +    return ( $borrowernumber, $borrower{'password'} );

Why do you return the password?
You should compare the hashed password (Koha::AuthUtils::hash_password) in the
test.

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
@@ +60,5 @@
>                                  [% IF field =3D=3D "email" %]<li>Contact i=
nformation: <a href=3D"#borrower_email">primary email address</a></li>[% END =
%]
>                                  [% IF field =3D=3D "emailpro" %]<li>Contac=
t information: <a href=3D"#borrower_emailpro">secondary email address</a></li=
>[% END %]
>                                  [% IF field =3D=3D "B_email" %]<li>Alterna=
te address information: <a href=3D"#borrower_B_email">email address</a></li>[=
% END %]
> +                                [% IF field =3D=3D "password_match" %]<li>=
Passwords do not match! <a href=3D"#password">password</a></li>[% END %]
> +                                [% IF field =3D=3D "password_invalid" %]<l=
i>Password does not meet minium requirements! <a href=3D"#password">password<=
/a></li>[% END %]

typo minimum.

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============2845459736043786855==--