From bugzilla-daemon@bugs.koha-community.org Wed May 13 22:13:06 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] New: Unhandled exceptions cause an exception Date: Wed, 13 May 2020 20:13:05 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6903241037414214367==" --===============6903241037414214367== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D25493 Bug ID: 25493 Summary: Unhandled exceptions cause an exception Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com We rushed into using Koha::Logger as a Mojo::Log implementation, but there are some differences that need to be addressed before that can actually happen. This is not *that* problematic for production sites, but some things like hitting an undefined route will raise weird errors we need to avoid: GET http://kohadev.myDNSname.org:8081/api/v1/hola The application raised the following error: Can't use an undefined value as an ARRAY reference at template mojo/debug.html.ep line 311. 306: %=3D $kv->(Time =3D> scalar localtime(time)) 307: 308: 309:
tap for more
310: 311: % if (@{app->log->history}) { 312:
313: 314: % for my $msg (@{app->log->history}) { 315: 316:
and the StackTrace middleware couldn't catch its stack trace, possibly because your application overrides $SIG{__DIE__} by itself, preventing the middleware from working correctly. Remove the offending code or module that does it: kno= wn examples are CGI::Carp and Carp::Always. <<<<< We need to move back to using plain Koha::Logger, and rethink the proposal fr= om bug 18205 to use MojoX::Log::Log4perl. That certainly belongs to another bug. --=20 You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. --===============6903241037414214367==-- From bugzilla-daemon@bugs.koha-community.org Wed May 13 22:13:46 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Wed, 13 May 2020 20:13:45 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7476453054111680434==" --===============7476453054111680434== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unhandled exceptions cause |Koha::Logger is not |an exception |suitable for using as | |Mojo::Log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============7476453054111680434==-- From bugzilla-daemon@bugs.koha-community.org Wed May 13 22:13:56 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Wed, 13 May 2020 20:13:50 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1544445527499561323==" --===============1544445527499561323== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. --===============1544445527499561323==-- From bugzilla-daemon@bugs.koha-community.org Wed May 13 22:38:24 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Wed, 13 May 2020 20:38:23 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0651441601671561804==" --===============0651441601671561804== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 104852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104852&action=edit Bug 25493: Make ->unhandled_exception use Koha::Logger To test: 1. Edit the Koha/REST/V1/Cities.pm 'list' method adding die("Nada"); before the render step. 2. Restart plack and try the endpoint => SUCCESS: The message is generic, but you see something is logged in /var/log/koha/kohadev/api-error.log 3. Change die("Nada"); for a real exception like: use Koha::Exceptions; Koha::Exceptions::DuplicateObject->throw("Nada"); 4. Repeat 2. => SUCCESS: The message is generic, but a meaningful text is added to the logs. 5. Point your browser to the /api/v1/hola route from your dev environment => FAIL: Wow, such a weird error 6. Apply this patch 7. Restart plack and repeat 2, 3 and 4 => SUCCESS: No behaviour change 8. Repeat 5 => SUCCESS: The regular Mojolicious 404 weird page 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. --===============0651441601671561804==-- From bugzilla-daemon@bugs.koha-community.org Wed May 13 22:39:01 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Wed, 13 May 2020 20:39:00 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4837682882334998379==" --===============4837682882334998379== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. --===============4837682882334998379==-- From bugzilla-daemon@bugs.koha-community.org Wed May 13 22:40:02 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Wed, 13 May 2020 20:40:01 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3872646739098722925==" --===============3872646739098722925== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25032 Keywords| |rel_20_05_candidate Severity|major |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 [Bug 25032] Generic unhandled exception handling -- You are receiving this mail because: You are watching all bug changes. --===============3872646739098722925==-- From bugzilla-daemon@bugs.koha-community.org Thu May 14 11:05:36 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Thu, 14 May 2020 09:05:35 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5830739189207094264==" --===============5830739189207094264== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@bugs.koha-c | |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. --===============5830739189207094264==-- From bugzilla-daemon@bugs.koha-community.org Fri May 15 22:19:21 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Fri, 15 May 2020 20:19:20 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0526033388549086435==" --===============0526033388549086435== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. --===============0526033388549086435==-- From bugzilla-daemon@bugs.koha-community.org Mon May 18 14:20:31 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Mon, 18 May 2020 12:20:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1995390438874237742==" --===============1995390438874237742== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. --===============1995390438874237742==-- From bugzilla-daemon@bugs.koha-community.org Mon May 18 14:58:30 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Mon, 18 May 2020 12:58:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7782270696571568603==" --===============7782270696571568603== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. --===============7782270696571568603==-- From bugzilla-daemon@bugs.koha-community.org Mon May 18 14:58:41 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Mon, 18 May 2020 12:58:33 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0710575679691846242==" --===============0710575679691846242== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104852|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 105016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105016&action=edit Bug 25493: Make ->unhandled_exception use Koha::Logger To test: 1. Edit the Koha/REST/V1/Cities.pm 'list' method adding die("Nada"); before the render step. 2. Restart plack and try the endpoint => SUCCESS: The message is generic, but you see something is logged in /var/log/koha/kohadev/api-error.log 3. Change die("Nada"); for a real exception like: use Koha::Exceptions; Koha::Exceptions::DuplicateObject->throw("Nada"); 4. Repeat 2. => SUCCESS: The message is generic, but a meaningful text is added to the logs. 5. Point your browser to the /api/v1/hola route from your dev environment => FAIL: Wow, such a weird error 6. Apply this patch 7. Restart plack and repeat 2, 3 and 4 => SUCCESS: No behaviour change 8. Repeat 5 => SUCCESS: The regular Mojolicious 404 weird page 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. --===============0710575679691846242==-- From bugzilla-daemon@bugs.koha-community.org Tue May 19 16:13:30 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Tue, 19 May 2020 14:13:29 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8746110125289647002==" --===============8746110125289647002== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105016|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 105100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105100&action=edit Bug 25493: Make ->unhandled_exception use Koha::Logger To test: 1. Edit the Koha/REST/V1/Cities.pm 'list' method adding die("Nada"); before the render step. 2. Restart plack and try the endpoint => SUCCESS: The message is generic, but you see something is logged in /var/log/koha/kohadev/api-error.log 3. Change die("Nada"); for a real exception like: use Koha::Exceptions; Koha::Exceptions::DuplicateObject->throw("Nada"); 4. Repeat 2. => SUCCESS: The message is generic, but a meaningful text is added to the logs. 5. Point your browser to the /api/v1/hola route from your dev environment => FAIL: Wow, such a weird error 6. Apply this patch 7. Restart plack and repeat 2, 3 and 4 => SUCCESS: No behaviour change 8. Repeat 5 => SUCCESS: The regular Mojolicious 404 weird page 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. --===============8746110125289647002==-- From bugzilla-daemon@bugs.koha-community.org Tue May 19 16:14:17 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Tue, 19 May 2020 14:14:08 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1945686292352707025==" --===============1945686292352707025== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- A simple pragmatic approach to resolving the bug before release, thanks guys Passing QA -- You are receiving this mail because: You are watching all bug changes. --===============1945686292352707025==-- From bugzilla-daemon@bugs.koha-community.org Tue May 19 16:21:31 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Tue, 19 May 2020 14:21:30 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1646420155414067936==" --===============1646420155414067936== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. --===============1646420155414067936==-- From bugzilla-daemon@bugs.koha-community.org Tue May 19 16:21:41 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Tue, 19 May 2020 14:21:32 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7015964737156253236==" --===============7015964737156253236== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. --===============7015964737156253236==-- From bugzilla-daemon@bugs.koha-community.org Tue May 19 17:18:38 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Tue, 19 May 2020 15:18:36 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2381242954741876817==" --===============2381242954741876817== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes. --===============2381242954741876817==-- From bugzilla-daemon@bugs.koha-community.org Wed May 20 23:12:18 2020 From: bugzilla-daemon@bugs.koha-community.org To: koha-bugs@lists.koha-community.org Subject: [Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log Date: Wed, 20 May 2020 21:12:18 +0000 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4671036904305024050==" --===============4671036904305024050== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #6 from Joy Nelson --- missing dependencies-not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. --===============4671036904305024050==--