From bugzilla-daemon@bugs.koha-community.org Sun Jun 21 17:53:19 2020
From: bugzilla-daemon@bugs.koha-community.org
To: koha-bugs@lists.koha-community.org
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
 on a timeline or per field.
Date: Sun, 21 Jun 2020 15:53:18 +0000
Message-ID: <bug-14367-70-z4tirroaa1@https.bugs.koha-community.org/bugzilla3/>
In-Reply-To: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7634608273795769523=="

--===============7634608273795769523==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3D14367

Katrin Fischer <katrin.fischer@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Really interesting feature, starting with QA tools:

 FAIL   installer/data/mysql/atomicupdate/add_history.sql
   FAIL   git manipulation
                The file has been added and deleted in the same patchset

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
   FAIL   filters
                missing_filter at line 903 (                                 =
 =20
                <a href=3D"#" class=3D"buttonHistory" id=3D"[%- mv.id -%]">)
                missing_filter at line 904 (                                 =
 =20
                    <img src=3D"[% interface %]/[% theme %]/img/icon-history.=
png"
alt=3D"History" title=3D"Display history for this field" />)
                missing_filter at line 904 (                                 =
 =20
                    <img src=3D"[% interface %]/[% theme %]/img/icon-history.=
png"
alt=3D"History" title=3D"Display history for this field" />)
                missing_filter at line 908 (                                 =
 =20
            <table class=3D"history_table" id=3D"[%- mv.id -%]_history" name=
=3D"[%-
mv.name -%]_history">)
                missing_filter at line 908 (                                 =
 =20
            <table class=3D"history_table" id=3D"[%- mv.id -%]_history" name=
=3D"[%-
mv.name -%]_history">)
                missing_filter at line 916 (                                 =
 =20
                    <td><a href=3D"#" data-tag=3D'[%- mv.id -%]' data-history=
=3D'[%
hist.data %]' class=3D'hist_rollback'>[% hist.data %]</a></td>)
                missing_filter a

 FAIL   Koha/MetadataRecord/History.pm
   FAIL   critic
                "return" statement with explicit "undef" at line 103, column =
9.
See page 199 of PBP.

Can you please fix?

--=20
You are receiving this mail because:
You are watching all bug changes.

--===============7634608273795769523==--